[PATCH] Fix missing stream for second ADC on Realtek ALC260 HDA codec

[PATCH] Fix missing stream for second ADC on Realtek ALC260 HDA codec

[Jonathan Woithe]

Hi all

I discovered tonight that ALSA no longer sets up a stream for the second ADC
provided by the Realtek ALC260 HDA codec.  At some point alc_build_pcms()
started using stream_analog_alt_capture when constructing the second ADC
stream, but patch_alc260() was never updated accordingly.  I have no idea
when this regression occurred.  The trivial patch to patch_alc260() given
below fixes the problem as far as I can tell.  The patch is against 2.6.35.

Signed-off-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>

--- linux-2.6.35-orig/sound/pci/hda/patch_realtek.c	2010-08-02 07:41:14.000000000 +0930
+++ linux-2.6.35/sound/pci/hda/patch_realtek.c	2010-08-08 00:06:19.670695899 +0930
@@ -6863,6 +6863,7 @@
 
 	spec->stream_analog_playback = &alc260_pcm_analog_playback;
 	spec->stream_analog_capture = &alc260_pcm_analog_capture;
+	spec->stream_analog_alt_capture = &alc260_pcm_analog_capture;
 
 	spec->stream_digital_playback = &alc260_pcm_digital_playback;
 	spec->stream_digital_capture = &alc260_pcm_digital_capture;

Re: [PATCH] Fix missing stream for second ADC on Realtek ALC260 HDA codec

[Takashi Iwai]

At Sun, 8 Aug 2010 00:17:05 +0930 (CST),
Jonathan Woithe wrote:
> 
> Hi all
> 
> I discovered tonight that ALSA no longer sets up a stream for the second ADC
> provided by the Realtek ALC260 HDA codec.  At some point alc_build_pcms()
> started using stream_analog_alt_capture when constructing the second ADC
> stream, but patch_alc260() was never updated accordingly.  I have no idea
> when this regression occurred.  The trivial patch to patch_alc260() given
> below fixes the problem as far as I can tell.  The patch is against 2.6.35.
> 
> Signed-off-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>

Thanks, applied now with Cc to stable kernel.


Takashi

> 
> --- linux-2.6.35-orig/sound/pci/hda/patch_realtek.c	2010-08-02 07:41:14.000000000 +0930
> +++ linux-2.6.35/sound/pci/hda/patch_realtek.c	2010-08-08 00:06:19.670695899 +0930
> @@ -6863,6 +6863,7 @@
>  
>  	spec->stream_analog_playback = &alc260_pcm_analog_playback;
>  	spec->stream_analog_capture = &alc260_pcm_analog_capture;
> +	spec->stream_analog_alt_capture = &alc260_pcm_analog_capture;
>  
>  	spec->stream_digital_playback = &alc260_pcm_digital_playback;
>  	spec->stream_digital_capture = &alc260_pcm_digital_capture;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>