[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Mark Brown]

The irqs.h usage here got missed in the Samsung platform reorganisation.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
---
 arch/arm/mach-s3c64xx/dev-spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dev-spi.c b/arch/arm/mach-s3c64xx/dev-spi.c
index a492b98..bfa3ef7 100644
--- a/arch/arm/mach-s3c64xx/dev-spi.c
+++ b/arch/arm/mach-s3c64xx/dev-spi.c
@@ -18,10 +18,10 @@
 #include <mach/map.h>
 #include <mach/gpio-bank-c.h>
 #include <mach/spi-clocks.h>
+#include <mach/irqs.h>
 
 #include <plat/s3c64xx-spi.h>
 #include <plat/gpio-cfg.h>
-#include <plat/irqs.h>
 
 static char *spi_src_clks[] = {
 	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
-- 
1.7.1

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Mark Brown]

Avoids build warnings due to the undeclared non-statics.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-s3c64xx/dev-spi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dev-spi.c b/arch/arm/mach-s3c64xx/dev-spi.c
index bfa3ef7..405e621 100644
--- a/arch/arm/mach-s3c64xx/dev-spi.c
+++ b/arch/arm/mach-s3c64xx/dev-spi.c
@@ -22,6 +22,7 @@
 
 #include <plat/s3c64xx-spi.h>
 #include <plat/gpio-cfg.h>
+#include <plat/devs.h>
 
 static char *spi_src_clks[] = {
 	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
-- 
1.7.1

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Kukjin Kim]

Mark Brown wrote:
> 
> Avoids build warnings due to the undeclared non-statics.
> 
Could you please let me know what's the build warning?

> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  arch/arm/mach-s3c64xx/dev-spi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/dev-spi.c
b/arch/arm/mach-s3c64xx/dev-spi.c
> index bfa3ef7..405e621 100644
> --- a/arch/arm/mach-s3c64xx/dev-spi.c
> +++ b/arch/arm/mach-s3c64xx/dev-spi.c
> @@ -22,6 +22,7 @@
> 
>  #include <plat/s3c64xx-spi.h>
>  #include <plat/gpio-cfg.h>
> +#include <plat/devs.h>
> 
>  static char *spi_src_clks[] = {
>  	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
> --


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Mark Brown]

On Wed, Sep 08, 2010 at 09:39:21PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:

> > Avoids build warnings due to the undeclared non-statics.

> Could you please let me know what's the build warning?

It'll have been something along the lines of:

's3c64xx_device_iis0' not declared; should it be static?

for each device.  Possibly generated by sparse rather than GCC - I
always build with sparse as well.

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Kukjin Kim]

Mark Brown wrote:
> 
> On Wed, Sep 08, 2010 at 09:39:21PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> 
> > > Avoids build warnings due to the undeclared non-statics.
> 
> > Could you please let me know what's the build warning?
> 
> It'll have been something along the lines of:
> 
> 's3c64xx_device_iis0' not declared; should it be static?
> 

> for each device.  Possibly generated by sparse rather than GCC - I
> always build with sparse as well.

Hi Mark,

Sorry...I can't understand your comment.

You mean the build warning is 's3c64xx_device_iis0' is not declared..right?
Hmm...the 's3c64xx_device_iis0' used only in a mach-s3c64xx/mach-smartq.c
file.
And defined it as extern struct in a plat-samsung/include/plat/devs.h file.
...So...why need to modify mach-s3c64xx/dev-spi.c for it?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Mark Brown]

On Thu, Sep 09, 2010 at 08:18:10PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:

> > It'll have been something along the lines of:

> > 's3c64xx_device_iis0' not declared; should it be static?

> > for each device.  Possibly generated by sparse rather than GCC - I
> > always build with sparse as well.

> You mean the build warning is 's3c64xx_device_iis0' is not declared..right?

Yes, or words to that effect.

> Hmm...the 's3c64xx_device_iis0' used only in a mach-s3c64xx/mach-smartq.c
> file.
> And defined it as extern struct in a plat-samsung/include/plat/devs.h file.
> ...So...why need to modify mach-s3c64xx/dev-spi.c for it?

The complaint is that the symbol has been defined in the C file with
global scope but there's no declaration for it.  This means that either
the symbol is not supposed to be global scope and should be static
instead (which isn't the case here, machines are supposed to be able to
reference it) or that there is nothing checking that the declaration
that other files use to talk about the symbol matches the defintion.  If
the users are using a different declaration then the memory layout and
alignment may not be correct for them, causing errors at runtime.

In other words the file has:

struct platform_device s3c64xx_device_iis0 = {
	...
};

and the compiler/sparse is expecting to see:

struct platform_device s3c64xx_device_iis0;

before that, which comes from devs.h.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Kukjin Kim]

Mark Brown wrote:
> 
> The irqs.h usage here got missed in the Samsung platform reorganisation.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Maybe Jassi wants to use 'jassi.brar at samsung.com' e-mail...but I'm not sure
;-)

Anyway, this is ok to me...and how about mach-s5pc100/dev-spi.c?
And I think, this should be gone to upstream via Ben's tree...

> ---
>  arch/arm/mach-s3c64xx/dev-spi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/dev-spi.c
b/arch/arm/mach-s3c64xx/dev-spi.c
> index a492b98..bfa3ef7 100644
> --- a/arch/arm/mach-s3c64xx/dev-spi.c
> +++ b/arch/arm/mach-s3c64xx/dev-spi.c
> @@ -18,10 +18,10 @@
>  #include <mach/map.h>
>  #include <mach/gpio-bank-c.h>
>  #include <mach/spi-clocks.h>
> +#include <mach/irqs.h>
> 
>  #include <plat/s3c64xx-spi.h>
>  #include <plat/gpio-cfg.h>
> -#include <plat/irqs.h>
> 
>  static char *spi_src_clks[] = {
>  	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
> --


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Mark Brown]

On Wed, Sep 08, 2010 at 08:52:48PM +0900, Kukjin Kim wrote:

> Anyway, this is ok to me...and how about mach-s5pc100/dev-spi.c?

I've not looked at S5PC100 since I don't have any boards with that.

> And I think, this should be gone to upstream via Ben's tree...

Yup, though the MAINTAINERS pattern matches you both.  I'm resending due
to lack of any response from Ben.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Kukjin Kim]

Mark Brown wrote:
> 
> On Wed, Sep 08, 2010 at 08:52:48PM +0900, Kukjin Kim wrote:
> 
> > Anyway, this is ok to me...and how about mach-s5pc100/dev-spi.c?
> 
> I've not looked at S5PC100 since I don't have any boards with that.
> 
Ok..I will sort out others.

> > And I think, this should be gone to upstream via Ben's tree...
> 
> Yup, though the MAINTAINERS pattern matches you both.  I'm resending due
> to lack of any response from Ben.

mm...if he busy, I will/can do it :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Jassi Brar]

On Wed, Sep 8, 2010 at 8:52 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Mark Brown wrote:
>>
>> The irqs.h usage here got missed in the Samsung platform reorganisation.
>>
>> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
>
> Maybe Jassi wants to use 'jassi.brar at samsung.com' e-mail...but I'm not sure
> ;-)

Yes, that would be better.

I have to use personal id because I can't always reply from the official one.
Otherwise, I'd prefer my work to be tagged with jassi.brar at samsung.com

Thanks.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Mark Brown]

On Wed, Sep 08, 2010 at 11:17:51PM +0900, Jassi Brar wrote:

> I have to use personal id because I can't always reply from the official one.
> Otherwise, I'd prefer my work to be tagged with jassi.brar at samsung.com

OK, I'll amend it.  I just cut'n'pasted from your ack mail IIRC.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Jassi Brar]

On Thu, Sep 9, 2010 at 1:01 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Sep 08, 2010 at 11:17:51PM +0900, Jassi Brar wrote:
>
>> I have to use personal id because I can't always reply from the official one.
>> Otherwise, I'd prefer my work to be tagged with jassi.brar at samsung.com
>
> OK, I'll amend it. ?I just cut'n'pasted from your ack mail IIRC.

Ya that was my mistake, sorry.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Kukjin Kim]

Mark Brown wrote:
> 
> On Wed, Sep 08, 2010 at 11:17:51PM +0900, Jassi Brar wrote:
> 
> > I have to use personal id because I can't always reply from the official
one.
> > Otherwise, I'd prefer my work to be tagged with jassi.brar at samsung.com
> 
> OK, I'll amend it.  I just cut'n'pasted from your ack mail IIRC.

May I amend it when apply it into my tree?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Mark Brown]

On Thu, Sep 09, 2010 at 08:11:33PM +0900, Kukjin Kim wrote:
> Mark Brown wrote:

> > OK, I'll amend it.  I just cut'n'pasted from your ack mail IIRC.

> May I amend it when apply it into my tree?

That would seem sensible.  I'm talking about the copy I keep locally in
a queue to try to make sure things don't get dropped on the floor in
case maintainers are unresponsive.

[PATCH 1/2] ARM: S3C64XX: Fix dev-spi build

[Mark Brown]

The irqs.h usage here got missed in the Samsung platform reorganisation.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-s3c64xx/dev-spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dev-spi.c b/arch/arm/mach-s3c64xx/dev-spi.c
index a492b98..bfa3ef7 100644
--- a/arch/arm/mach-s3c64xx/dev-spi.c
+++ b/arch/arm/mach-s3c64xx/dev-spi.c
@@ -18,10 +18,10 @@
 #include <mach/map.h>
 #include <mach/gpio-bank-c.h>
 #include <mach/spi-clocks.h>
+#include <mach/irqs.h>
 
 #include <plat/s3c64xx-spi.h>
 #include <plat/gpio-cfg.h>
-#include <plat/irqs.h>
 
 static char *spi_src_clks[] = {
 	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
-- 
1.7.1

[PATCH 2/2] ARM: S3C64XX: Prototype SPI devices

[Mark Brown]

Avoids build warnings due to the undeclared non-statics.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-s3c64xx/dev-spi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dev-spi.c b/arch/arm/mach-s3c64xx/dev-spi.c
index bfa3ef7..405e621 100644
--- a/arch/arm/mach-s3c64xx/dev-spi.c
+++ b/arch/arm/mach-s3c64xx/dev-spi.c
@@ -22,6 +22,7 @@
 
 #include <plat/s3c64xx-spi.h>
 #include <plat/gpio-cfg.h>
+#include <plat/devs.h>
 
 static char *spi_src_clks[] = {
 	[S3C64XX_SPI_SRCCLK_PCLK] = "pclk",
-- 
1.7.1