All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt mooney <mfm@muteddisk.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, x86@kernel.org,
	kernel-janitors@vger.kernel.org,
	Chris Wright <chrisw@sous-sol.org>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] x86: remove cast from void*
Date: Tue, 21 Sep 2010 19:15:13 +0000	[thread overview]
Message-ID: <20100921191513.GA15107@haskell.muteddisk.com> (raw)
In-Reply-To: <4C98FBDB.6030601@goop.org>

On 11:39 Tue 21 Sep     , Jeremy Fitzhardinge wrote:
>  On 09/13/2010 10:18 PM, matt mooney wrote:
> > Unnecessary cast from void* in assignment.
> >
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> >  arch/x86/xen/mmu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index 42086ac..7436283 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
> >  
> >  	if (offset < pgd_index(USER_LIMIT)) {
> >  		struct page *page = virt_to_page(pgd_page);
> > -		user_ptr = (pgd_t *)page->private;
> > +		user_ptr = page->private;
> 
> Um, page->private is unsigned long anyway, so this is needed either way.
> 

You're right. I missed that one, sorry; I really thought I had verified it.

-mfm

WARNING: multiple messages have this Message-ID (diff)
From: matt mooney <mfm@muteddisk.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, x86@kernel.org,
	kernel-janitors@vger.kernel.org,
	Chris Wright <chrisw@sous-sol.org>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] x86: remove cast from void*
Date: Tue, 21 Sep 2010 12:15:13 -0700	[thread overview]
Message-ID: <20100921191513.GA15107@haskell.muteddisk.com> (raw)
In-Reply-To: <4C98FBDB.6030601@goop.org>

On 11:39 Tue 21 Sep     , Jeremy Fitzhardinge wrote:
>  On 09/13/2010 10:18 PM, matt mooney wrote:
> > Unnecessary cast from void* in assignment.
> >
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> >  arch/x86/xen/mmu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index 42086ac..7436283 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
> >  
> >  	if (offset < pgd_index(USER_LIMIT)) {
> >  		struct page *page = virt_to_page(pgd_page);
> > -		user_ptr = (pgd_t *)page->private;
> > +		user_ptr = page->private;
> 
> Um, page->private is unsigned long anyway, so this is needed either way.
> 

You're right. I missed that one, sorry; I really thought I had verified it.

-mfm

  reply	other threads:[~2010-09-21 19:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14  5:18 [PATCH 1/4] x86: remove cast from void* matt mooney
2010-09-14  5:18 ` matt mooney
2010-09-14 17:49 ` Jeremy Fitzhardinge
2010-09-14 17:49   ` Jeremy Fitzhardinge
2010-09-14 18:20   ` H. Peter Anvin
2010-09-14 18:20     ` H. Peter Anvin
2010-09-14 18:46     ` Jeremy Fitzhardinge
2010-09-14 18:46       ` Jeremy Fitzhardinge
2010-09-21 18:39 ` Jeremy Fitzhardinge
2010-09-21 18:39   ` Jeremy Fitzhardinge
2010-09-21 19:15   ` matt mooney [this message]
2010-09-21 19:15     ` matt mooney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100921191513.GA15107@haskell.muteddisk.com \
    --to=mfm@muteddisk.com \
    --cc=chrisw@sous-sol.org \
    --cc=hpa@zytor.com \
    --cc=ian.campbell@citrix.com \
    --cc=jeremy@goop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.