Re: [PATCH 1/4] x86: remove cast from void*

From: Jeremy Fitzhardinge <jeremy@goop.org>
To: matt mooney <mfm@muteddisk.com>
Cc: xen-devel@lists.xensource.com,
	Jeremy Fitzhardinge <jeremy@xensource.com>,
	x86@kernel.org, kernel-janitors@vger.kernel.org,
	Chris Wright <chrisw@sous-sol.org>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] x86: remove cast from void*
Date: Tue, 14 Sep 2010 17:49:55 +0000	[thread overview]
Message-ID: <4C8FB5C3.3050806@goop.org> (raw)
In-Reply-To: <1284441511-11511-1-git-send-email-mfm@muteddisk.com>

 On 09/13/2010 10:18 PM, matt mooney wrote:
> Unnecessary cast from void* in assignment.

Not very keen on this.  The cast may not be strictly required, but it
does document what's going on there.

    J

> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
>  arch/x86/xen/mmu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 42086ac..7436283 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
>  
>  	if (offset < pgd_index(USER_LIMIT)) {
>  		struct page *page = virt_to_page(pgd_page);
> -		user_ptr = (pgd_t *)page->private;
> +		user_ptr = page->private;
>  		if (user_ptr)
>  			user_ptr += offset;
>  	}