* [PATCH] usb: omap: ohci: Missing driver unregister in module exit
@ 2010-09-13 23:10 Keshava Munegowda
[not found] ` <1284419401-32101-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Keshava Munegowda @ 2010-09-13 23:10 UTC (permalink / raw)
To: linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA
Cc: gadiyar-l0cyMroinI0, nskamat-l0cyMroinI0, Keshava Munegowda
The un-registration of OHCI driver was not done in
the ohci_hcd_mod_exit function. This was affecting rmmod command not
to work for OMAP3 platforms.
The platform driver un-registration for OMAP3 platforms is perfomed
while removing the OHCI module from kernel.
Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
---
drivers/usb/host/ohci-hcd.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6/drivers/usb/host/ohci-hcd.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/ohci-hcd.c
+++ linux-2.6/drivers/usb/host/ohci-hcd.c
@@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi
#ifdef PLATFORM_DRIVER
platform_driver_unregister(&PLATFORM_DRIVER);
#endif
+#ifdef OMAP3_PLATFORM_DRIVER
+ platform_driver_unregister(&OMAP3_PLATFORM_DRIVER);
+#endif
#ifdef PS3_SYSTEM_BUS_DRIVER
ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER);
#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <1284419401-32101-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>]
* RE: [PATCH] usb: omap: ohci: Missing driver unregister in module exit [not found] ` <1284419401-32101-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org> @ 2010-09-16 11:39 ` Munegowda, Keshava 2010-09-17 6:43 ` Felipe Balbi 0 siblings, 1 reply; 4+ messages in thread From: Munegowda, Keshava @ 2010-09-16 11:39 UTC (permalink / raw) To: greg-U8xfFu+wG4EAvxtiuMwx3w, linux-usb-owner-u79uwXL29TY76Z2rM5mHXA Cc: Gadiyar, Anand, Kamat, Nishant, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA > -----Original Message----- > From: Munegowda, Keshava > Sent: Tuesday, September 14, 2010 4:40 AM > To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava > Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit > > The un-registration of OHCI driver was not done in > the ohci_hcd_mod_exit function. This was affecting rmmod command not > to work for OMAP3 platforms. > The platform driver un-registration for OMAP3 platforms is perfomed > while removing the OHCI module from kernel. > > Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> > --- > drivers/usb/host/ohci-hcd.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6/drivers/usb/host/ohci-hcd.c > =================================================================== > --- linux-2.6.orig/drivers/usb/host/ohci-hcd.c > +++ linux-2.6/drivers/usb/host/ohci-hcd.c > @@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi > #ifdef PLATFORM_DRIVER > platform_driver_unregister(&PLATFORM_DRIVER); > #endif > +#ifdef OMAP3_PLATFORM_DRIVER > + platform_driver_unregister(&OMAP3_PLATFORM_DRIVER); > +#endif > #ifdef PS3_SYSTEM_BUS_DRIVER > ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER); > #endif Hi Greg, Do you any comments on this patch? Keshava Munegowda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: omap: ohci: Missing driver unregister in module exit 2010-09-16 11:39 ` Munegowda, Keshava @ 2010-09-17 6:43 ` Felipe Balbi 2010-09-21 20:43 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Felipe Balbi @ 2010-09-17 6:43 UTC (permalink / raw) To: Munegowda, Keshava Cc: greg, linux-usb-owner, Gadiyar, Anand, Kamat, Nishant, linux-usb, linux-omap On Thu, Sep 16, 2010 at 06:39:20AM -0500, Munegowda, Keshava wrote: >> -----Original Message----- >> From: Munegowda, Keshava >> Sent: Tuesday, September 14, 2010 4:40 AM >> To: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org >> Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava >> Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit >> >> The un-registration of OHCI driver was not done in >> the ohci_hcd_mod_exit function. This was affecting rmmod command not >> to work for OMAP3 platforms. >> The platform driver un-registration for OMAP3 platforms is perfomed >> while removing the OHCI module from kernel. >> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >> --- >> drivers/usb/host/ohci-hcd.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> Index: linux-2.6/drivers/usb/host/ohci-hcd.c >> =================================================================== >> --- linux-2.6.orig/drivers/usb/host/ohci-hcd.c >> +++ linux-2.6/drivers/usb/host/ohci-hcd.c >> @@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi >> #ifdef PLATFORM_DRIVER >> platform_driver_unregister(&PLATFORM_DRIVER); >> #endif >> +#ifdef OMAP3_PLATFORM_DRIVER >> + platform_driver_unregister(&OMAP3_PLATFORM_DRIVER); >> +#endif >> #ifdef PS3_SYSTEM_BUS_DRIVER >> ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER); >> #endif > >Hi Greg, > Do you any comments on this patch? my missing S-O-B, maybe. Here it goes: Signed-of-by: Felipe Balbi <balbi@ti.com> -- balbi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: omap: ohci: Missing driver unregister in module exit 2010-09-17 6:43 ` Felipe Balbi @ 2010-09-21 20:43 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2010-09-21 20:43 UTC (permalink / raw) To: Felipe Balbi Cc: Munegowda, Keshava, linux-usb-owner, Gadiyar, Anand, Kamat, Nishant, linux-usb, linux-omap On Fri, Sep 17, 2010 at 09:43:16AM +0300, Felipe Balbi wrote: > On Thu, Sep 16, 2010 at 06:39:20AM -0500, Munegowda, Keshava wrote: > >>-----Original Message----- > >>From: Munegowda, Keshava > >>Sent: Tuesday, September 14, 2010 4:40 AM > >>To: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org > >>Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava > >>Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit > >> > >>The un-registration of OHCI driver was not done in > >>the ohci_hcd_mod_exit function. This was affecting rmmod command not > >>to work for OMAP3 platforms. > >>The platform driver un-registration for OMAP3 platforms is perfomed > >>while removing the OHCI module from kernel. > >> > >>Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > >>--- > >> drivers/usb/host/ohci-hcd.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >>Index: linux-2.6/drivers/usb/host/ohci-hcd.c > >>=================================================================== > >>--- linux-2.6.orig/drivers/usb/host/ohci-hcd.c > >>+++ linux-2.6/drivers/usb/host/ohci-hcd.c > >>@@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi > >> #ifdef PLATFORM_DRIVER > >> platform_driver_unregister(&PLATFORM_DRIVER); > >> #endif > >>+#ifdef OMAP3_PLATFORM_DRIVER > >>+ platform_driver_unregister(&OMAP3_PLATFORM_DRIVER); > >>+#endif > >> #ifdef PS3_SYSTEM_BUS_DRIVER > >> ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER); > >> #endif > > > >Hi Greg, > > Do you any comments on this patch? > > my missing S-O-B, maybe. Here it goes: > > Signed-of-by: Felipe Balbi <balbi@ti.com> Yup, all good now. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-21 20:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-13 23:10 [PATCH] usb: omap: ohci: Missing driver unregister in module exit Keshava Munegowda
[not found] ` <1284419401-32101-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2010-09-16 11:39 ` Munegowda, Keshava
2010-09-17 6:43 ` Felipe Balbi
2010-09-21 20:43 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.