All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted
Date: Fri, 29 Oct 2010 23:06:12 +0200	[thread overview]
Message-ID: <20101029210612.BB8D6152451@gemini.denx.de> (raw)
In-Reply-To: <1288267776-1148-1-git-send-email-sr@denx.de>

Dear Stefan Roese,

In message <1288267776-1148-1-git-send-email-sr@denx.de> you wrote:
> Only allow (re-)assignment to an UBI partition/device when UBIFS is
> currently not mounted. Otherwise the following UBIFS commands will
> crash.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  common/cmd_ubi.c   |   13 +++++++++++++
>  common/cmd_ubifs.c |    5 +++++
>  2 files changed, 18 insertions(+), 0 deletions(-)

I'm a bit biased here - from standard Unix command usage it seems
natural that you have to manually umount first, but then we have very
smple device handling in U-Boot, with always only one device in
access.  Would it not make sense to auto-unmount in case the user
switches the device?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_

  parent reply	other threads:[~2010-10-29 21:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-28 12:09 [U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted Stefan Roese
2010-10-29 14:01 ` Ben Gardiner
2010-10-29 21:06 ` Wolfgang Denk [this message]
2010-11-01 13:20   ` Stefan Roese
2010-11-01 19:06     ` Wolfgang Denk
2010-11-02  0:31       ` Gray Remlin
2010-11-02 10:49       ` Stefan Roese
2010-11-02 14:33         ` Ben Gardiner
2010-11-14 21:06         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101029210612.BB8D6152451@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.