[U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted

[Wolfgang Denk <wd@denx.de>]

Dear Stefan Roese,

In message <201011011420.35851.sr@denx.de> you wrote:
>
> > > Only allow (re-)assignment to an UBI partition/device when UBIFS is
> > > currently not mounted. Otherwise the following UBIFS commands will
> > > crash.
> > > 
> > > Signed-off-by: Stefan Roese <sr@denx.de>
> > > ---
> > > 
> > >  common/cmd_ubi.c   |   13 +++++++++++++
> > >  common/cmd_ubifs.c |    5 +++++
> > >  2 files changed, 18 insertions(+), 0 deletions(-)
> > 
> > I'm a bit biased here - from standard Unix command usage it seems
> > natural that you have to manually umount first, but then we have very
> > smple device handling in U-Boot, with always only one device in
> > access.  Would it not make sense to auto-unmount in case the user
> > switches the device?
> 
> I can implement it this way if preferred. I'll prepare a new for this later.

As mentioned - I am not sure what would be best here.

What is your own position?

And: anybody else to comment?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You might not be as stupid as you look. This is not hard. Let's think
about this. I mean ... I'll think about this, and  you  can  join  in
when you know the words.             - Terry Pratchett, _Men at Arms_