[U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted

[Stefan Roese <sr@denx.de>]

Hi Wolfgang,

On Monday 01 November 2010 20:06:31 Wolfgang Denk wrote:
> > > I'm a bit biased here - from standard Unix command usage it seems
> > > natural that you have to manually umount first, but then we have very
> > > smple device handling in U-Boot, with always only one device in
> > > access.  Would it not make sense to auto-unmount in case the user
> > > switches the device?
> > 
> > I can implement it this way if preferred. I'll prepare a new for this
> > later.
> 
> As mentioned - I am not sure what would be best here.
> 
> What is your own position?

I prefer the first approach, not automatically unmounting upon UBI device 
change. One plus for this version is that the user might have issued the 2nd 
"ubi part" by mistake and didn't really want to unmount the UBIFS filesystem 
in the first place.

But I have no strong feeling here. So I'm open to suggestions from others 
which version is the preferred one.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de