All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Adnan Khaleel" <adnan@khaleel.us>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Single 64bit memory transaction instead of two 32bit memory transaction.
Date: Mon, 08 Nov 2010 17:27:09 -0600	[thread overview]
Message-ID: <20101108232709.c98bf86f@shadowfax.no-ip.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

In the file exec.c:

The memory Write/Read functions are declared as an array of 4 entries where the index values of 0,1,2 correspond to 8,16 and 32bit write and read functions respectively.

CPUWriteMemoryFunc *io_mem_write[IO_MEM_NB_ENTRIES][4];
CPUReadMemoryFunc *io_mem_read[IO_MEM_NB_ENTRIES][4];

Is there any reason why we can't extend this to include 64bit writes and read by increasing the array size? This is because 64bit reads are currently handled as two separate 32bit reads for eg: sommu_template.h

static inline DATA_TYPE glue(io_read, SUFFIX)(target_phys_addr_t physaddr,
                                              target_ulong addr,
                                              void *retaddr)
{
:
    res = io_mem_read[index][2](io_mem_opaque[index], physaddr);
    res |= (uint64_t)io_mem_read[index][2](io_mem_opaque[index], physaddr + 4) << 32;
:
    return res;
}

I'm sure this is happening in other places as well. Is there a reason for this or could we arbitrarily increase this (within limits ofcourse)?

Thanks

AK

[-- Attachment #2: Type: text/html, Size: 1906 bytes --]

             reply	other threads:[~2010-11-08 23:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-08 23:27 Adnan Khaleel [this message]
2010-11-09 17:57 ` [Qemu-devel] Single 64bit memory transaction instead of two 32bit memory transaction Blue Swirl
2011-09-01 19:16 Adnan Khaleel
2011-09-03  1:53 ` Richard Henderson
2011-09-03 22:36 Adnan Khaleel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101108232709.c98bf86f@shadowfax.no-ip.com \
    --to=adnan@khaleel.us \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.