Re: [PATCH] Make swap accounting default behavior configurable

From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com,
	stable@kernel.org,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [PATCH] Make swap accounting default behavior configurable
Date: Wed, 17 Nov 2010 12:28:01 +0900	[thread overview]
Message-ID: <20101117122801.e9850acf.nishimura@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20101116171225.274019cf.akpm@linux-foundation.org>

On Tue, 16 Nov 2010 17:12:25 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 17 Nov 2010 09:23:39 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> 
> > > > 
> > > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > > > index ed45e98..14eafa5 100644
> > > > --- a/Documentation/kernel-parameters.txt
> > > > +++ b/Documentation/kernel-parameters.txt
> > > > @@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file
> > > >  			improve throughput, but will also increase the
> > > >  			amount of memory reserved for use by the client.
> > > >  
> > > > +	swapaccount	[KNL] Enable accounting of swap in memory resource
> > > > +			controller. (See Documentation/cgroups/memory.txt)
> > > 
> > > So we have swapaccount and noswapaccount.  Ho hum, "swapaccount=[1|0]"
> > > would have been better.
> > > 
> > I suggested to keep "noswapaccount" for compatibility.
> > If you and other guys don't like having two parameters, I don't stick to
> > the old parameter.
> > 
> 
> Yes, we're stuck with the old one now.
> 
> But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". 
> Even if we didn't initially intend to add "nofoo".
> 
I see.

Michal-san, could you update your patch to use "swapaccount=[1|0]" ?

Thanks,
Daisuke Nishimura.