From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> To: Michal Hocko <mhocko@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, stable@kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> Subject: Re: [PATCH] Make swap accounting default behavior configurable v4 Date: Thu, 18 Nov 2010 19:14:27 +0900 [thread overview] Message-ID: <20101118191427.fd86db5c.nishimura@mxp.nes.nec.co.jp> (raw) In-Reply-To: <20101118095607.GD15928@tiehlicka.suse.cz> On Thu, 18 Nov 2010 10:56:07 +0100 Michal Hocko <mhocko@suse.cz> wrote: > On Thu 18-11-10 17:53:34, KAMEZAWA Hiroyuki wrote: > > On Thu, 18 Nov 2010 17:46:54 +0900 > > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote: > > > > > On Thu, 18 Nov 2010 09:23:32 +0100 > > > Michal Hocko <mhocko@suse.cz> wrote: > > > > > > > On Wed 17-11-10 12:28:01, Daisuke Nishimura wrote: > > > > > On Tue, 16 Nov 2010 17:12:25 -0800 > > > > > Andrew Morton <akpm@linux-foundation.org> wrote: > [...] > > > > > > Yes, we're stuck with the old one now. > > > > > > > > > > > > But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". > > > > > > Even if we didn't initially intend to add "nofoo". > > > > > > > > > > > I see. > > > > > > > > > > Michal-san, could you update your patch to use "swapaccount=[1|0]" ? > > > > > > > > I have noticed that Andrew has already taken the last version of the > > > > patch for -mm tree. Should I still rework it to change swapaccount to > > > > swapaccount=0|1 resp. true|false? > > > > > > > It's usual to update a patch into more sophisticated one while it is in -mm tree. > > > So, I think you'd better to do it(btw, I prefer 0|1 to true|false. > > > Reading kernel-parameters.txt, 0|1 is more commonly used.). > > > > > > > I vote for 0|1 > > Changes since v3: > * add 0|1 parameter values handling > > Changes since v2: > * put the new parameter description to the proper (alphabetically > * sorted) > place in Documentation/kernel-parameters.txt > > Changes since v1: > * do not remove noswapaccount parameter and add swapaccount parameter > * instead > * Documentation/kernel-parameters.txt updated) > I'm sorry again and again, but I think removing "noswapaccount" completely would be better, as Andrew said first: > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]" > would have been better. Thanks, Daisuke Nishimura.
WARNING: multiple messages have this Message-ID (diff)
From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> To: Michal Hocko <mhocko@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, balbir@linux.vnet.ibm.com, stable@kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> Subject: Re: [PATCH] Make swap accounting default behavior configurable v4 Date: Thu, 18 Nov 2010 19:14:27 +0900 [thread overview] Message-ID: <20101118191427.fd86db5c.nishimura@mxp.nes.nec.co.jp> (raw) In-Reply-To: <20101118095607.GD15928@tiehlicka.suse.cz> On Thu, 18 Nov 2010 10:56:07 +0100 Michal Hocko <mhocko@suse.cz> wrote: > On Thu 18-11-10 17:53:34, KAMEZAWA Hiroyuki wrote: > > On Thu, 18 Nov 2010 17:46:54 +0900 > > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote: > > > > > On Thu, 18 Nov 2010 09:23:32 +0100 > > > Michal Hocko <mhocko@suse.cz> wrote: > > > > > > > On Wed 17-11-10 12:28:01, Daisuke Nishimura wrote: > > > > > On Tue, 16 Nov 2010 17:12:25 -0800 > > > > > Andrew Morton <akpm@linux-foundation.org> wrote: > [...] > > > > > > Yes, we're stuck with the old one now. > > > > > > > > > > > > But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". > > > > > > Even if we didn't initially intend to add "nofoo". > > > > > > > > > > > I see. > > > > > > > > > > Michal-san, could you update your patch to use "swapaccount=[1|0]" ? > > > > > > > > I have noticed that Andrew has already taken the last version of the > > > > patch for -mm tree. Should I still rework it to change swapaccount to > > > > swapaccount=0|1 resp. true|false? > > > > > > > It's usual to update a patch into more sophisticated one while it is in -mm tree. > > > So, I think you'd better to do it(btw, I prefer 0|1 to true|false. > > > Reading kernel-parameters.txt, 0|1 is more commonly used.). > > > > > > > I vote for 0|1 > > Changes since v3: > * add 0|1 parameter values handling > > Changes since v2: > * put the new parameter description to the proper (alphabetically > * sorted) > place in Documentation/kernel-parameters.txt > > Changes since v1: > * do not remove noswapaccount parameter and add swapaccount parameter > * instead > * Documentation/kernel-parameters.txt updated) > I'm sorry again and again, but I think removing "noswapaccount" completely would be better, as Andrew said first: > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]" > would have been better. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-18 10:16 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-16 10:17 [PATCH] Make swap accounting default behavior configurable Michal Hocko 2010-11-16 10:17 ` Michal Hocko 2010-11-16 20:46 ` Andrew Morton 2010-11-16 20:46 ` Andrew Morton 2010-11-16 21:21 ` [stable] " Greg KH 2010-11-16 21:21 ` Greg KH 2010-11-18 8:21 ` Michal Hocko 2010-11-18 8:21 ` Michal Hocko 2010-11-18 16:36 ` Greg KH 2010-11-18 16:36 ` Greg KH 2010-11-17 0:23 ` Daisuke Nishimura 2010-11-17 0:23 ` Daisuke Nishimura 2010-11-17 0:57 ` KAMEZAWA Hiroyuki 2010-11-17 0:57 ` KAMEZAWA Hiroyuki 2010-11-17 1:12 ` Andrew Morton 2010-11-17 1:12 ` Andrew Morton 2010-11-17 3:28 ` Daisuke Nishimura 2010-11-17 3:28 ` Daisuke Nishimura 2010-11-18 8:23 ` Michal Hocko 2010-11-18 8:23 ` Michal Hocko 2010-11-18 8:46 ` Daisuke Nishimura 2010-11-18 8:46 ` Daisuke Nishimura 2010-11-18 8:53 ` KAMEZAWA Hiroyuki 2010-11-18 8:53 ` KAMEZAWA Hiroyuki 2010-11-18 9:56 ` [PATCH] Make swap accounting default behavior configurable v4 Michal Hocko 2010-11-18 9:56 ` Michal Hocko 2010-11-18 10:14 ` Daisuke Nishimura [this message] 2010-11-18 10:14 ` Daisuke Nishimura 2010-11-18 10:23 ` Michal Hocko 2010-11-18 10:23 ` Michal Hocko 2010-11-18 17:52 ` Andrew Morton 2010-11-18 17:52 ` Andrew Morton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101118191427.fd86db5c.nishimura@mxp.nes.nec.co.jp \ --to=nishimura@mxp.nes.nec.co.jp \ --cc=akpm@linux-foundation.org \ --cc=balbir@linux.vnet.ibm.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.cz \ --cc=stable@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.