All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] (no subject)
@ 2010-11-28 20:14 Wolfgang Denk
  2010-12-01  6:38 ` Minkyu Kang
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2010-11-28 20:14 UTC (permalink / raw)
  To: u-boot

Dear Kyungmin Park & Minkyu Kang,

"onenand_ipl/board/apollon/config.mk" and
"onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE;
do you think it is possible to move these definitions into the
respective board config files and remove the then empty "config.mk"
files?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the hours are long enough and the pay  is  short  enough,  someone
will say it's women's work.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] (no subject)
  2010-11-28 20:14 [U-Boot] (no subject) Wolfgang Denk
@ 2010-12-01  6:38 ` Minkyu Kang
  2010-12-01  8:03   ` [U-Boot] onenand_ipl config.mk cleanup (was: no subject) Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Minkyu Kang @ 2010-12-01  6:38 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang,

On 29 November 2010 05:14, Wolfgang Denk <wd@denx.de> wrote:
> Dear Kyungmin Park & Minkyu Kang,
>
> "onenand_ipl/board/apollon/config.mk" and
> "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE;
> do you think it is possible to move these definitions into the
> respective board config files and remove the then empty "config.mk"
> files?
>

It is hard to move into board config file, because of usually use
different TEXT_BASE on IPL.
I think, it can be moved into Makefile directly.
Then we can remove config.mk.
How you think?

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] onenand_ipl config.mk cleanup (was: no subject)
  2010-12-01  6:38 ` Minkyu Kang
@ 2010-12-01  8:03   ` Wolfgang Denk
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-12-01  8:03 UTC (permalink / raw)
  To: u-boot

Dear Minkyu Kang,

In message <AANLkTik64Heh+ooov9K10pixh9h=GdxqRQYyS8Er-c-1@mail.gmail.com> you wrote:
> 
> > "onenand_ipl/board/apollon/config.mk" and
> > "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE;
> > do you think it is possible to move these definitions into the
> > respective board config files and remove the then empty "config.mk"
> > files?
> >
> 
> It is hard to move into board config file, because of usually use
> different TEXT_BASE on IPL.

Well, we can probably use #ifdef's, like we do for boards that boot
from NAND flash, which have essentially the same situation.

> I think, it can be moved into Makefile directly.

No, that's not a good idea. Makefiles should not contain configuration
data. I want to move as much of this as possible into the board config
files, so we have it all in a single place.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A failure will not appear until a unit has passed final inspection.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-01  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-28 20:14 [U-Boot] (no subject) Wolfgang Denk
2010-12-01  6:38 ` Minkyu Kang
2010-12-01  8:03   ` [U-Boot] onenand_ipl config.mk cleanup (was: no subject) Wolfgang Denk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.