All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Dirk Eibach <eibach@gdsys.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"khali@linux-fr.org" <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH v2] hwmon: Consider LM64 temperature offset
Date: Wed, 9 Feb 2011 10:17:02 -0800	[thread overview]
Message-ID: <20110209181702.GA19998@ericsson.com> (raw)
In-Reply-To: <1297245094-13681-1-git-send-email-eibach@gdsys.de>

Hi Dirk,

On Wed, Feb 09, 2011 at 04:51:34AM -0500, Dirk Eibach wrote:
[ ... ]
> +/* temp2_crit can only be set once which should be job of the bootloader */
> +static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_remote_temp8,
> +	NULL, 2);

That only applies to lm63, though. It can be rewritten anytime on LM64.
That would be a separate patch, though, to not mix improvements with bug fixes.

Otherwise, looks good, so I'll apply it with an added remark that the restriction
only applies to lm63.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Dirk Eibach <eibach@gdsys.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"khali@linux-fr.org" <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon: Consider LM64 temperature offset
Date: Wed, 09 Feb 2011 18:17:02 +0000	[thread overview]
Message-ID: <20110209181702.GA19998@ericsson.com> (raw)
In-Reply-To: <1297245094-13681-1-git-send-email-eibach@gdsys.de>

Hi Dirk,

On Wed, Feb 09, 2011 at 04:51:34AM -0500, Dirk Eibach wrote:
[ ... ]
> +/* temp2_crit can only be set once which should be job of the bootloader */
> +static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_remote_temp8,
> +	NULL, 2);

That only applies to lm63, though. It can be rewritten anytime on LM64.
That would be a separate patch, though, to not mix improvements with bug fixes.

Otherwise, looks good, so I'll apply it with an added remark that the restriction
only applies to lm63.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-02-09 18:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 13:16 [PATCH] hwmon: Consider LM64 temperature offset Dirk Eibach
2011-02-08 13:16 ` [lm-sensors] " Dirk Eibach
2011-02-08 15:28 ` Guenter Roeck
2011-02-08 15:28   ` [lm-sensors] " Guenter Roeck
2011-02-08 15:54   ` Eibach, Dirk
2011-02-08 15:54     ` [lm-sensors] " Eibach, Dirk
2011-02-08 16:07     ` Guenter Roeck
2011-02-08 16:07       ` [lm-sensors] " Guenter Roeck
2011-02-08 16:09     ` Jean Delvare
2011-02-08 16:09       ` [lm-sensors] " Jean Delvare
2011-02-09  9:51   ` [PATCH v2] " Dirk Eibach
2011-02-09  9:51     ` [lm-sensors] " Dirk Eibach
2011-02-09 18:17     ` Guenter Roeck [this message]
2011-02-09 18:17       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209181702.GA19998@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=eibach@gdsys.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.