All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	George <george0505@realtek.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Tue, 22 Feb 2011 18:15:19 +1100	[thread overview]
Message-ID: <20110222181519.7a020eb3.sfr@canb.auug.org.au> (raw)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_init_sw_vars':
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: error: implicit declaration of function 'vmalloc'
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:60: warning: assignment makes pointer from integer without a cast
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c: In function 'rtl92cu_deinit_sw_vars':
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c:74: error: implicit declaration of function 'vfree'

Caused by commit 442888c706e90634c4cc3441751b43115a7d8506 ("rtlwifi:
rtl8192cu: Add routines dm, fw, led and sw").  Missing an include of
linux/vmalloc.h.  See Rule 1 in Documentation/SubmitChecklist.

I added the following patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 22 Feb 2011 17:29:04 +1100
Subject: [PATCH] rtlwifi: include vmalloc.h for needed routines

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/sw.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index 4e937e0..c69861e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -27,6 +27,8 @@
  *
  *****************************************************************************/
 
+#include <linux/vmalloc.h>
+
 #include "../wifi.h"
 #include "../core.h"
 #include "../usb.h"
-- 
1.7.4.1

but then got:

drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_phy_sw_chnl':
(.opd+0xf30): multiple definition of `rtl92c_phy_sw_chnl'
drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0xb70): first defined here
drivers/net/wireless/rtlwifi/rtl8192cu/built-in.o: In function `rtl92c_fill_h2c_cmd':
(.opd+0x288): multiple definition of `rtl92c_fill_h2c_cmd'
drivers/net/wireless/rtlwifi/rtl8192ce/built-in.o:(.opd+0x288): first defined here

and lots more.

So I have used the wireless tree from next-20110221 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2011-02-22  7:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  7:15 Stephen Rothwell [this message]
2011-02-22 15:45 ` linux-next: build failure after merge of the final tree (wireless tree related) Larry Finger
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22  5:58 Stephen Rothwell
2011-12-22  8:38 ` Kalle Valo
2011-12-22  8:38   ` Kalle Valo
2011-12-22 16:57 ` Michal Marek
2011-12-23 20:50   ` Michal Marek
2011-12-24  1:29     ` Kalle Valo
2011-12-24  1:29       ` Kalle Valo
2011-12-24  1:26   ` Kalle Valo
2011-12-24  1:26     ` Kalle Valo
2011-08-10  2:21 Stephen Rothwell
2011-08-10  6:11 ` Kalle Valo
2011-08-10  6:11   ` Kalle Valo
2011-05-12  4:10 Stephen Rothwell
2011-05-12  4:37 ` Javier Cardona
2011-05-12  4:56   ` Stephen Rothwell
2011-05-12 17:22     ` Javier Cardona
2011-05-12 23:01       ` Stephen Rothwell
2011-02-25  6:16 Stephen Rothwell
2011-02-25 20:33 ` wwguy
2011-02-24  6:24 Stephen Rothwell
2011-01-05  4:10 Stephen Rothwell
2010-12-16  3:29 Stephen Rothwell
2010-12-16  4:49 ` Larry Finger
2010-12-07  3:12 Stephen Rothwell
2010-11-17  2:48 Stephen Rothwell
2010-11-17 16:03 ` Randy Dunlap
2010-11-18  2:27   ` Stephen Rothwell
2010-11-18 21:09     ` Gustavo F. Padovan
2010-10-12  5:35 Stephen Rothwell
2010-03-24  4:59 Stephen Rothwell
2010-03-24  8:13 ` Sujith
2010-03-24  8:13   ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110222181519.7a020eb3.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=Larry.Finger@lwfinger.net \
    --cc=george0505@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.