All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	"John W. Linville" <linville@tuxdriver.com>,
	<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Sat, 24 Dec 2011 03:26:12 +0200	[thread overview]
Message-ID: <4EF52A34.70409@qca.qualcomm.com> (raw)
In-Reply-To: <4EF3616D.5050506@suse.cz>

On 12/22/2011 06:57 PM, Michal Marek wrote:
> Dne 22.12.2011 06:58, Stephen Rothwell napsal(a):
>> Hi ,
>>
>> After merging the final tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME'
>> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function)
> [...]
>>
>> I can't figure out what goes wrong here.  On the compile command line,
>> KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is.
> 
> scripts/Makefile.lib says
> # Note: It's possible that one object gets potentially linked into more
> #       than one module. In that case KBUILD_MODNAME will be set to foo_bar,
> #       where foo and bar are the name of the modules.
> 
> but reality does not match this comment:
> modname_flags  = $(if $(filter 1,$(words $(modname))),\
>                  -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))")
> 
> But I wonder why you need to link all the object files twice?

No particular reason. I just didn't know that it's not allowed.

> Usually, drivers have a foo_common.ko and foo_{usb,pci,whatever}.ko
that provide
> the pci/usb/whatever driver.

I have been planning to do the same for ath6kl. I just need to do a bit
of interface cleanup before I can cleanly separate the core module. I'll
start looking at that next.

Kalle

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Sat, 24 Dec 2011 03:26:12 +0200	[thread overview]
Message-ID: <4EF52A34.70409@qca.qualcomm.com> (raw)
In-Reply-To: <4EF3616D.5050506@suse.cz>

On 12/22/2011 06:57 PM, Michal Marek wrote:
> Dne 22.12.2011 06:58, Stephen Rothwell napsal(a):
>> Hi ,
>>
>> After merging the final tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME'
>> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function)
> [...]
>>
>> I can't figure out what goes wrong here.  On the compile command line,
>> KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is.
> 
> scripts/Makefile.lib says
> # Note: It's possible that one object gets potentially linked into more
> #       than one module. In that case KBUILD_MODNAME will be set to foo_bar,
> #       where foo and bar are the name of the modules.
> 
> but reality does not match this comment:
> modname_flags  = $(if $(filter 1,$(words $(modname))),\
>                  -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))")
> 
> But I wonder why you need to link all the object files twice?

No particular reason. I just didn't know that it's not allowed.

> Usually, drivers have a foo_common.ko and foo_{usb,pci,whatever}.ko
that provide
> the pci/usb/whatever driver.

I have been planning to do the same for ath6kl. I just need to do a bit
of interface cleanup before I can cleanly separate the core module. I'll
start looking at that next.

Kalle

  parent reply	other threads:[~2011-12-24  1:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22  5:58 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2011-12-22  8:38 ` Kalle Valo
2011-12-22  8:38   ` Kalle Valo
2011-12-22 16:57 ` Michal Marek
2011-12-23 20:50   ` Michal Marek
2011-12-24  1:29     ` Kalle Valo
2011-12-24  1:29       ` Kalle Valo
2011-12-24  1:26   ` Kalle Valo [this message]
2011-12-24  1:26     ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2011-08-10  2:21 Stephen Rothwell
2011-08-10  6:11 ` Kalle Valo
2011-08-10  6:11   ` Kalle Valo
2011-05-12  4:10 Stephen Rothwell
2011-05-12  4:37 ` Javier Cardona
2011-05-12  4:56   ` Stephen Rothwell
2011-05-12 17:22     ` Javier Cardona
2011-05-12 23:01       ` Stephen Rothwell
2011-02-25  6:16 Stephen Rothwell
2011-02-25 20:33 ` wwguy
2011-02-24  6:24 Stephen Rothwell
2011-02-22  7:15 Stephen Rothwell
2011-02-22 15:45 ` Larry Finger
2011-01-05  4:10 Stephen Rothwell
2010-12-16  3:29 Stephen Rothwell
2010-12-16  4:49 ` Larry Finger
2010-12-07  3:12 Stephen Rothwell
2010-11-17  2:48 Stephen Rothwell
2010-11-17 16:03 ` Randy Dunlap
2010-11-18  2:27   ` Stephen Rothwell
2010-11-18 21:09     ` Gustavo F. Padovan
2010-10-12  5:35 Stephen Rothwell
2010-03-24  4:59 Stephen Rothwell
2010-03-24  8:13 ` Sujith
2010-03-24  8:13   ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF52A34.70409@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mmarek@suse.cz \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.