All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
	Raja Mani <rmani@qca.qualcomm.com>,
	Vivek Natarajan <nataraja@qca.qualcomm.com>,
	Suraj Sumangala <surajs@qca.qualcomm.com>,
	Joe Perches <joe@perches.com>,
	Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Wed, 10 Aug 2011 09:11:26 +0300	[thread overview]
Message-ID: <4E42210E.70202@qca.qualcomm.com> (raw)
In-Reply-To: <20110810122109.a81b3186e4131aba82a4cae0@canb.auug.org.au>

Hi Stephen,

On 08/10/2011 05:21 AM, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_start':
> (.opd+0x600): multiple definition of `htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e40): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_stop':
> (.text+0x7b40): multiple definition of `.htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67b34): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_start':
> (.text+0x7d18): multiple definition of `.htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67ba0): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_stop':
> (.opd+0x5e8): multiple definition of `htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e28): first defined here
> 
> Probably caused by commit bdcd81707973 ("Add ath6kl cleaned up driver").
> 
> I have reverted commit 392e741939dd ("Merge branch 'ath6kl-next' of
> master.kernel.org:/pub/scm/linux/kernel/git/kvalo/ath6kl") for today.

Sorry about that! I'll send a fix right away.

> John, this has happened a couple of times before where people have just
> copied an existing driver that happens to have some badly named global
> variables.  :-(

I was working on adding ath6kl prefix too all global ath6kl symbols but
I haven't been able to finish that yet.

Kalle

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
	Raja Mani <rmani@qca.qualcomm.com>,
	Vivek Natarajan <nataraja@qca.qualcomm.com>,
	Suraj Sumangala <surajs@qca.qualcomm.com>,
	Joe Perches <joe@perches.com>,
	Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Wed, 10 Aug 2011 09:11:26 +0300	[thread overview]
Message-ID: <4E42210E.70202@qca.qualcomm.com> (raw)
In-Reply-To: <20110810122109.a81b3186e4131aba82a4cae0@canb.auug.org.au>

Hi Stephen,

On 08/10/2011 05:21 AM, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_start':
> (.opd+0x600): multiple definition of `htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e40): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_stop':
> (.text+0x7b40): multiple definition of `.htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67b34): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_start':
> (.text+0x7d18): multiple definition of `.htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67ba0): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_stop':
> (.opd+0x5e8): multiple definition of `htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e28): first defined here
> 
> Probably caused by commit bdcd81707973 ("Add ath6kl cleaned up driver").
> 
> I have reverted commit 392e741939dd ("Merge branch 'ath6kl-next' of
> master.kernel.org:/pub/scm/linux/kernel/git/kvalo/ath6kl") for today.

Sorry about that! I'll send a fix right away.

> John, this has happened a couple of times before where people have just
> copied an existing driver that happens to have some badly named global
> variables.  :-(

I was working on adding ath6kl prefix too all global ath6kl symbols but
I haven't been able to finish that yet.

Kalle

  reply	other threads:[~2011-08-10  6:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  2:21 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2011-08-10  6:11 ` Kalle Valo [this message]
2011-08-10  6:11   ` Kalle Valo
2011-08-10  7:11 ` [PATCH] ath6kl: fix function name conflicts with ath9k Kalle Valo
2011-08-10  7:11   ` Kalle Valo
2011-08-10  7:24   ` Kalle Valo
2011-08-10  7:24     ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22  5:58 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2011-12-22  8:38 ` Kalle Valo
2011-12-22  8:38   ` Kalle Valo
2011-12-22 16:57 ` Michal Marek
2011-12-23 20:50   ` Michal Marek
2011-12-24  1:29     ` Kalle Valo
2011-12-24  1:29       ` Kalle Valo
2011-12-24  1:26   ` Kalle Valo
2011-12-24  1:26     ` Kalle Valo
2011-05-12  4:10 Stephen Rothwell
2011-05-12  4:37 ` Javier Cardona
2011-05-12  4:56   ` Stephen Rothwell
2011-05-12 17:22     ` Javier Cardona
2011-05-12 23:01       ` Stephen Rothwell
2011-02-25  6:16 Stephen Rothwell
2011-02-25 20:33 ` wwguy
2011-02-24  6:24 Stephen Rothwell
2011-02-22  7:15 Stephen Rothwell
2011-02-22 15:45 ` Larry Finger
2011-01-05  4:10 Stephen Rothwell
2010-12-16  3:29 Stephen Rothwell
2010-12-16  4:49 ` Larry Finger
2010-12-07  3:12 Stephen Rothwell
2010-11-17  2:48 Stephen Rothwell
2010-11-17 16:03 ` Randy Dunlap
2010-11-18  2:27   ` Stephen Rothwell
2010-11-18 21:09     ` Gustavo F. Padovan
2010-10-12  5:35 Stephen Rothwell
2010-03-24  4:59 Stephen Rothwell
2010-03-24  8:13 ` Sujith
2010-03-24  8:13   ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E42210E.70202@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=joe@perches.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nataraja@qca.qualcomm.com \
    --cc=rmani@qca.qualcomm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=surajs@qca.qualcomm.com \
    --cc=vthiagar@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.