All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Kushwaha Prabhakar-B32579
	<B32579-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Meador Inge <meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
	"openmcapi-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<openmcapi-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	Hollis Blanchard
	<hollis_blanchard-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
	"linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH 2/2] powerpc: add support for MPIC message register API
Date: Fri, 29 Apr 2011 12:30:51 -0500	[thread overview]
Message-ID: <20110429123051.4ed1ca01@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <071A08F2C6A57E4E94D980ECA553F8741967EC-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>

On Fri, 29 Apr 2011 17:27:06 +0000
Kushwaha Prabhakar-B32579 <B32579-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:

> 
> 
> > > Hi,
> > >
> > > I have no comments about coding and architecture. It looks fine.
> > >
> > > Only have a query about its use case..
> > >    "Any application intended to use message interrupt requires to know
> > reg_num because of struct mpic_msgr* mpic_msgr_get(unsigned int reg_num)
> > API"
> > >
> > > It will be good to search available unit internally and provide its
> > pointer. It will make application more flexible.
> > >
> > 
> > The problem is that you fundamentally cannot implement an allocator for
> > MSG registers if you're going to communicate with another kernel (how
> > would both kernels' allocators be synchronized?). So the message register
> > allocation must be decided at design time, not run time.
> > 
> 
> I agree with you..  It is true while communicating with another kernel.
> But message interrupts can be used by different independent drivers within same kernel. For eg. PCIe and Ethernet driver. 
> As per current design both drivers needs to be in sync before requesting any message unit for avoiding any conflict. As these drivers are completely independent. It is very difficult. 
> 
> Can it be possible to provide new API to take care it.

Do you have a real use case in mind where these message registers (not
MSIs) are used internally in this manner?

Perhaps an allocator could be added in the same patchset that adds such a
user.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Kushwaha Prabhakar-B32579 <B32579@freescale.com>
Cc: Meador Inge <meador_inge@mentor.com>,
	"openmcapi-dev@googlegroups.com" <openmcapi-dev@googlegroups.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Hollis Blanchard <hollis_blanchard@mentor.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] powerpc: add support for MPIC message register API
Date: Fri, 29 Apr 2011 12:30:51 -0500	[thread overview]
Message-ID: <20110429123051.4ed1ca01@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <071A08F2C6A57E4E94D980ECA553F8741967EC@039-SN1MPN1-004.039d.mgd.msft.net>

On Fri, 29 Apr 2011 17:27:06 +0000
Kushwaha Prabhakar-B32579 <B32579@freescale.com> wrote:

> 
> 
> > > Hi,
> > >
> > > I have no comments about coding and architecture. It looks fine.
> > >
> > > Only have a query about its use case..
> > >    "Any application intended to use message interrupt requires to know
> > reg_num because of struct mpic_msgr* mpic_msgr_get(unsigned int reg_num)
> > API"
> > >
> > > It will be good to search available unit internally and provide its
> > pointer. It will make application more flexible.
> > >
> > 
> > The problem is that you fundamentally cannot implement an allocator for
> > MSG registers if you're going to communicate with another kernel (how
> > would both kernels' allocators be synchronized?). So the message register
> > allocation must be decided at design time, not run time.
> > 
> 
> I agree with you..  It is true while communicating with another kernel.
> But message interrupts can be used by different independent drivers within same kernel. For eg. PCIe and Ethernet driver. 
> As per current design both drivers needs to be in sync before requesting any message unit for avoiding any conflict. As these drivers are completely independent. It is very difficult. 
> 
> Can it be possible to provide new API to take care it.

Do you have a real use case in mind where these message registers (not
MSIs) are used internally in this manner?

Perhaps an allocator could be added in the same patchset that adds such a
user.

-Scott

  parent reply	other threads:[~2011-04-29 17:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 16:59 [PATCH 0/2] powerpc: define and implement MPIC message register support Meador Inge
2011-04-19 16:59 ` Meador Inge
     [not found] ` <1303232375-25014-1-git-send-email-meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2011-04-19 16:59   ` [PATCH 1/2] powerpc: document the FSL MPIC message register binding Meador Inge
2011-04-19 16:59     ` Meador Inge
     [not found]     ` <1303232375-25014-2-git-send-email-meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2011-04-19 17:52       ` Scott Wood
2011-04-19 17:52         ` Scott Wood
2011-04-19 18:26         ` Meador Inge
2011-04-19 18:33           ` Scott Wood
     [not found]             ` <20110419133336.46d8566f-1MYqz8GpK7RekFaExTCHk1jVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2011-04-21 19:26               ` Meador Inge
2011-04-21 19:26                 ` Meador Inge
     [not found]                 ` <4DB084F6.4060103-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2011-04-21 19:35                   ` Scott Wood
2011-04-21 19:35                     ` Scott Wood
2011-04-19 16:59   ` [PATCH 2/2] powerpc: add support for MPIC message register API Meador Inge
2011-04-19 16:59     ` Meador Inge
     [not found]     ` <1303232375-25014-3-git-send-email-meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2011-04-29  5:00       ` Kushwaha Prabhakar-B32579
2011-04-29  5:00         ` Kushwaha Prabhakar-B32579
2011-04-29 16:54         ` Hollis Blanchard
2011-04-29 17:27           ` Kushwaha Prabhakar-B32579
2011-04-29 17:27             ` Kushwaha Prabhakar-B32579
     [not found]             ` <071A08F2C6A57E4E94D980ECA553F8741967EC-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-04-29 17:30               ` Scott Wood [this message]
2011-04-29 17:30                 ` Scott Wood
     [not found]                 ` <20110429123051.4ed1ca01-1MYqz8GpK7RekFaExTCHk1jVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2011-05-02  3:41                   ` Kushwaha Prabhakar-B32579
2011-05-02  3:41                     ` Kushwaha Prabhakar-B32579
2011-05-02 16:03                     ` Hollis Blanchard
     [not found]                       ` <4DBED5E9.2070201-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2011-05-03 15:19                         ` Scott Wood
2011-05-03 15:19                           ` Scott Wood
2011-05-05 21:41                           ` Meador Inge
2011-05-06 19:29                             ` Scott Wood
     [not found]                               ` <20110506142937.77e7a10f-1MYqz8GpK7RekFaExTCHk1jVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2011-05-06 23:51                                 ` Meador Inge
2011-05-06 23:51                                   ` Meador Inge
2012-02-17  2:49 [PATCH 1/2] powerpc: document the FSL MPIC message register binding Jia Hongtao
2012-02-17  2:49 ` [PATCH 2/2] powerpc: add support for MPIC message register API Jia Hongtao
2012-03-21 17:21   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429123051.4ed1ca01@schlenkerla.am.freescale.net \
    --to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=B32579-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=hollis_blanchard-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
    --cc=openmcapi-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.