From: Arnd Bergmann <arnd@arndb.de> To: "Subhasish Ghosh" <subhasish@mistralsolutions.com> Cc: linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, sachi@mistralsolutions.com, "Samuel Ortiz" <sameo@linux.intel.com>, nsekhar@ti.com, "open list" <linux-kernel@vger.kernel.org>, m-watkins@ti.com Subject: Re: [PATCH v4 01/11] mfd: add pruss mfd driver. Date: Wed, 4 May 2011 15:44:19 +0200 [thread overview] Message-ID: <201105041544.19726.arnd@arndb.de> (raw) In-Reply-To: <2543A75FDDB244D2A148C14BCAA5FD88@subhasishg> On Wednesday 04 May 2011, Subhasish Ghosh wrote: > How about just doing something like: > > #> echo da8xx_pruss_uart >> firmware.bin > > i.e just append the device name (from the board file) into the firmware > file. That sounds fine to me. I would put a header in the beginning, but feel free to use whatever format you find useful there. > In the driver probe, we can parse from the bottom, when it reaches > "da8xx_pruss", the rest of the upper data is the firmware and from > the full name, we can determine if it's a CAN, UART or any other > peripheral. > > So, based on the platform_data, which the MFD driver received, > it can find out which device to initialize. In my opinion, the MFD driver should not know the possible values at all, or look at platform_data for the children, but take all that information from the firmware file. The only thing that the MFD driver needs to know is how many PRUs there are and how they are connected to the host bus (memory regions, irqs, clocks, ...). It can then load firmware files, either one for the entire MFD or one per PRU core (whatever works best for you) and create child devices with the information it finds in there about what code to load into each PRU and what drivers to load for them. When you prepend the "da8xx_pruss_" string to the name you find in the firmware file, the pruss driver can be sure that it does not accidentally load a different module, e.g. when a malicious user was able to exchange the firmware file. > Also, does the line wrapping look any better ? Looks good now, yes. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 01/11] mfd: add pruss mfd driver. Date: Wed, 4 May 2011 15:44:19 +0200 [thread overview] Message-ID: <201105041544.19726.arnd@arndb.de> (raw) In-Reply-To: <2543A75FDDB244D2A148C14BCAA5FD88@subhasishg> On Wednesday 04 May 2011, Subhasish Ghosh wrote: > How about just doing something like: > > #> echo da8xx_pruss_uart >> firmware.bin > > i.e just append the device name (from the board file) into the firmware > file. That sounds fine to me. I would put a header in the beginning, but feel free to use whatever format you find useful there. > In the driver probe, we can parse from the bottom, when it reaches > "da8xx_pruss", the rest of the upper data is the firmware and from > the full name, we can determine if it's a CAN, UART or any other > peripheral. > > So, based on the platform_data, which the MFD driver received, > it can find out which device to initialize. In my opinion, the MFD driver should not know the possible values at all, or look at platform_data for the children, but take all that information from the firmware file. The only thing that the MFD driver needs to know is how many PRUs there are and how they are connected to the host bus (memory regions, irqs, clocks, ...). It can then load firmware files, either one for the entire MFD or one per PRU core (whatever works best for you) and create child devices with the information it finds in there about what code to load into each PRU and what drivers to load for them. When you prepend the "da8xx_pruss_" string to the name you find in the firmware file, the pruss driver can be sure that it does not accidentally load a different module, e.g. when a malicious user was able to exchange the firmware file. > Also, does the line wrapping look any better ? Looks good now, yes. Arnd
next prev parent reply other threads:[~2011-05-04 13:44 UTC|newest] Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-22 12:08 [PATCH v4 00/11] pruss mfd drivers Subhasish Ghosh 2011-04-22 11:50 ` [PATCH v4 08/11] tty: add pruss SUART driver Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-25 21:20 ` Greg KH 2011-04-25 21:20 ` Greg KH 2011-04-26 6:51 ` Nori, Sekhar 2011-04-26 6:51 ` Nori, Sekhar 2011-04-26 12:45 ` Greg KH 2011-04-26 12:45 ` Greg KH 2011-04-27 5:23 ` Subhasish Ghosh 2011-04-27 5:23 ` Subhasish Ghosh 2011-04-27 11:19 ` Nori, Sekhar 2011-04-27 11:19 ` Nori, Sekhar 2011-04-27 13:15 ` Subhasish Ghosh 2011-04-27 13:15 ` Subhasish Ghosh 2011-04-27 17:50 ` Nori, Sekhar 2011-04-27 17:50 ` Nori, Sekhar 2011-05-02 8:34 ` Subhasish Ghosh 2011-05-02 8:34 ` Subhasish Ghosh 2011-05-02 17:15 ` Nori, Sekhar 2011-05-02 17:15 ` Nori, Sekhar 2011-05-10 10:54 ` Subhasish Ghosh 2011-05-10 10:54 ` Subhasish Ghosh 2011-05-10 13:13 ` Nori, Sekhar 2011-05-10 13:13 ` Nori, Sekhar 2011-05-13 12:10 ` Subhasish Ghosh 2011-05-13 12:10 ` Subhasish Ghosh 2011-05-09 13:39 ` Subhasish Ghosh 2011-05-09 13:39 ` Subhasish Ghosh 2011-05-09 13:46 ` Alan Cox 2011-05-09 13:46 ` Alan Cox 2011-05-09 13:50 ` Subhasish Ghosh 2011-05-09 13:50 ` Subhasish Ghosh 2011-05-09 13:55 ` Alan Cox 2011-05-09 13:55 ` Alan Cox 2011-05-10 6:17 ` Subhasish Ghosh 2011-05-10 6:17 ` Subhasish Ghosh 2011-05-10 13:32 ` Alan Cox 2011-05-10 13:32 ` Alan Cox 2011-05-11 7:01 ` Subhasish Ghosh 2011-05-11 7:01 ` Subhasish Ghosh 2011-05-11 10:35 ` Alan Cox 2011-05-11 10:35 ` Alan Cox 2011-04-22 12:08 ` [PATCH v4 01/11] mfd: add pruss mfd driver Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 16:00 ` Marc Kleine-Budde 2011-04-22 16:00 ` Marc Kleine-Budde 2011-04-27 6:39 ` Subhasish Ghosh 2011-04-27 6:39 ` Subhasish Ghosh 2011-04-27 7:29 ` Marc Kleine-Budde 2011-04-27 7:29 ` Marc Kleine-Budde 2011-04-27 9:12 ` Russell King - ARM Linux 2011-04-27 9:12 ` Russell King - ARM Linux 2011-04-27 13:18 ` Subhasish Ghosh 2011-04-27 13:18 ` Subhasish Ghosh 2011-04-27 13:35 ` Marc Kleine-Budde 2011-04-27 13:35 ` Marc Kleine-Budde 2011-04-28 7:22 ` Subhasish Ghosh 2011-04-28 7:22 ` Subhasish Ghosh 2011-04-28 7:46 ` Arnd Bergmann 2011-04-28 7:46 ` Arnd Bergmann 2011-04-27 13:16 ` Arnd Bergmann 2011-04-27 13:16 ` Arnd Bergmann 2011-04-27 13:38 ` Subhasish Ghosh 2011-04-27 13:38 ` Subhasish Ghosh 2011-04-27 14:05 ` Arnd Bergmann 2011-04-27 14:05 ` Arnd Bergmann 2011-04-28 7:17 ` Subhasish Ghosh 2011-04-28 7:17 ` Subhasish Ghosh 2011-04-28 7:35 ` Arnd Bergmann 2011-04-28 7:35 ` Arnd Bergmann 2011-05-04 7:18 ` Subhasish Ghosh 2011-05-04 7:18 ` Subhasish Ghosh 2011-05-04 13:44 ` Arnd Bergmann [this message] 2011-05-04 13:44 ` Arnd Bergmann 2011-05-04 14:38 ` Nori, Sekhar 2011-05-04 14:38 ` Nori, Sekhar 2011-05-05 13:25 ` Subhasish Ghosh 2011-05-05 13:25 ` Subhasish Ghosh 2011-05-05 14:12 ` Arnd Bergmann 2011-05-05 14:12 ` Arnd Bergmann 2011-05-10 9:53 ` Subhasish Ghosh 2011-05-10 9:53 ` Subhasish Ghosh 2011-05-10 21:44 ` Arnd Bergmann 2011-05-10 21:44 ` Arnd Bergmann 2011-05-11 9:28 ` Subhasish Ghosh 2011-05-11 9:28 ` Subhasish Ghosh 2011-05-11 20:03 ` Arnd Bergmann 2011-05-11 20:03 ` Arnd Bergmann 2011-05-13 10:55 ` Subhasish Ghosh 2011-05-13 10:55 ` Subhasish Ghosh 2011-05-14 16:01 ` Mark Brown 2011-05-14 16:01 ` Mark Brown 2011-05-14 20:33 ` Arnd Bergmann 2011-05-14 20:33 ` Arnd Bergmann 2011-05-14 22:14 ` Mark Brown 2011-05-14 22:14 ` Mark Brown 2011-05-15 9:33 ` Arnd Bergmann 2011-05-15 9:33 ` Arnd Bergmann 2011-05-16 6:06 ` Subhasish Ghosh 2011-05-16 6:06 ` Subhasish Ghosh 2011-05-23 15:30 ` Arnd Bergmann 2011-05-23 15:30 ` Arnd Bergmann 2011-05-24 12:17 ` Subhasish Ghosh 2011-05-24 12:17 ` Subhasish Ghosh 2011-05-24 12:40 ` Arnd Bergmann 2011-05-24 12:40 ` Arnd Bergmann 2011-05-24 13:43 ` Greg KH 2011-05-24 13:43 ` Greg KH 2011-05-30 13:25 ` Subhasish Ghosh 2011-05-30 13:25 ` Subhasish Ghosh 2011-05-30 14:02 ` Greg KH 2011-05-30 14:02 ` Greg KH 2011-05-30 14:38 ` Subhasish Ghosh 2011-05-30 14:38 ` Subhasish Ghosh 2011-05-30 14:04 ` Arnd Bergmann 2011-05-30 14:04 ` Arnd Bergmann 2011-05-30 14:13 ` Subhasish Ghosh 2011-05-30 14:13 ` Subhasish Ghosh 2011-05-30 14:43 ` Arnd Bergmann 2011-05-30 14:43 ` Arnd Bergmann 2011-05-30 15:28 ` Subhasish Ghosh 2011-05-30 15:28 ` Subhasish Ghosh 2011-05-22 20:24 ` Samuel Ortiz 2011-05-22 20:24 ` Samuel Ortiz 2011-05-22 20:21 ` Samuel Ortiz 2011-05-22 20:21 ` Samuel Ortiz 2011-05-23 15:13 ` Arnd Bergmann 2011-05-23 15:13 ` Arnd Bergmann 2011-04-22 12:08 ` [PATCH v4 02/11] da850: add pruss clock Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 03/11] da850: pruss platform specific additions Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-26 11:06 ` Sergei Shtylyov 2011-04-26 11:06 ` Sergei Shtylyov 2011-04-27 6:43 ` Subhasish Ghosh 2011-04-27 6:43 ` Subhasish Ghosh 2011-04-27 10:05 ` Sergei Shtylyov 2011-04-27 10:05 ` Sergei Shtylyov 2011-04-27 10:19 ` Subhasish Ghosh 2011-04-27 10:19 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 04/11] da850: pruss board " Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 05/11] mfd: pruss SUART private data Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 06/11] da850: pruss SUART board specific additions Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 07/11] da850: pruss SUART platform " Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 09/11] mfd: pruss CAN private data Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 10/11] da850: pruss CAN platform specific additions Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 12:08 ` [PATCH v4 11/11] da850: pruss CAN board " Subhasish Ghosh 2011-04-22 12:08 ` Subhasish Ghosh 2011-04-22 16:03 ` Marc Kleine-Budde 2011-04-22 16:03 ` Marc Kleine-Budde 2011-04-26 10:57 ` Sergei Shtylyov 2011-04-26 10:57 ` Sergei Shtylyov 2011-04-27 7:03 ` Subhasish Ghosh 2011-04-27 7:03 ` Subhasish Ghosh 2011-05-20 5:38 [PATCH v4 01/11] mfd: add pruss mfd driver Subhasish Ghosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201105041544.19726.arnd@arndb.de \ --to=arnd@arndb.de \ --cc=davinci-linux-open-source@linux.davincidsp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m-watkins@ti.com \ --cc=nsekhar@ti.com \ --cc=sachi@mistralsolutions.com \ --cc=sameo@linux.intel.com \ --cc=subhasish@mistralsolutions.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.