All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhasish Ghosh" <subhasish@mistralsolutions.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: <davinci-linux-open-source@linux.davincidsp.com>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	<linux-arm-kernel@lists.infradead.org>, <m-watkins@ti.com>,
	<nsekhar@ti.com>, <sachi@mistralsolutions.com>,
	"Andrew Morton \(commit_signer:1/4=25%\)"
	<akpm@linux-foundation.org>,
	"Randy Dunlap \(commit_signer:1/4=25%\)"
	<randy.dunlap@oracle.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 08/11] tty: add pruss SUART driver
Date: Mon, 9 May 2011 19:20:17 +0530	[thread overview]
Message-ID: <3A9C5CD56396439DBF825BB4E5779DB9@subhasishg> (raw)
In-Reply-To: <20110509144610.6b4f7090@lxorguk.ukuu.org.uk>

>> I then modified this function to as follows and the error is not observed
>> anymore.
>
> That looks like you are somehow calling uart_carrier_raised somewhere
> with interrupts disabled ?
>
I am not calling this function in my driver atall, this is getting called by 
tty_port.c

int tty_port_block_til_ready(struct tty_port *port,
                                struct tty_struct *tty, struct file *filp)
{
 /* Probe the carrier. For devices with no carrier detect this
                   will always return true */
                cd = tty_port_carrier_raised(port);
                if (!(port->flags & ASYNC_CLOSING) &&
                                (do_clocal || cd))
                        break;
                if (signal_pending(current)) {
                        retval = -ERESTARTSYS;
                        break;
                }

 


WARNING: multiple messages have this Message-ID (diff)
From: subhasish@mistralsolutions.com (Subhasish Ghosh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/11] tty: add pruss SUART driver
Date: Mon, 9 May 2011 19:20:17 +0530	[thread overview]
Message-ID: <3A9C5CD56396439DBF825BB4E5779DB9@subhasishg> (raw)
In-Reply-To: <20110509144610.6b4f7090@lxorguk.ukuu.org.uk>

>> I then modified this function to as follows and the error is not observed
>> anymore.
>
> That looks like you are somehow calling uart_carrier_raised somewhere
> with interrupts disabled ?
>
I am not calling this function in my driver atall, this is getting called by 
tty_port.c

int tty_port_block_til_ready(struct tty_port *port,
                                struct tty_struct *tty, struct file *filp)
{
 /* Probe the carrier. For devices with no carrier detect this
                   will always return true */
                cd = tty_port_carrier_raised(port);
                if (!(port->flags & ASYNC_CLOSING) &&
                                (do_clocal || cd))
                        break;
                if (signal_pending(current)) {
                        retval = -ERESTARTSYS;
                        break;
                }

 

  reply	other threads:[~2011-05-09 13:50 UTC|newest]

Thread overview: 166+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 12:08 [PATCH v4 00/11] pruss mfd drivers Subhasish Ghosh
2011-04-22 11:50 ` [PATCH v4 08/11] tty: add pruss SUART driver Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-25 21:20   ` Greg KH
2011-04-25 21:20     ` Greg KH
2011-04-26  6:51     ` Nori, Sekhar
2011-04-26  6:51       ` Nori, Sekhar
2011-04-26 12:45       ` Greg KH
2011-04-26 12:45         ` Greg KH
2011-04-27  5:23         ` Subhasish Ghosh
2011-04-27  5:23           ` Subhasish Ghosh
2011-04-27 11:19           ` Nori, Sekhar
2011-04-27 11:19             ` Nori, Sekhar
2011-04-27 13:15             ` Subhasish Ghosh
2011-04-27 13:15               ` Subhasish Ghosh
2011-04-27 17:50               ` Nori, Sekhar
2011-04-27 17:50                 ` Nori, Sekhar
2011-05-02  8:34                 ` Subhasish Ghosh
2011-05-02  8:34                   ` Subhasish Ghosh
2011-05-02 17:15                   ` Nori, Sekhar
2011-05-02 17:15                     ` Nori, Sekhar
2011-05-10 10:54             ` Subhasish Ghosh
2011-05-10 10:54               ` Subhasish Ghosh
2011-05-10 13:13               ` Nori, Sekhar
2011-05-10 13:13                 ` Nori, Sekhar
2011-05-13 12:10                 ` Subhasish Ghosh
2011-05-13 12:10                   ` Subhasish Ghosh
2011-05-09 13:39   ` Subhasish Ghosh
2011-05-09 13:39     ` Subhasish Ghosh
2011-05-09 13:46     ` Alan Cox
2011-05-09 13:46       ` Alan Cox
2011-05-09 13:50       ` Subhasish Ghosh [this message]
2011-05-09 13:50         ` Subhasish Ghosh
2011-05-09 13:55         ` Alan Cox
2011-05-09 13:55           ` Alan Cox
2011-05-10  6:17           ` Subhasish Ghosh
2011-05-10  6:17             ` Subhasish Ghosh
2011-05-10 13:32             ` Alan Cox
2011-05-10 13:32               ` Alan Cox
2011-05-11  7:01               ` Subhasish Ghosh
2011-05-11  7:01                 ` Subhasish Ghosh
2011-05-11 10:35                 ` Alan Cox
2011-05-11 10:35                   ` Alan Cox
2011-04-22 12:08 ` [PATCH v4 01/11] mfd: add pruss mfd driver Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 16:00   ` Marc Kleine-Budde
2011-04-22 16:00     ` Marc Kleine-Budde
2011-04-27  6:39     ` Subhasish Ghosh
2011-04-27  6:39       ` Subhasish Ghosh
2011-04-27  7:29       ` Marc Kleine-Budde
2011-04-27  7:29         ` Marc Kleine-Budde
2011-04-27  9:12         ` Russell King - ARM Linux
2011-04-27  9:12           ` Russell King - ARM Linux
2011-04-27 13:18           ` Subhasish Ghosh
2011-04-27 13:18             ` Subhasish Ghosh
2011-04-27 13:35             ` Marc Kleine-Budde
2011-04-27 13:35               ` Marc Kleine-Budde
2011-04-28  7:22               ` Subhasish Ghosh
2011-04-28  7:22                 ` Subhasish Ghosh
2011-04-28  7:46                 ` Arnd Bergmann
2011-04-28  7:46                   ` Arnd Bergmann
2011-04-27 13:16   ` Arnd Bergmann
2011-04-27 13:16     ` Arnd Bergmann
2011-04-27 13:38     ` Subhasish Ghosh
2011-04-27 13:38       ` Subhasish Ghosh
2011-04-27 14:05       ` Arnd Bergmann
2011-04-27 14:05         ` Arnd Bergmann
2011-04-28  7:17         ` Subhasish Ghosh
2011-04-28  7:17           ` Subhasish Ghosh
2011-04-28  7:35           ` Arnd Bergmann
2011-04-28  7:35             ` Arnd Bergmann
2011-05-04  7:18             ` Subhasish Ghosh
2011-05-04  7:18               ` Subhasish Ghosh
2011-05-04 13:44               ` Arnd Bergmann
2011-05-04 13:44                 ` Arnd Bergmann
2011-05-04 14:38               ` Nori, Sekhar
2011-05-04 14:38                 ` Nori, Sekhar
2011-05-05 13:25                 ` Subhasish Ghosh
2011-05-05 13:25                   ` Subhasish Ghosh
2011-05-05 14:12                   ` Arnd Bergmann
2011-05-05 14:12                     ` Arnd Bergmann
2011-05-10  9:53                     ` Subhasish Ghosh
2011-05-10  9:53                       ` Subhasish Ghosh
2011-05-10 21:44                       ` Arnd Bergmann
2011-05-10 21:44                         ` Arnd Bergmann
2011-05-11  9:28                         ` Subhasish Ghosh
2011-05-11  9:28                           ` Subhasish Ghosh
2011-05-11 20:03                           ` Arnd Bergmann
2011-05-11 20:03                             ` Arnd Bergmann
2011-05-13 10:55                             ` Subhasish Ghosh
2011-05-13 10:55                               ` Subhasish Ghosh
2011-05-14 16:01                               ` Mark Brown
2011-05-14 16:01                                 ` Mark Brown
2011-05-14 20:33                                 ` Arnd Bergmann
2011-05-14 20:33                                   ` Arnd Bergmann
2011-05-14 22:14                                   ` Mark Brown
2011-05-14 22:14                                     ` Mark Brown
2011-05-15  9:33                                     ` Arnd Bergmann
2011-05-15  9:33                                       ` Arnd Bergmann
2011-05-16  6:06                                       ` Subhasish Ghosh
2011-05-16  6:06                                         ` Subhasish Ghosh
2011-05-23 15:30                                         ` Arnd Bergmann
2011-05-23 15:30                                           ` Arnd Bergmann
2011-05-24 12:17                                           ` Subhasish Ghosh
2011-05-24 12:17                                             ` Subhasish Ghosh
2011-05-24 12:40                                             ` Arnd Bergmann
2011-05-24 12:40                                               ` Arnd Bergmann
2011-05-24 13:43                                               ` Greg KH
2011-05-24 13:43                                                 ` Greg KH
2011-05-30 13:25                                                 ` Subhasish Ghosh
2011-05-30 13:25                                                   ` Subhasish Ghosh
2011-05-30 14:02                                                   ` Greg KH
2011-05-30 14:02                                                     ` Greg KH
2011-05-30 14:38                                                     ` Subhasish Ghosh
2011-05-30 14:38                                                       ` Subhasish Ghosh
2011-05-30 14:04                                                   ` Arnd Bergmann
2011-05-30 14:04                                                     ` Arnd Bergmann
2011-05-30 14:13                                                     ` Subhasish Ghosh
2011-05-30 14:13                                                       ` Subhasish Ghosh
2011-05-30 14:43                                                       ` Arnd Bergmann
2011-05-30 14:43                                                         ` Arnd Bergmann
2011-05-30 15:28                                                         ` Subhasish Ghosh
2011-05-30 15:28                                                           ` Subhasish Ghosh
2011-05-22 20:24                                   ` Samuel Ortiz
2011-05-22 20:24                                     ` Samuel Ortiz
2011-05-22 20:21                             ` Samuel Ortiz
2011-05-22 20:21                               ` Samuel Ortiz
2011-05-23 15:13                               ` Arnd Bergmann
2011-05-23 15:13                                 ` Arnd Bergmann
2011-04-22 12:08 ` [PATCH v4 02/11] da850: add pruss clock Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 03/11] da850: pruss platform specific additions Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-26 11:06   ` Sergei Shtylyov
2011-04-26 11:06     ` Sergei Shtylyov
2011-04-27  6:43     ` Subhasish Ghosh
2011-04-27  6:43       ` Subhasish Ghosh
2011-04-27 10:05       ` Sergei Shtylyov
2011-04-27 10:05         ` Sergei Shtylyov
2011-04-27 10:19         ` Subhasish Ghosh
2011-04-27 10:19           ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 04/11] da850: pruss board " Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 05/11] mfd: pruss SUART private data Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 06/11] da850: pruss SUART board specific additions Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 07/11] da850: pruss SUART platform " Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 09/11] mfd: pruss CAN private data Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 10/11] da850: pruss CAN platform specific additions Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 12:08 ` [PATCH v4 11/11] da850: pruss CAN board " Subhasish Ghosh
2011-04-22 12:08   ` Subhasish Ghosh
2011-04-22 16:03   ` Marc Kleine-Budde
2011-04-22 16:03     ` Marc Kleine-Budde
2011-04-26 10:57   ` Sergei Shtylyov
2011-04-26 10:57     ` Sergei Shtylyov
2011-04-27  7:03     ` Subhasish Ghosh
2011-04-27  7:03       ` Subhasish Ghosh
2011-05-16  5:17 [PATCH v4 08/11] tty: add pruss SUART driver Subhasish Ghosh
2011-05-17 18:32 ` Nori, Sekhar
2011-05-17 18:32   ` Nori, Sekhar
2011-05-20  7:14   ` Subhasish Ghosh
2011-05-20  7:14     ` Subhasish Ghosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A9C5CD56396439DBF825BB4E5779DB9@subhasishg \
    --to=subhasish@mistralsolutions.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=gregkh@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-watkins@ti.com \
    --cc=nsekhar@ti.com \
    --cc=randy.dunlap@oracle.com \
    --cc=sachi@mistralsolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.