All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Boojin Kim <boojin.kim@samsung.com>
Subject: Re: [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART
Date: Sat, 28 May 2011 17:39:04 +0800	[thread overview]
Message-ID: <20110528093904.GC21388@kroah.com> (raw)
In-Reply-To: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com>

On Fri, May 27, 2011 at 07:04:03PM -0700, Kukjin Kim wrote:
> From: Boojin Kim <boojin.kim@samsung.com>
> 
> This patch fixes the way of comparison for handling of two or more
> clock sources for UART.
> 
> For example, if just only one clock source is defined even though
> there are two clock sources for UART, the serial driver does not
> set proper clock up. Of course, it is problem.
> 
> So this patch changes the condition of comparison to avoid useless
> setup clock and adds a flag 'NO_NEED_CHECK_CLKSRC' which means
> selection of source clock is not required.
> 
> In addition, since the Exynos4210 has only one clock source for UART
> this patch adds the flag into its common_init_uarts().
> 
> Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
> Cc: Greg Kroah-Hartman <greg@kroah.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/mach-exynos4/init.c                     |    1 +
>  arch/arm/plat-samsung/include/plat/regs-serial.h |    2 ++
>  drivers/tty/serial/s5pv210.c                     |    4 ++--
>  3 files changed, 5 insertions(+), 2 deletions(-)

Is this needed in older kernels as well (like .39)?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART
Date: Sat, 28 May 2011 17:39:04 +0800	[thread overview]
Message-ID: <20110528093904.GC21388@kroah.com> (raw)
In-Reply-To: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com>

On Fri, May 27, 2011 at 07:04:03PM -0700, Kukjin Kim wrote:
> From: Boojin Kim <boojin.kim@samsung.com>
> 
> This patch fixes the way of comparison for handling of two or more
> clock sources for UART.
> 
> For example, if just only one clock source is defined even though
> there are two clock sources for UART, the serial driver does not
> set proper clock up. Of course, it is problem.
> 
> So this patch changes the condition of comparison to avoid useless
> setup clock and adds a flag 'NO_NEED_CHECK_CLKSRC' which means
> selection of source clock is not required.
> 
> In addition, since the Exynos4210 has only one clock source for UART
> this patch adds the flag into its common_init_uarts().
> 
> Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
> Cc: Greg Kroah-Hartman <greg@kroah.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/mach-exynos4/init.c                     |    1 +
>  arch/arm/plat-samsung/include/plat/regs-serial.h |    2 ++
>  drivers/tty/serial/s5pv210.c                     |    4 ++--
>  3 files changed, 5 insertions(+), 2 deletions(-)

Is this needed in older kernels as well (like .39)?

thanks,

greg k-h

  reply	other threads:[~2011-05-28  9:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28  2:04 [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART Kukjin Kim
2011-05-28  2:04 ` Kukjin Kim
2011-05-28  9:39 ` Greg KH [this message]
2011-05-28  9:39   ` Greg KH
2011-05-30  1:24   ` Kukjin Kim
2011-05-30  1:24     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110528093904.GC21388@kroah.com \
    --to=greg@kroah.com \
    --cc=boojin.kim@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.