From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sage Weil <sage@newdream.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [git pull] dentry_unhash() breakage
Date: Tue, 31 May 2011 18:33:48 +0100 [thread overview]
Message-ID: <20110531173348.GL11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1105310924040.25709@cobra.newdream.net>
On Tue, May 31, 2011 at 09:26:52AM -0700, Sage Weil wrote:
> On Mon, 30 May 2011, Christoph Hellwig wrote:
> > On Mon, May 30, 2011 at 06:56:01AM +0100, Al Viro wrote:
> > > A couple of dentry_unhash fallout fixes
> >
> > Shouldn't we do the shrink_dcache_parent only after a successfull
> > rmdir or rename?
>
> Yeah, that makes more sense to me...
No, it doesn't. Let's keep changes to minimum. I *really* don't want
to audit autofs and hell knows how many other places for more or less
subtle breakage caused by that. It's bad enough as it is...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sage Weil <sage@newdream.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [git pull] dentry_unhash() breakage
Date: Tue, 31 May 2011 18:33:48 +0100 [thread overview]
Message-ID: <20110531173348.GL11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1105310924040.25709@cobra.newdream.net>
On Tue, May 31, 2011 at 09:26:52AM -0700, Sage Weil wrote:
> On Mon, 30 May 2011, Christoph Hellwig wrote:
> > On Mon, May 30, 2011 at 06:56:01AM +0100, Al Viro wrote:
> > > A couple of dentry_unhash fallout fixes
> >
> > Shouldn't we do the shrink_dcache_parent only after a successfull
> > rmdir or rename?
>
> Yeah, that makes more sense to me...
No, it doesn't. Let's keep changes to minimum. I *really* don't want
to audit autofs and hell knows how many other places for more or less
subtle breakage caused by that. It's bad enough as it is...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-31 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 2:06 [regression, 3.0-rc1] dentry cache growth during unlinks, XFS performance way down Dave Chinner
2011-05-30 2:06 ` Dave Chinner
2011-05-30 3:47 ` Dave Chinner
2011-05-30 3:47 ` Dave Chinner
2011-05-30 4:20 ` Sage Weil
2011-05-30 4:20 ` Sage Weil
2011-05-30 5:56 ` [git pull] dentry_unhash() breakage Al Viro
2011-05-30 5:56 ` Al Viro
2011-05-30 8:59 ` Christoph Hellwig
2011-05-30 8:59 ` Christoph Hellwig
2011-05-31 16:26 ` Sage Weil
2011-05-31 16:26 ` Sage Weil
2011-05-31 17:33 ` Al Viro [this message]
2011-05-31 17:33 ` Al Viro
2011-05-30 10:07 ` [regression, 3.0-rc1] dentry cache growth during unlinks, XFS performance way down Dave Chinner
2011-05-30 10:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531173348.GL11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.