From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Kevin Hilman <khilman@ti.com> Cc: Linux PM mailing list <linux-pm@lists.linux-foundation.org>, Greg Kroah-Hartman <gregkh@suse.de>, Magnus Damm <magnus.damm@gmail.com>, Paul Walmsley <paul@pwsan.com>, Alan Stern <stern@rowland.harvard.edu>, LKML <linux-kernel@vger.kernel.org>, linux-sh@vger.kernel.org, Paul Mundt <lethal@linux-sh.org> Subject: Re: [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Date: Thu, 30 Jun 2011 23:25:25 +0000 [thread overview] Message-ID: <201107010125.25875.rjw@sisk.pl> (raw) In-Reply-To: <201107010055.26952.rjw@sisk.pl> On Friday, July 01, 2011, Rafael J. Wysocki wrote: > On Friday, July 01, 2011, Kevin Hilman wrote: > > "Rafael J. Wysocki" <rjw@sisk.pl> writes: ... > > The decision of whether or not to clock gate and/or power gate based on > > wakeup capabilies has to be made somewhere (and in fact is already made > > by existing code.) But IMO, that decision should only be made where > > wakeup capabilies are known, so that sensible decisions (for power > > management) can be made. > > > > Until there is a way in the generic code to distinguish between the > > various ways a device can wakeup, this decision should be left up to the > > code that knows how. > > OK, so I suppose your suggestion is to drop the patch and let the > .stop_device() and .power_off() PM domain callbacks to hand That should have been "handle". > that, is this correct? Anyway, neither .stop_device(), nor .power_off() can make such decisions, because they are used for both runtime PM and system suspend, so they shouldn't do system suspend-specific checks. So the only way forward I can see is to add a special PM domain callback, say .active_wakeup(), that will return "true" if the device is to be left active if wakeup-enabled. So the check you don't like will become something like: if (device_may_wakeup(dev) && genpd->active_wakeup && genpd->active_wakeup(dev)) return 0; Would that be better? Rafael
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Kevin Hilman <khilman@ti.com> Cc: Linux PM mailing list <linux-pm@lists.linux-foundation.org>, "Greg Kroah-Hartman" <gregkh@suse.de>, Magnus Damm <magnus.damm@gmail.com>, Paul Walmsley <paul@pwsan.com>, Alan Stern <stern@rowland.harvard.edu>, LKML <linux-kernel@vger.kernel.org>, linux-sh@vger.kernel.org, Paul Mundt <lethal@linux-sh.org> Subject: Re: [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Date: Fri, 1 Jul 2011 01:25:25 +0200 [thread overview] Message-ID: <201107010125.25875.rjw@sisk.pl> (raw) In-Reply-To: <201107010055.26952.rjw@sisk.pl> On Friday, July 01, 2011, Rafael J. Wysocki wrote: > On Friday, July 01, 2011, Kevin Hilman wrote: > > "Rafael J. Wysocki" <rjw@sisk.pl> writes: ... > > The decision of whether or not to clock gate and/or power gate based on > > wakeup capabilies has to be made somewhere (and in fact is already made > > by existing code.) But IMO, that decision should only be made where > > wakeup capabilies are known, so that sensible decisions (for power > > management) can be made. > > > > Until there is a way in the generic code to distinguish between the > > various ways a device can wakeup, this decision should be left up to the > > code that knows how. > > OK, so I suppose your suggestion is to drop the patch and let the > .stop_device() and .power_off() PM domain callbacks to hand That should have been "handle". > that, is this correct? Anyway, neither .stop_device(), nor .power_off() can make such decisions, because they are used for both runtime PM and system suspend, so they shouldn't do system suspend-specific checks. So the only way forward I can see is to add a special PM domain callback, say .active_wakeup(), that will return "true" if the device is to be left active if wakeup-enabled. So the check you don't like will become something like: if (device_may_wakeup(dev) && genpd->active_wakeup && genpd->active_wakeup(dev)) return 0; Would that be better? Rafael
next prev parent reply other threads:[~2011-06-30 23:25 UTC|newest] Thread overview: 261+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-11 20:23 [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki 2011-06-11 20:23 ` Rafael J. Wysocki 2011-06-11 20:23 ` Rafael J. Wysocki 2011-06-11 20:25 ` [PATCH 1/8] PM / Domains: Update documentation Rafael J. Wysocki 2011-06-11 20:25 ` Rafael J. Wysocki 2011-06-11 20:25 ` Rafael J. Wysocki 2011-06-11 20:26 ` [PATCH 2/8] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki 2011-06-11 20:26 ` Rafael J. Wysocki 2011-06-20 23:37 ` Kevin Hilman 2011-06-20 23:37 ` Kevin Hilman 2011-06-20 23:37 ` Kevin Hilman 2011-06-11 20:26 ` Rafael J. Wysocki 2011-06-11 20:27 ` [PATCH 3/8] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki 2011-06-11 20:27 ` Rafael J. Wysocki 2011-06-11 20:27 ` Rafael J. Wysocki 2011-06-11 20:31 ` [PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki 2011-06-11 20:31 ` Rafael J. Wysocki 2011-06-11 20:31 ` Rafael J. Wysocki 2011-06-19 22:02 ` [Update][PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v6) Rafael J. Wysocki 2011-06-19 22:02 ` Rafael J. Wysocki 2011-06-19 22:02 ` Rafael J. Wysocki 2011-06-21 17:42 ` Kevin Hilman 2011-06-21 17:42 ` Kevin Hilman 2011-06-21 17:42 ` Kevin Hilman 2011-06-22 0:07 ` Rafael J. Wysocki 2011-06-22 0:07 ` Rafael J. Wysocki 2011-06-22 19:51 ` Kevin Hilman 2011-06-22 19:51 ` Kevin Hilman 2011-06-22 19:51 ` Kevin Hilman 2011-06-22 21:30 ` Rafael J. Wysocki 2011-06-22 21:30 ` Rafael J. Wysocki 2011-06-22 21:30 ` Rafael J. Wysocki 2011-06-22 0:07 ` Rafael J. Wysocki 2011-06-11 20:36 ` [PATCH 5/8] PM: Introduce generic "noirq" callback routines for subsystems Rafael J. Wysocki 2011-06-11 20:36 ` Rafael J. Wysocki 2011-06-11 20:36 ` Rafael J. Wysocki 2011-06-11 20:37 ` [PATCH 6/8] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME Rafael J. Wysocki 2011-06-11 20:37 ` Rafael J. Wysocki 2011-06-11 20:37 ` Rafael J. Wysocki 2011-06-11 20:39 ` [PATCH 7/8] PM / Domains: System-wide transitions support for generic PM domains Rafael J. Wysocki 2011-06-11 20:39 ` Rafael J. Wysocki 2011-06-11 23:28 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v2) Rafael J. Wysocki 2011-06-11 23:28 ` Rafael J. Wysocki 2011-06-11 23:28 ` Rafael J. Wysocki 2011-06-19 22:06 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki 2011-06-19 22:06 ` Rafael J. Wysocki 2011-06-20 23:05 ` Rafael J. Wysocki 2011-06-20 23:05 ` Rafael J. Wysocki 2011-06-20 23:05 ` Rafael J. Wysocki 2011-06-22 21:50 ` Kevin Hilman 2011-06-22 21:50 ` Kevin Hilman 2011-06-22 21:50 ` Kevin Hilman 2011-06-22 22:16 ` Rafael J. Wysocki 2011-06-22 22:16 ` Rafael J. Wysocki 2011-06-22 22:16 ` Rafael J. Wysocki 2011-06-22 22:18 ` Kevin Hilman 2011-06-22 22:18 ` Kevin Hilman 2011-06-22 22:22 ` Rafael J. Wysocki 2011-06-22 22:22 ` Rafael J. Wysocki 2011-06-23 13:57 ` [PATCH] PM / Runtime: Update documentation of interactions with system sleep Rafael J. Wysocki 2011-06-23 13:57 ` Rafael J. Wysocki 2011-06-24 18:25 ` Kevin Hilman 2011-06-24 18:25 ` Kevin Hilman 2011-06-24 18:25 ` Kevin Hilman 2011-06-23 13:57 ` Rafael J. Wysocki 2011-06-22 22:22 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki 2011-06-22 22:18 ` Kevin Hilman 2011-06-23 14:19 ` Alan Stern 2011-06-23 14:19 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern 2011-06-23 14:19 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Alan Stern 2011-06-23 14:44 ` Rafael J. Wysocki 2011-06-23 14:44 ` Rafael J. Wysocki 2011-06-23 14:44 ` Rafael J. Wysocki 2011-06-23 15:11 ` Alan Stern 2011-06-23 15:11 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern 2011-06-23 15:11 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Alan Stern 2011-06-23 17:41 ` Rafael J. Wysocki 2011-06-23 17:41 ` Rafael J. Wysocki 2011-06-23 17:41 ` Rafael J. Wysocki 2011-06-23 18:22 ` Alan Stern 2011-06-23 18:22 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support Alan Stern 2011-06-23 18:22 ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Alan Stern 2011-06-23 21:03 ` Rafael J. Wysocki 2011-06-23 21:03 ` Rafael J. Wysocki 2011-06-23 21:03 ` Rafael J. Wysocki 2011-06-19 22:06 ` Rafael J. Wysocki 2011-06-11 20:39 ` [PATCH 7/8] PM / Domains: System-wide transitions support for generic PM domains Rafael J. Wysocki 2011-06-11 20:40 ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Rafael J. Wysocki 2011-06-11 20:40 ` Rafael J. Wysocki 2011-06-11 20:40 ` Rafael J. Wysocki 2011-06-14 13:12 ` Magnus Damm 2011-06-14 13:12 ` Magnus Damm 2011-06-14 21:16 ` Rafael J. Wysocki 2011-06-14 21:16 ` Rafael J. Wysocki 2011-06-14 21:16 ` Rafael J. Wysocki 2011-06-15 14:17 ` Magnus Damm 2011-06-15 14:17 ` Magnus Damm 2011-06-15 23:06 ` Rafael J. Wysocki 2011-06-15 23:06 ` Rafael J. Wysocki 2011-06-19 22:07 ` [Update][PATCH 8/8] ARM / shmobile: Support for I/O power domains for SH7372 (v6) Rafael J. Wysocki 2011-06-19 22:07 ` Rafael J. Wysocki 2011-06-20 2:01 ` Paul Mundt 2011-06-20 2:01 ` Paul Mundt 2011-06-20 22:30 ` Rafael J. Wysocki 2011-06-20 22:30 ` Rafael J. Wysocki 2011-06-21 11:57 ` Rafael J. Wysocki 2011-06-21 11:57 ` Rafael J. Wysocki 2011-06-21 12:47 ` Paul Mundt 2011-06-21 12:47 ` Paul Mundt 2011-06-21 12:47 ` Paul Mundt 2011-06-21 11:57 ` Rafael J. Wysocki 2011-06-20 22:30 ` Rafael J. Wysocki 2011-06-20 2:01 ` Paul Mundt 2011-06-19 22:07 ` Rafael J. Wysocki 2011-06-15 23:06 ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Rafael J. Wysocki 2011-07-10 11:45 ` Laurent Pinchart 2011-07-10 11:45 ` Laurent Pinchart 2011-07-10 11:45 ` Laurent Pinchart 2011-06-15 14:17 ` Magnus Damm 2011-06-14 13:12 ` Magnus Damm 2011-06-11 20:57 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Greg KH 2011-06-11 20:57 ` Greg KH 2011-06-11 20:57 ` Greg KH 2011-06-21 0:02 ` Kevin Hilman 2011-06-21 0:02 ` Kevin Hilman 2011-06-21 0:02 ` Kevin Hilman 2011-06-21 11:06 ` Rafael J. Wysocki 2011-06-21 11:06 ` Rafael J. Wysocki 2011-06-21 11:06 ` Rafael J. Wysocki 2011-06-21 14:47 ` Kevin Hilman 2011-06-21 14:47 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains Kevin Hilman 2011-06-21 14:47 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Kevin Hilman 2011-06-25 21:24 ` [PATCH 0/10 v6] PM / Domains: Support for generic I/O PM domains Rafael J. Wysocki 2011-06-25 21:24 ` Rafael J. Wysocki 2011-06-25 21:24 ` [PATCH 1/10 v6] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki 2011-06-25 21:24 ` Rafael J. Wysocki 2011-06-25 21:24 ` Rafael J. Wysocki 2011-06-25 21:25 ` [PATCH 2/10 v6] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki 2011-06-25 21:25 ` Rafael J. Wysocki 2011-06-25 21:25 ` Rafael J. Wysocki 2011-06-25 21:26 ` [PATCH 3/10 v6] PM / Domains: Support for generic I/O PM domains (v7) Rafael J. Wysocki 2011-06-25 21:26 ` Rafael J. Wysocki 2011-06-25 21:26 ` Rafael J. Wysocki 2011-06-30 6:14 ` Ming Lei 2011-06-30 6:14 ` Ming Lei 2011-06-30 18:58 ` Rafael J. Wysocki 2011-06-30 18:58 ` Rafael J. Wysocki 2011-06-30 18:58 ` Rafael J. Wysocki 2011-06-30 6:14 ` Ming Lei 2011-07-01 18:11 ` Kevin Hilman 2011-07-01 18:11 ` Kevin Hilman 2011-07-01 20:03 ` Rafael J. Wysocki 2011-07-01 20:03 ` Rafael J. Wysocki 2011-07-01 20:03 ` Rafael J. Wysocki 2011-07-01 18:11 ` Kevin Hilman 2011-06-25 21:27 ` [PATCH 4/10 v6] PM: Introduce generic "noirq" callback routines for subsystems (v2) Rafael J. Wysocki 2011-06-25 21:27 ` Rafael J. Wysocki 2011-06-25 21:27 ` Rafael J. Wysocki 2011-06-25 21:27 ` [PATCH 5/10 v6] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME (v2) Rafael J. Wysocki 2011-06-25 21:27 ` Rafael J. Wysocki 2011-06-25 21:27 ` Rafael J. Wysocki 2011-06-25 21:28 ` [PATCH 6/10 v6] PM / Domains: System-wide transitions support for generic domains (v4) Rafael J. Wysocki 2011-06-25 21:28 ` Rafael J. Wysocki 2011-06-28 23:44 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions support for generic domains (v5) Rafael J. Wysocki 2011-06-28 23:44 ` Rafael J. Wysocki 2011-06-28 23:44 ` Rafael J. Wysocki 2011-07-08 0:29 ` Kevin Hilman 2011-07-08 0:29 ` Kevin Hilman 2011-07-08 9:24 ` Rafael J. Wysocki 2011-07-08 9:24 ` Rafael J. Wysocki 2011-07-08 9:24 ` Rafael J. Wysocki 2011-07-08 14:37 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions Alan Stern 2011-07-08 14:37 ` [Update][PATCH 6/10] PM / Domains: System-wide transitions support for generic domains (v5) Alan Stern 2011-07-08 17:20 ` Kevin Hilman 2011-07-08 17:20 ` Kevin Hilman 2011-07-08 17:20 ` Kevin Hilman 2011-07-08 18:06 ` Rafael J. Wysocki 2011-07-08 18:06 ` Rafael J. Wysocki 2011-07-08 19:24 ` Rafael J. Wysocki 2011-07-08 19:24 ` Rafael J. Wysocki 2011-07-08 19:24 ` Rafael J. Wysocki 2011-07-09 14:15 ` Rafael J. Wysocki 2011-07-09 14:15 ` Rafael J. Wysocki 2011-07-09 14:15 ` Rafael J. Wysocki 2011-07-11 15:37 ` Kevin Hilman 2011-07-11 15:37 ` Kevin Hilman 2011-07-11 15:37 ` Kevin Hilman 2011-07-11 19:39 ` Rafael J. Wysocki 2011-07-11 19:39 ` Rafael J. Wysocki 2011-07-11 19:39 ` Rafael J. Wysocki 2011-07-08 18:06 ` Rafael J. Wysocki 2011-07-08 17:56 ` Rafael J. Wysocki 2011-07-08 17:56 ` Rafael J. Wysocki 2011-07-08 17:56 ` Rafael J. Wysocki 2011-07-08 14:37 ` Alan Stern 2011-07-08 0:29 ` Kevin Hilman 2011-06-25 21:28 ` [PATCH 6/10 v6] PM / Domains: System-wide transitions support for generic domains (v4) Rafael J. Wysocki 2011-06-25 21:29 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Rafael J. Wysocki 2011-06-25 21:29 ` Rafael J. Wysocki 2011-06-25 21:29 ` Rafael J. Wysocki 2011-06-29 23:50 ` Kevin Hilman 2011-06-29 23:50 ` Kevin Hilman 2011-06-30 19:37 ` Rafael J. Wysocki 2011-06-30 19:37 ` Rafael J. Wysocki 2011-06-30 19:37 ` Rafael J. Wysocki 2011-06-30 22:42 ` Kevin Hilman 2011-06-30 22:42 ` Kevin Hilman 2011-06-30 22:42 ` Kevin Hilman 2011-06-30 22:55 ` Rafael J. Wysocki 2011-06-30 22:55 ` Rafael J. Wysocki 2011-06-30 22:55 ` Rafael J. Wysocki 2011-06-30 23:14 ` Kevin Hilman 2011-06-30 23:14 ` Kevin Hilman 2011-06-30 23:14 ` Kevin Hilman 2011-06-30 23:28 ` Rafael J. Wysocki 2011-06-30 23:28 ` Rafael J. Wysocki 2011-06-30 23:28 ` Rafael J. Wysocki 2011-07-01 0:01 ` Kevin Hilman 2011-07-01 0:01 ` Kevin Hilman 2011-07-01 0:01 ` Kevin Hilman 2011-07-01 0:24 ` Rafael J. Wysocki 2011-07-01 0:24 ` Rafael J. Wysocki 2011-07-01 0:24 ` Rafael J. Wysocki 2011-07-01 14:34 ` Kevin Hilman 2011-07-01 14:34 ` Kevin Hilman 2011-07-01 14:34 ` Kevin Hilman 2011-06-30 23:25 ` Rafael J. Wysocki 2011-06-30 23:25 ` Rafael J. Wysocki [this message] 2011-06-30 23:25 ` Rafael J. Wysocki 2011-07-01 14:45 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during Alan Stern 2011-07-01 14:45 ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Alan Stern 2011-07-01 20:06 ` Rafael J. Wysocki 2011-07-01 20:06 ` Rafael J. Wysocki 2011-07-01 20:06 ` Rafael J. Wysocki 2011-07-01 14:45 ` Alan Stern 2011-06-29 23:50 ` Kevin Hilman 2011-06-25 21:30 ` [PATCH 8/10 v6] PM: Allow the clocks management code to be used during system suspend Rafael J. Wysocki 2011-06-25 21:30 ` Rafael J. Wysocki 2011-06-25 21:30 ` Rafael J. Wysocki 2011-06-25 21:30 ` [PATCH 9/10 v6] PM: Rename clock management functions Rafael J. Wysocki 2011-06-25 21:30 ` Rafael J. Wysocki 2011-06-25 21:30 ` Rafael J. Wysocki 2011-06-25 21:31 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Rafael J. Wysocki 2011-06-25 21:31 ` Rafael J. Wysocki 2011-06-27 4:07 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains Magnus Damm 2011-06-27 4:07 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Magnus Damm 2011-06-27 4:07 ` Magnus Damm 2011-06-27 19:25 ` Rafael J. Wysocki 2011-06-27 19:25 ` Rafael J. Wysocki 2011-06-27 19:25 ` Rafael J. Wysocki 2011-06-27 23:21 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains Magnus Damm 2011-06-27 23:21 ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Magnus Damm 2011-06-27 23:21 ` Magnus Damm 2011-06-28 10:08 ` Rafael J. Wysocki 2011-06-28 10:08 ` Rafael J. Wysocki 2011-06-28 10:08 ` Rafael J. Wysocki 2011-06-25 21:31 ` Rafael J. Wysocki 2011-07-01 18:27 ` [PATCH 0/10 v6] PM / Domains: Support for generic I/O PM domains Kevin Hilman 2011-07-01 18:27 ` Kevin Hilman 2011-07-01 18:27 ` Kevin Hilman 2011-06-25 21:24 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201107010125.25875.rjw@sisk.pl \ --to=rjw@sisk.pl \ --cc=gregkh@suse.de \ --cc=khilman@ti.com \ --cc=lethal@linux-sh.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=paul@pwsan.com \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.