All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.
Date: Mon, 04 Jul 2011 21:47:15 +0200	[thread overview]
Message-ID: <20110704194715.9826115794D9@gemini.denx.de> (raw)
In-Reply-To: <20110704184659.GG3016@harvey-pc.matrox.com>

Dear Christopher Harvey,

In message <20110704184659.GG3016@harvey-pc.matrox.com> you wrote:
>
> > Need the empty line that wasn't there before?  Same Q for every file in
> > this patch.
> 
> I generated this patch with sed actually. I could easily re-run it and
> tell it to remove the newlines. Lets see if it gets
> considered/accepted first.

Please fix this (and the other comments), and it goes in.

> > >  #define CONFIG_SYS_TEXT_BASE		0x60800000
> > >  
> > >  /* High Level Configuration Options */
> > > -#define CONFIG_ARMV7			1
> > > +
> > >  
> > 
> > If that was the only remaining high level config option, should the
> > comment be removed?
> 
> I figured maintainers would get to it eventually. 

Such "eventually" never works.  Please go through this manually and
clean up.  Thanks.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn Du ein' weise Antwort verlangst, Mu?t Du vern?nftig fragen.
                                                -- Goethe, Invektiven

  reply	other threads:[~2011-07-04 19:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1309799825.git.charvey@matrox.com>
2011-07-04 17:43 ` [U-Boot] [PATCH 1/5] Added documentation for CONFIG_SYS_TEXT_BASE for ARM Christopher Harvey
2011-07-04 19:39   ` Wolfgang Denk
2011-07-04 17:43 ` [U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked " Christopher Harvey
2011-07-04 19:43   ` Wolfgang Denk
2011-07-06 20:58     ` Christopher Harvey
2011-07-06 21:29       ` Wolfgang Denk
2011-07-07 16:10   ` Albert ARIBAUD
2011-07-04 17:44 ` [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7 Christopher Harvey
2011-07-04 18:00   ` Jason
2011-07-04 18:46     ` Christopher Harvey
2011-07-04 19:47       ` Wolfgang Denk [this message]
2011-07-04 17:45 ` [U-Boot] [PATCH 4/5] Don't compile in large memory test function by default Christopher Harvey
2011-07-07 16:13   ` Albert ARIBAUD
2011-07-04 17:45 ` [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it Christopher Harvey
2011-07-04 18:08   ` Jason
2011-07-04 18:55     ` Christopher Harvey
2011-07-04 19:56       ` Wolfgang Denk
2011-07-04 20:13       ` Jason
2011-07-04 20:32         ` Christopher Harvey
2011-07-04 21:24           ` Jason
2011-07-05  7:21             ` Igor Grinberg
2011-07-05  7:31           ` Igor Grinberg
2011-07-04 19:53   ` Wolfgang Denk
2011-07-05  7:38   ` Igor Grinberg
2011-07-05 10:04     ` Wolfgang Denk
2011-07-05 10:46       ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110704194715.9826115794D9@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.