All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Harvey <charvey@matrox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked for ARM.
Date: Wed, 6 Jul 2011 16:58:57 -0400	[thread overview]
Message-ID: <20110706205857.GB2168@harvey-pc.matrox.com> (raw)
In-Reply-To: <20110704194324.321C015794D9@gemini.denx.de>

On Mon, Jul 04, 2011 at 09:43:24PM +0200, Wolfgang Denk wrote:
> Dear Christopher Harvey,
> 
> In message <20110704174348.GC3016@harvey-pc.matrox.com> you wrote:
> > Signed-off-by: Christopher Harvey <charvey@matrox.com>
> > ---
> >  doc/README.arm-relocation |    9 ++++++++-
> >  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> Please let's stop with ARM specific documatation of things that are
> considered generic.
> 
> > +The code that picks the location in RAM for ARM can be found in the 
> > +arch/arm/lib/board.c file under the board_init_f function. 
> 
> under the function? Who dropped that code? :-)  s/under/in/
> 
> Also delete "for ARM", and s/arm/<arch>/.  This is not ARM specific.
> 

I don't understand, I found the following snippet in 
arch/arm/lib/board.c

       --addr defined and set here--

	gd->relocaddr = addr;
	gd->start_addr_sp = addr_sp;
	gd->reloc_off = addr - _TEXT_BASE;
	debug ("relocation Offset is: %08lx\n", gd->reloc_off);
	memcpy (id, (void *)gd, sizeof (gd_t));

	relocate_code (addr_sp, id, addr);
	/* NOTREACHED - relocate_code() does not return */

Running grep -R gd->relocaddr *,
I found similar assignments for various architectures. 

 ...
 [snip]
 ...
> 
> Best regards,
> 
> Wolfgang Denk
> 

Thanks for the clarification,
-Chris

  reply	other threads:[~2011-07-06 20:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1309799825.git.charvey@matrox.com>
2011-07-04 17:43 ` [U-Boot] [PATCH 1/5] Added documentation for CONFIG_SYS_TEXT_BASE for ARM Christopher Harvey
2011-07-04 19:39   ` Wolfgang Denk
2011-07-04 17:43 ` [U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked " Christopher Harvey
2011-07-04 19:43   ` Wolfgang Denk
2011-07-06 20:58     ` Christopher Harvey [this message]
2011-07-06 21:29       ` Wolfgang Denk
2011-07-07 16:10   ` Albert ARIBAUD
2011-07-04 17:44 ` [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7 Christopher Harvey
2011-07-04 18:00   ` Jason
2011-07-04 18:46     ` Christopher Harvey
2011-07-04 19:47       ` Wolfgang Denk
2011-07-04 17:45 ` [U-Boot] [PATCH 4/5] Don't compile in large memory test function by default Christopher Harvey
2011-07-07 16:13   ` Albert ARIBAUD
2011-07-04 17:45 ` [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it Christopher Harvey
2011-07-04 18:08   ` Jason
2011-07-04 18:55     ` Christopher Harvey
2011-07-04 19:56       ` Wolfgang Denk
2011-07-04 20:13       ` Jason
2011-07-04 20:32         ` Christopher Harvey
2011-07-04 21:24           ` Jason
2011-07-05  7:21             ` Igor Grinberg
2011-07-05  7:31           ` Igor Grinberg
2011-07-04 19:53   ` Wolfgang Denk
2011-07-05  7:38   ` Igor Grinberg
2011-07-05 10:04     ` Wolfgang Denk
2011-07-05 10:46       ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706205857.GB2168@harvey-pc.matrox.com \
    --to=charvey@matrox.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.