From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.
Date: Mon, 04 Jul 2011 21:56:28 +0200 [thread overview]
Message-ID: <20110704195628.58E0815794D9@gemini.denx.de> (raw)
In-Reply-To: <20110704185554.GH3016@harvey-pc.matrox.com>
Dear Christopher Harvey,
In message <20110704185554.GH3016@harvey-pc.matrox.com> you wrote:
> On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote:
> > On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote:
> > > Signed-off-by: Christopher Harvey <charvey@matrox.com>
> > > ---
> > > arch/arm/lib/board.c | 4 ++++
> > > arch/arm/lib/bootm.c | 6 ++++++
> > > 2 files changed, 10 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> > > index 169dfeb..dbb835a 100644
> > > --- a/arch/arm/lib/board.c
> > > +++ b/arch/arm/lib/board.c
> > > @@ -404,6 +404,10 @@ void board_init_f (ulong bootflag)
> > > post_bootmode_init();
> > > post_run (NULL, POST_ROM | post_bootmode_get(0));
> > > #endif
> > > + /* 0xffffffff is used to mark is value as "unset".
> >
> > s/mark is/mark a/
>
> Yes, what I meant was:
> 0xffffffff is used to mark a value as "unset".
But this is wrong. It is not unset (= undefined), it is set.
More specifically, it is set to an illegal value.
> > Also, shouldn't the compile fail in this case (#error)? Or, at least #warn?
> The compiler can't know what machid will be at runtime. Maybe a "would
> you like to continue?" prompt could work.
No. Just print a warning message, and continue.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To know how another being, another creature feels - that is impos-
sible. - Terry Pratchett, _The Dark Side of the Sun_
next prev parent reply other threads:[~2011-07-04 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1309799825.git.charvey@matrox.com>
2011-07-04 17:43 ` [U-Boot] [PATCH 1/5] Added documentation for CONFIG_SYS_TEXT_BASE for ARM Christopher Harvey
2011-07-04 19:39 ` Wolfgang Denk
2011-07-04 17:43 ` [U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked " Christopher Harvey
2011-07-04 19:43 ` Wolfgang Denk
2011-07-06 20:58 ` Christopher Harvey
2011-07-06 21:29 ` Wolfgang Denk
2011-07-07 16:10 ` Albert ARIBAUD
2011-07-04 17:44 ` [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7 Christopher Harvey
2011-07-04 18:00 ` Jason
2011-07-04 18:46 ` Christopher Harvey
2011-07-04 19:47 ` Wolfgang Denk
2011-07-04 17:45 ` [U-Boot] [PATCH 4/5] Don't compile in large memory test function by default Christopher Harvey
2011-07-07 16:13 ` Albert ARIBAUD
2011-07-04 17:45 ` [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it Christopher Harvey
2011-07-04 18:08 ` Jason
2011-07-04 18:55 ` Christopher Harvey
2011-07-04 19:56 ` Wolfgang Denk [this message]
2011-07-04 20:13 ` Jason
2011-07-04 20:32 ` Christopher Harvey
2011-07-04 21:24 ` Jason
2011-07-05 7:21 ` Igor Grinberg
2011-07-05 7:31 ` Igor Grinberg
2011-07-04 19:53 ` Wolfgang Denk
2011-07-05 7:38 ` Igor Grinberg
2011-07-05 10:04 ` Wolfgang Denk
2011-07-05 10:46 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704195628.58E0815794D9@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.