From: Russell King - ARM Linux <linux@arm.linux.org.uk> To: Dong Aisheng <b29396@freescale.com> Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de, broonie@opensource.wolfsonmicro.com, u.kleine-koenig@pengutronix.de, lrg@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver Date: Wed, 13 Jul 2011 08:44:37 +0100 [thread overview] Message-ID: <20110713074437.GF23270@n2100.arm.linux.org.uk> (raw) In-Reply-To: <1310483085-31442-2-git-send-email-b29396@freescale.com> On Tue, Jul 12, 2011 at 11:04:36PM +0800, Dong Aisheng wrote: > +static int mxs_pcm_preallocate_dma_buffer(struct snd_pcm *pcm, int stream) > +{ > + struct snd_pcm_substream *substream = pcm->streams[stream].substream; > + struct snd_dma_buffer *buf = &substream->dma_buffer; > + size_t size = 64 * 1024; > + > + buf->dev.type = SNDRV_DMA_TYPE_DEV; > + buf->dev.dev = pcm->card->dev; > + buf->private_data = NULL; > + buf->area = dma_alloc_writecombine(pcm->card->dev, size, > + &buf->addr, GFP_KERNEL); ... > +static int snd_mxs_pcm_mmap(struct snd_pcm_substream *substream, > + struct vm_area_struct *vma) > +{ > + struct snd_pcm_runtime *runtime = substream->runtime; > + int ret; > + > + ret = dma_mmap_coherent(NULL, vma, runtime->dma_area, > + runtime->dma_addr, runtime->dma_bytes); This is wrong. Hint 1: int dma_mmap_writecombine(struct device *dev, struct vm_area_struct *vma, void *cpu_addr, dma_addr_t dma_addr, size_t size) Hint 2: struct device *dev - you have one above.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver Date: Wed, 13 Jul 2011 08:44:37 +0100 [thread overview] Message-ID: <20110713074437.GF23270@n2100.arm.linux.org.uk> (raw) In-Reply-To: <1310483085-31442-2-git-send-email-b29396@freescale.com> On Tue, Jul 12, 2011 at 11:04:36PM +0800, Dong Aisheng wrote: > +static int mxs_pcm_preallocate_dma_buffer(struct snd_pcm *pcm, int stream) > +{ > + struct snd_pcm_substream *substream = pcm->streams[stream].substream; > + struct snd_dma_buffer *buf = &substream->dma_buffer; > + size_t size = 64 * 1024; > + > + buf->dev.type = SNDRV_DMA_TYPE_DEV; > + buf->dev.dev = pcm->card->dev; > + buf->private_data = NULL; > + buf->area = dma_alloc_writecombine(pcm->card->dev, size, > + &buf->addr, GFP_KERNEL); ... > +static int snd_mxs_pcm_mmap(struct snd_pcm_substream *substream, > + struct vm_area_struct *vma) > +{ > + struct snd_pcm_runtime *runtime = substream->runtime; > + int ret; > + > + ret = dma_mmap_coherent(NULL, vma, runtime->dma_area, > + runtime->dma_addr, runtime->dma_bytes); This is wrong. Hint 1: int dma_mmap_writecombine(struct device *dev, struct vm_area_struct *vma, void *cpu_addr, dma_addr_t dma_addr, size_t size) Hint 2: struct device *dev - you have one above.
next prev parent reply other threads:[~2011-07-13 7:44 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-12 15:04 [PATCH V2 00/10] Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 23:27 ` Mark Brown 2011-07-12 23:27 ` Mark Brown 2011-07-13 3:20 ` Dong Aisheng-B29396 2011-07-13 3:20 ` Dong Aisheng-B29396 2011-07-13 6:29 ` Dong Aisheng-B29396 2011-07-13 6:29 ` Dong Aisheng-B29396 2011-07-13 7:44 ` Russell King - ARM Linux [this message] 2011-07-13 7:44 ` Russell King - ARM Linux 2011-07-13 8:17 ` Dong Aisheng-B29396 2011-07-13 8:17 ` Dong Aisheng-B29396 2011-07-14 12:31 ` Wolfram Sang 2011-07-14 12:31 ` Wolfram Sang 2011-07-14 16:15 ` Dong Aisheng 2011-07-14 16:15 ` [alsa-devel] " Dong Aisheng 2011-07-15 6:30 ` Dong Aisheng-B29396 2011-07-15 6:30 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-12 15:04 ` [PATCH V2 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 1:03 ` Mark Brown 2011-07-13 1:03 ` Mark Brown 2011-07-13 8:14 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-13 8:14 ` Dong Aisheng-B29396 2011-07-14 3:06 ` Mark Brown 2011-07-14 3:06 ` Mark Brown 2011-07-14 4:34 ` Dong Aisheng-B29396 2011-07-14 4:34 ` Dong Aisheng-B29396 2011-07-14 10:39 ` Dong Aisheng-B29396 2011-07-14 10:39 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-14 11:05 ` Mark Brown 2011-07-14 11:05 ` [alsa-devel] " Mark Brown 2011-07-14 16:06 ` Dong Aisheng 2011-07-14 16:06 ` [alsa-devel] " Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 11:57 ` Wolfram Sang 2011-07-13 11:57 ` Wolfram Sang 2011-07-13 12:19 ` Dong Aisheng-B29396 2011-07-13 12:19 ` Dong Aisheng-B29396 2011-07-13 13:40 ` Dong Aisheng-B29396 2011-07-13 13:40 ` Dong Aisheng-B29396 2011-07-13 14:00 ` Wolfram Sang 2011-07-13 14:00 ` Wolfram Sang 2011-07-13 14:13 ` Dong Aisheng-B29396 2011-07-13 14:13 ` Dong Aisheng-B29396 2011-07-13 14:22 ` Dong Aisheng-B29396 2011-07-13 14:22 ` Dong Aisheng-B29396 2011-07-13 15:01 ` Wolfram Sang 2011-07-13 15:01 ` Wolfram Sang 2011-07-13 15:16 ` Dong Aisheng 2011-07-13 15:16 ` Dong Aisheng 2011-07-13 12:46 ` Mark Brown 2011-07-13 12:46 ` Mark Brown 2011-07-13 12:59 ` Wolfram Sang 2011-07-13 12:59 ` Wolfram Sang 2011-07-13 15:58 ` Wolfram Sang 2011-07-13 15:58 ` Wolfram Sang 2011-07-14 3:04 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-14 3:04 ` Dong Aisheng-B29396 [not found] ` <1310483085-31442-4-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2011-07-15 15:11 ` Shawn Guo 2011-07-15 15:11 ` Shawn Guo 2011-07-15 15:17 ` Mark Brown 2011-07-15 15:17 ` Mark Brown 2011-07-12 15:04 ` [PATCH V2 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 9:08 ` Wolfram Sang 2011-07-13 9:08 ` Wolfram Sang 2011-07-13 11:13 ` Dong Aisheng 2011-07-13 11:13 ` [alsa-devel] " Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 05/10] ARM: mxs: add saif clock Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 06/10] ARM: mxs: add saif device Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-15 13:32 ` Wolfram Sang 2011-07-15 13:32 ` Wolfram Sang 2011-07-15 15:02 ` Dong Aisheng 2011-07-15 15:02 ` [alsa-devel] " Dong Aisheng 2011-07-15 15:34 ` Wolfram Sang 2011-07-15 15:34 ` [alsa-devel] " Wolfram Sang 2011-07-15 17:22 ` Dong Aisheng 2011-07-15 17:22 ` [alsa-devel] " Dong Aisheng 2011-07-12 18:22 ` [PATCH V2 00/10] Wolfram Sang 2011-07-12 18:22 ` Wolfram Sang 2011-07-13 3:02 ` [PATCH V2 00/10] ARM: mxs: add audio support Dong Aisheng-B29396 2011-07-13 3:02 ` Dong Aisheng-B29396 2011-07-13 3:36 ` [PATCH V2 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng 2011-07-13 3:36 ` Dong Aisheng 2011-07-13 9:13 ` Wolfram Sang 2011-07-13 9:13 ` Wolfram Sang 2011-07-13 9:56 ` Wolfram Sang 2011-07-13 9:56 ` Wolfram Sang 2011-07-13 11:09 ` Dong Aisheng-B29396 2011-07-13 11:09 ` Dong Aisheng-B29396 2011-07-13 3:39 ` [PATCH V2 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng 2011-07-13 3:39 ` Dong Aisheng 2011-07-13 3:40 ` [PATCH V2 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng 2011-07-13 3:40 ` Dong Aisheng 2011-07-13 3:40 ` [PATCH V2 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Dong Aisheng 2011-07-13 3:40 ` Dong Aisheng 2011-07-14 14:17 ` Wolfram Sang 2011-07-14 14:17 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110713074437.GF23270@n2100.arm.linux.org.uk \ --to=linux@arm.linux.org.uk \ --cc=alsa-devel@alsa-project.org \ --cc=b29396@freescale.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lrg@ti.com \ --cc=s.hauer@pengutronix.de \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.