From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Shawn Guo <shawn.guo@freescale.com> Cc: alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, s.hauer@pengutronix.de, Grant Likely <grant.likely@secretlab.ca>, u.kleine-koenig@pengutronix.de, Dong Aisheng <b29396@freescale.com>, lrg@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Date: Sat, 16 Jul 2011 00:17:13 +0900 [thread overview] Message-ID: <20110715151706.GD11154@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20110715151104.GE1840@S2100-06.ap.freescale.net> On Fri, Jul 15, 2011 at 11:11:06PM +0800, Shawn Guo wrote: > Currently, soc-core requires machine driver register snd_soc_dai_link > with proper codec, cpu_dai and platform device name coded, so that it > can match/bind dai link. It works for existing non-dt devices probe, > because they can have static device id assigned by platform code to > map the actual hardware instance. There's existing device tree code for PowerPC which seems to figure this out by doing a DT lookup in the machine driver which appears to be sane enough. If we can't look up a struct device via the device tree we'd seem to have a fairly serious problem as struct devices are how we talk about devices at runtime in general. To be honest I've not paid too much attention to the device tree code people are currently using since discussion around it has always involved repeatedly going over all the reasons why we actually need machine drivers and that gets tedious after a while. > Actually, I found matching cpu_dai using name does not scale in imx-ssi > case even for non-dt probe. imx provides some flexibility on the > connection between codec and ssi. With proper audmux configuration, > codec can be connected to either ssi.0 or ssi.1 for given board design. > That said even for given board, .cpu_dai_name can be dynamic. This is > something the current soc-core matching/binding approach hates to see. This isn't a scalability thing and it's not related to binding, it's because the AUXMUX isn't properly represented as a driver. It probably wants to be moved over to use the soc-dsp stuff Liam's doing at the minute. Currently we don't tell the core about the AUDMUX at all so it's unreasonable to expect it to do anything except a static route.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Date: Sat, 16 Jul 2011 00:17:13 +0900 [thread overview] Message-ID: <20110715151706.GD11154@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20110715151104.GE1840@S2100-06.ap.freescale.net> On Fri, Jul 15, 2011 at 11:11:06PM +0800, Shawn Guo wrote: > Currently, soc-core requires machine driver register snd_soc_dai_link > with proper codec, cpu_dai and platform device name coded, so that it > can match/bind dai link. It works for existing non-dt devices probe, > because they can have static device id assigned by platform code to > map the actual hardware instance. There's existing device tree code for PowerPC which seems to figure this out by doing a DT lookup in the machine driver which appears to be sane enough. If we can't look up a struct device via the device tree we'd seem to have a fairly serious problem as struct devices are how we talk about devices at runtime in general. To be honest I've not paid too much attention to the device tree code people are currently using since discussion around it has always involved repeatedly going over all the reasons why we actually need machine drivers and that gets tedious after a while. > Actually, I found matching cpu_dai using name does not scale in imx-ssi > case even for non-dt probe. imx provides some flexibility on the > connection between codec and ssi. With proper audmux configuration, > codec can be connected to either ssi.0 or ssi.1 for given board design. > That said even for given board, .cpu_dai_name can be dynamic. This is > something the current soc-core matching/binding approach hates to see. This isn't a scalability thing and it's not related to binding, it's because the AUXMUX isn't properly represented as a driver. It probably wants to be moved over to use the soc-dsp stuff Liam's doing at the minute. Currently we don't tell the core about the AUDMUX at all so it's unreasonable to expect it to do anything except a static route.
next prev parent reply other threads:[~2011-07-15 15:17 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-12 15:04 [PATCH V2 00/10] Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 23:27 ` Mark Brown 2011-07-12 23:27 ` Mark Brown 2011-07-13 3:20 ` Dong Aisheng-B29396 2011-07-13 3:20 ` Dong Aisheng-B29396 2011-07-13 6:29 ` Dong Aisheng-B29396 2011-07-13 6:29 ` Dong Aisheng-B29396 2011-07-13 7:44 ` Russell King - ARM Linux 2011-07-13 7:44 ` Russell King - ARM Linux 2011-07-13 8:17 ` Dong Aisheng-B29396 2011-07-13 8:17 ` Dong Aisheng-B29396 2011-07-14 12:31 ` Wolfram Sang 2011-07-14 12:31 ` Wolfram Sang 2011-07-14 16:15 ` Dong Aisheng 2011-07-14 16:15 ` [alsa-devel] " Dong Aisheng 2011-07-15 6:30 ` Dong Aisheng-B29396 2011-07-15 6:30 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-12 15:04 ` [PATCH V2 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 1:03 ` Mark Brown 2011-07-13 1:03 ` Mark Brown 2011-07-13 8:14 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-13 8:14 ` Dong Aisheng-B29396 2011-07-14 3:06 ` Mark Brown 2011-07-14 3:06 ` Mark Brown 2011-07-14 4:34 ` Dong Aisheng-B29396 2011-07-14 4:34 ` Dong Aisheng-B29396 2011-07-14 10:39 ` Dong Aisheng-B29396 2011-07-14 10:39 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-14 11:05 ` Mark Brown 2011-07-14 11:05 ` [alsa-devel] " Mark Brown 2011-07-14 16:06 ` Dong Aisheng 2011-07-14 16:06 ` [alsa-devel] " Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 11:57 ` Wolfram Sang 2011-07-13 11:57 ` Wolfram Sang 2011-07-13 12:19 ` Dong Aisheng-B29396 2011-07-13 12:19 ` Dong Aisheng-B29396 2011-07-13 13:40 ` Dong Aisheng-B29396 2011-07-13 13:40 ` Dong Aisheng-B29396 2011-07-13 14:00 ` Wolfram Sang 2011-07-13 14:00 ` Wolfram Sang 2011-07-13 14:13 ` Dong Aisheng-B29396 2011-07-13 14:13 ` Dong Aisheng-B29396 2011-07-13 14:22 ` Dong Aisheng-B29396 2011-07-13 14:22 ` Dong Aisheng-B29396 2011-07-13 15:01 ` Wolfram Sang 2011-07-13 15:01 ` Wolfram Sang 2011-07-13 15:16 ` Dong Aisheng 2011-07-13 15:16 ` Dong Aisheng 2011-07-13 12:46 ` Mark Brown 2011-07-13 12:46 ` Mark Brown 2011-07-13 12:59 ` Wolfram Sang 2011-07-13 12:59 ` Wolfram Sang 2011-07-13 15:58 ` Wolfram Sang 2011-07-13 15:58 ` Wolfram Sang 2011-07-14 3:04 ` [alsa-devel] " Dong Aisheng-B29396 2011-07-14 3:04 ` Dong Aisheng-B29396 [not found] ` <1310483085-31442-4-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org> 2011-07-15 15:11 ` Shawn Guo 2011-07-15 15:11 ` Shawn Guo 2011-07-15 15:17 ` Mark Brown [this message] 2011-07-15 15:17 ` Mark Brown 2011-07-12 15:04 ` [PATCH V2 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-13 9:08 ` Wolfram Sang 2011-07-13 9:08 ` Wolfram Sang 2011-07-13 11:13 ` Dong Aisheng 2011-07-13 11:13 ` [alsa-devel] " Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 05/10] ARM: mxs: add saif clock Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-12 15:04 ` [PATCH V2 06/10] ARM: mxs: add saif device Dong Aisheng 2011-07-12 15:04 ` Dong Aisheng 2011-07-15 13:32 ` Wolfram Sang 2011-07-15 13:32 ` Wolfram Sang 2011-07-15 15:02 ` Dong Aisheng 2011-07-15 15:02 ` [alsa-devel] " Dong Aisheng 2011-07-15 15:34 ` Wolfram Sang 2011-07-15 15:34 ` [alsa-devel] " Wolfram Sang 2011-07-15 17:22 ` Dong Aisheng 2011-07-15 17:22 ` [alsa-devel] " Dong Aisheng 2011-07-12 18:22 ` [PATCH V2 00/10] Wolfram Sang 2011-07-12 18:22 ` Wolfram Sang 2011-07-13 3:02 ` [PATCH V2 00/10] ARM: mxs: add audio support Dong Aisheng-B29396 2011-07-13 3:02 ` Dong Aisheng-B29396 2011-07-13 3:36 ` [PATCH V2 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng 2011-07-13 3:36 ` Dong Aisheng 2011-07-13 9:13 ` Wolfram Sang 2011-07-13 9:13 ` Wolfram Sang 2011-07-13 9:56 ` Wolfram Sang 2011-07-13 9:56 ` Wolfram Sang 2011-07-13 11:09 ` Dong Aisheng-B29396 2011-07-13 11:09 ` Dong Aisheng-B29396 2011-07-13 3:39 ` [PATCH V2 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng 2011-07-13 3:39 ` Dong Aisheng 2011-07-13 3:40 ` [PATCH V2 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng 2011-07-13 3:40 ` Dong Aisheng 2011-07-13 3:40 ` [PATCH V2 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Dong Aisheng 2011-07-13 3:40 ` Dong Aisheng 2011-07-14 14:17 ` Wolfram Sang 2011-07-14 14:17 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110715151706.GD11154@opensource.wolfsonmicro.com \ --to=broonie@opensource.wolfsonmicro.com \ --cc=alsa-devel@alsa-project.org \ --cc=b29396@freescale.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lrg@ti.com \ --cc=s.hauer@pengutronix.de \ --cc=shawn.guo@freescale.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.