[RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[Christian Lamparter]

Minstrel HT tries very hard to establish a BA session with
each peer once there's some data on the way. However the
stack does not inform minstrel if an aggregation session
is already in place, so it keeps trying and wastes good
cycles in the tx status path.

[ 8149.946393] Open BA session requested for $AP tid 0
[ 8150.048765] Open BA session requested for $AP tid 0
[ 8150.174509] Open BA session requested for $AP tid 0
[ 8150.274376] Open BA session requested for $AP tid 0
...

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
Hm, this time without the HTML-part.
---
diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index 2158838..e19249b 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -452,7 +452,8 @@ minstrel_ht_tx_status(void *priv, struct ieee80211_supported_band *sband,
 
 	if (time_after(jiffies, mi->stats_update + (mp->update_interval / 2 * HZ) / 1000)) {
 		minstrel_ht_update_stats(mp, mi);
-		minstrel_aggr_check(mp, sta, skb);
+		if (!(info->flags & IEEE80211_TX_CTL_AMPDU))
+			minstrel_aggr_check(mp, sta, skb);
 	}
 }
 

Re: [RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[Felix Fietkau]

On 2011-09-03 9:06 AM, Christian Lamparter wrote:
> Minstrel HT tries very hard to establish a BA session with
> each peer once there's some data on the way. However the
> stack does not inform minstrel if an aggregation session
> is already in place, so it keeps trying and wastes good
> cycles in the tx status path.
>
> [ 8149.946393] Open BA session requested for $AP tid 0
> [ 8150.048765] Open BA session requested for $AP tid 0
> [ 8150.174509] Open BA session requested for $AP tid 0
> [ 8150.274376] Open BA session requested for $AP tid 0
> ...
>
> Signed-off-by: Christian Lamparter<chunkeey@googlemail.com>
Acked-by: Felix Fietkau <nbd@openwrt.org>

Re: [RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[Mohammed Shafi]

On Sat, Sep 3, 2011 at 12:36 PM, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> Minstrel HT tries very hard to establish a BA session with
> each peer once there's some data on the way. However the
> stack does not inform minstrel if an aggregation session
> is already in place, so it keeps trying and wastes good
> cycles in the tx status path.
>
> [ 8149.946393] Open BA session requested for $AP tid 0
> [ 8150.048765] Open BA session requested for $AP tid 0
> [ 8150.174509] Open BA session requested for $AP tid 0
> [ 8150.274376] Open BA session requested for $AP tid 0
> ...


Hi Christian,

I got this messages in ath9k after few cycles of suspend and resume.
doing the same fix in ath9k rate control tx_status callback the
messages did not re-appear. I will soon send a proper patch for ath9k
too.

thanks,
shafi

Re: [RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[Christian Lamparter]

On Monday, September 05, 2011 05:20:09 PM Mohammed Shafi wrote:
> On Sat, Sep 3, 2011 at 12:36 PM, Christian Lamparter
> <chunkeey@googlemail.com> wrote:
> > Minstrel HT tries very hard to establish a BA session with
> > each peer once there's some data on the way. However the
> > stack does not inform minstrel if an aggregation session
> > is already in place, so it keeps trying and wastes good
> > cycles in the tx status path.
> >
> > [ 8149.946393] Open BA session requested for $AP tid 0
> > [ 8150.048765] Open BA session requested for $AP tid 0
> > [ 8150.174509] Open BA session requested for $AP tid 0
> > [ 8150.274376] Open BA session requested for $AP tid 0
> > ...
> 
> 
> Hi Christian,
> 
> I got this messages in ath9k after few cycles of suspend and resume.
There's nothing wrong with the message... as long as its reasonable
and does not spam the logs as in my case [had about 100k entries].

> doing the same fix in ath9k rate control tx_status callback the
> messages did not re-appear. I will soon send a proper patch for ath9k
> too.
Well, ath9k's rc works different than minstrel_ht. In fact that check
is not needed as ath9k's rc can check the tid state directly in
ath_tx_aggr_check [which I think it already does... unless something
is wrong with the txtid->state check?!].

Regards,
	Chr

Re: [RESEND][PATCH] minstrel_ht: fix Open BA session request floods

[Mohammed Shafi]

On Tue, Sep 6, 2011 at 9:39 AM, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> On Monday, September 05, 2011 05:20:09 PM Mohammed Shafi wrote:
>> On Sat, Sep 3, 2011 at 12:36 PM, Christian Lamparter
>> <chunkeey@googlemail.com> wrote:
>> > Minstrel HT tries very hard to establish a BA session with
>> > each peer once there's some data on the way. However the
>> > stack does not inform minstrel if an aggregation session
>> > is already in place, so it keeps trying and wastes good
>> > cycles in the tx status path.
>> >
>> > [ 8149.946393] Open BA session requested for $AP tid 0
>> > [ 8150.048765] Open BA session requested for $AP tid 0
>> > [ 8150.174509] Open BA session requested for $AP tid 0
>> > [ 8150.274376] Open BA session requested for $AP tid 0
>> > ...
>>
>>
>> Hi Christian,
>>
>> I got this messages in ath9k after few cycles of suspend and resume.
> There's nothing wrong with the message... as long as its reasonable
> and does not spam the logs as in my case [had about 100k entries].

indeed, it spam's the log.

>
>> doing the same fix in ath9k rate control tx_status callback the
>> messages did not re-appear. I will soon send a proper patch for ath9k
>> too.
> Well, ath9k's rc works different than minstrel_ht. In fact that check
> is not needed as ath9k's rc can check the tid state directly in
> ath_tx_aggr_check [which I think it already does... unless something
> is wrong with the txtid->state check?!].

 thanks, i will check  into that.

thanks,
shafi