All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name.
Date: Wed, 7 Sep 2011 20:01:21 +0100	[thread overview]
Message-ID: <20110907190120.GA24703@sirena.org.uk> (raw)
In-Reply-To: <20110906120430.GO6619@n2100.arm.linux.org.uk>

On Tue, Sep 06, 2011 at 01:04:30PM +0100, Russell King - ARM Linux wrote:

> Pros to platform driver name:
> 1. Can re-use existing names if feature compatible without driver mods.
> 2. Scales well with an increasing number of SoCs.

> Cons:
> 1. People will hate having SoC names which don't refer to their exact SoC.
> 2. Probably requires storage of a set of flags in driver private data
>    to identify SoC specific features.
> 3. Requires additional string space to identify each driver name.

There's also an issue with actually getting the devices together to
register which causes fragility here.

> However, thinking about this more wrt DT, there's another aspect to this.
> Rather than encoding into the driver "this SoC has features and quirks
> X,Y,Z" maybe that information should be in the device tree itself.  For
> example, SoC 1 has X and Z, SoC 2 has Y.  Then a new SoC 3 comes along
> with X and Y but not Z.  If X, Y, Z are encoded into DT then there's no
> need to touch the kernel to support SoC 3, not even to change driver
> names or soc_is_xxx macros etc.

This does depend pretty strongly on making sure that the SoC DT is
distributed separately to the board DT - that should be solved now.

  reply	other threads:[~2011-09-07 19:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 12:33 [PATCH 0/5] Add high resolution generic time support for S3C64xx Tomasz Figa
2011-08-31 12:34 ` [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name Tomasz Figa
2011-08-31 12:44   ` Mark Brown
2011-08-31 13:30     ` Tomasz Figa
2011-09-01  2:26       ` Kukjin Kim
2011-09-01  3:33         ` Kyungmin Park
2011-09-01 11:18           ` Tomasz Figa
2011-09-01 12:32             ` Mark Brown
2011-09-06 10:41             ` Tomasz Figa
2011-09-06 11:03               ` Russell King - ARM Linux
2011-09-06 11:35                 ` Tomasz Figa
2011-09-06 12:04                   ` Russell King - ARM Linux
2011-09-07 19:01                     ` Mark Brown [this message]
2011-10-10  9:58                       ` Kukjin Kim
2011-08-31 12:34 ` [PATCH 2/5] ARM: s3c64xx: Add generic high resolution time support using PWM timers Tomasz Figa
2011-10-10  9:57   ` Kukjin Kim
2011-10-11 13:32     ` Tomasz Figa
2011-10-13 14:22   ` Russell King - ARM Linux
2011-08-31 12:35 ` [PATCH 3/5] ARM: Samsung: pwm: Exclude timer 3 on S3C64xx if generic time is enabled Tomasz Figa
2011-08-31 12:35 ` [PATCH 4/5] ARM: s3c64xx: Move all machines to s3c64xx_timer Tomasz Figa
2011-08-31 12:36 ` [PATCH 5/5] ARM: s3c64xx: Add optional local sched_clock implementation Tomasz Figa
  -- strict thread matches above, loose matches on Subject: below --
2011-08-27 23:32 [PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110907190120.GA24703@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.