All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Alexander Graf <agraf@suse.de>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.
Date: Tue, 27 Sep 2011 18:20:43 +0300	[thread overview]
Message-ID: <20110927152041.GB13889@redhat.com> (raw)
In-Reply-To: <CAJJyHjK3ySHcHRC6eB2cPS=-=1JnqsWV4tXG0xDJgxpS2jG4=w@mail.gmail.com>

On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote:
> Hi,
> 
> I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we
> use libpci, and it's not friendly with pci_regs.h.
> 
> So can I replace pci_regs by the libpci one?

I prefer sticking to pci_regs in linux.

> Should I avoid to include both? (by having a "hook" the libpci functions)
> Or do you have any other suggestions?
> 
> Thanks,
> Regards,

Can you avoid libpci? It was very useful before sysfs, but
on modern systems there isn't much that it does.

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Alexander Graf <agraf@suse.de>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.
Date: Tue, 27 Sep 2011 18:20:43 +0300	[thread overview]
Message-ID: <20110927152041.GB13889@redhat.com> (raw)
In-Reply-To: <CAJJyHjK3ySHcHRC6eB2cPS=-=1JnqsWV4tXG0xDJgxpS2jG4=w@mail.gmail.com>

On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote:
> Hi,
> 
> I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we
> use libpci, and it's not friendly with pci_regs.h.
> 
> So can I replace pci_regs by the libpci one?

I prefer sticking to pci_regs in linux.

> Should I avoid to include both? (by having a "hook" the libpci functions)
> Or do you have any other suggestions?
> 
> Thanks,
> Regards,

Can you avoid libpci? It was very useful before sysfs, but
on modern systems there isn't much that it does.

-- 
MST

  reply	other threads:[~2011-09-27 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 15:02 [Qemu-devel] Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci Anthony PERARD
2011-09-27 15:02 ` Anthony PERARD
2011-09-27 15:20 ` Michael S. Tsirkin [this message]
2011-09-27 15:20   ` Michael S. Tsirkin
2011-09-27 16:14   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2011-09-27 16:14     ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110927152041.GB13889@redhat.com \
    --to=mst@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.