From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Jean Pihet <jean.pihet@newoldbits.com> Cc: Linux PM mailing list <linux-pm@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Linux-sh list <linux-sh@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Kevin Hilman <khilman@ti.com>, Ming Lei <tom.leiming@gmail.com> Subject: Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2) Date: Fri, 30 Sep 2011 16:46:41 +0000 [thread overview] Message-ID: <201109301846.41364.rjw@sisk.pl> (raw) In-Reply-To: <CAORVsuV4ccJvJg-zCrhVXJKmHkEYLLQh032=BMh7qH27bTK5uQ@mail.gmail.com> On Friday, September 30, 2011, Jean Pihet wrote: > Hi Rafael, > > On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > Hi, > > > > On Thursday, September 29, 2011, Jean Pihet wrote: > >> Hi Rafael, > >> > >> I have a few minor remarks, inlined below. > > > > In the meantime it turned out that the patch caused a build failure > > for CONFIG_PM_SLEEP unset (your original patches won't really work > > in this case too), so I posted a patch to fix it. However, since > > you had remarks anyway, I've simply folded the fix into the next > > version of the $subject patch, which is appended. > OK to me. > > I have 2 remarks though: > - some drivers are using the power_state field in the suspend/resume > operation, IIUC without conflict. Can you confirm? Yes, I can. There are no conflicts. > - the power_state field is scheduled for removal, cf. > Documentation/feature-removal-schedule.txt. That does not look > correct. It still is schediled for removal, but we can't remove it right now anyway because of the users mentioned above. I'll replace this field with a one-bit flag when we're ready to drop it (some time in future). Thanks, Rafael
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Jean Pihet <jean.pihet@newoldbits.com> Cc: Linux PM mailing list <linux-pm@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, "Linux-sh list" <linux-sh@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Kevin Hilman <khilman@ti.com>, Ming Lei <tom.leiming@gmail.com> Subject: Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2) Date: Fri, 30 Sep 2011 18:46:41 +0200 [thread overview] Message-ID: <201109301846.41364.rjw@sisk.pl> (raw) In-Reply-To: <CAORVsuV4ccJvJg-zCrhVXJKmHkEYLLQh032=BMh7qH27bTK5uQ@mail.gmail.com> On Friday, September 30, 2011, Jean Pihet wrote: > Hi Rafael, > > On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > Hi, > > > > On Thursday, September 29, 2011, Jean Pihet wrote: > >> Hi Rafael, > >> > >> I have a few minor remarks, inlined below. > > > > In the meantime it turned out that the patch caused a build failure > > for CONFIG_PM_SLEEP unset (your original patches won't really work > > in this case too), so I posted a patch to fix it. However, since > > you had remarks anyway, I've simply folded the fix into the next > > version of the $subject patch, which is appended. > OK to me. > > I have 2 remarks though: > - some drivers are using the power_state field in the suspend/resume > operation, IIUC without conflict. Can you confirm? Yes, I can. There are no conflicts. > - the power_state field is scheduled for removal, cf. > Documentation/feature-removal-schedule.txt. That does not look > correct. It still is schediled for removal, but we can't remove it right now anyway because of the users mentioned above. I'll replace this field with a one-bit flag when we're ready to drop it (some time in future). Thanks, Rafael
next prev parent reply other threads:[~2011-09-30 16:46 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-30 22:17 [PATCH 0/5] PM: Generic PM domains and device PM QoS Rafael J. Wysocki 2011-08-30 22:17 ` Rafael J. Wysocki 2011-08-30 22:18 ` [PATCH 1/5] PM / Domains: Split device PM domain data into base and need_restore Rafael J. Wysocki 2011-08-30 22:18 ` Rafael J. Wysocki 2011-08-30 22:18 ` Rafael J. Wysocki 2011-08-30 22:20 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for power.irq_safe set Rafael J. Wysocki 2011-08-30 22:20 ` Rafael J. Wysocki 2011-09-12 8:26 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for Ming Lei 2011-09-12 8:26 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for power.irq_safe set Ming Lei 2011-09-12 21:52 ` Rafael J. Wysocki 2011-09-12 21:52 ` Rafael J. Wysocki [not found] ` <201109122344.02386.rjw@sisk.pl> 2011-09-13 1:22 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for Ming Lei 2011-09-13 1:22 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for power.irq_safe set Ming Lei 2011-09-13 16:06 ` Rafael J. Wysocki 2011-09-13 16:06 ` Rafael J. Wysocki 2011-09-14 1:12 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for Ming Lei 2011-09-14 1:12 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for power.irq_safe set Ming Lei 2011-09-14 20:45 ` Rafael J. Wysocki 2011-09-14 20:45 ` Rafael J. Wysocki 2011-09-15 10:55 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for Ming Lei 2011-09-15 10:55 ` [PATCH 2/5] PM / Runtime: Do not run callbacks under lock for power.irq_safe set Ming Lei 2011-08-30 22:20 ` Rafael J. Wysocki 2011-08-30 22:21 ` [PATCH 3/5] PM / QoS: Add function dev_pm_qos_read_value() Rafael J. Wysocki 2011-08-30 22:21 ` Rafael J. Wysocki 2011-08-30 22:21 ` Rafael J. Wysocki 2011-09-01 15:13 ` Jean Pihet 2011-09-01 15:13 ` Jean Pihet 2011-09-01 22:07 ` Rafael J. Wysocki 2011-09-01 22:07 ` Rafael J. Wysocki 2011-09-01 22:07 ` Rafael J. Wysocki 2011-09-02 6:49 ` Jean Pihet 2011-09-02 6:49 ` Jean Pihet 2011-09-02 6:49 ` Jean Pihet 2011-09-02 23:55 ` Rafael J. Wysocki 2011-09-02 23:55 ` Rafael J. Wysocki 2011-09-02 23:55 ` Rafael J. Wysocki 2011-09-03 8:02 ` Rafael J. Wysocki 2011-09-03 8:02 ` Rafael J. Wysocki 2011-09-05 7:51 ` Jean Pihet 2011-09-05 7:51 ` Jean Pihet 2011-09-05 7:51 ` Jean Pihet 2011-09-05 15:30 ` Rafael J. Wysocki 2011-09-05 15:30 ` Rafael J. Wysocki 2011-09-05 15:30 ` Rafael J. Wysocki 2011-09-03 8:02 ` Rafael J. Wysocki 2011-09-05 7:44 ` Jean Pihet 2011-09-05 7:44 ` Jean Pihet 2011-09-05 7:44 ` Jean Pihet 2011-09-01 15:13 ` Jean Pihet 2011-08-30 22:21 ` [RFC][PATCH 4/5] PM / Domains: Add device stop governor function Rafael J. Wysocki 2011-08-30 22:21 ` Rafael J. Wysocki 2011-08-30 22:21 ` Rafael J. Wysocki 2011-08-30 22:22 ` [RFC][PATCH 5/5] PM / Domains: Add default power off " Rafael J. Wysocki 2011-08-30 22:22 ` Rafael J. Wysocki 2011-08-30 22:22 ` Rafael J. Wysocki 2011-09-01 15:17 ` Jean Pihet 2011-09-01 15:17 ` Jean Pihet 2011-09-01 15:17 ` Jean Pihet 2011-09-01 22:11 ` Rafael J. Wysocki 2011-09-01 22:11 ` Rafael J. Wysocki 2011-09-01 22:11 ` Rafael J. Wysocki 2011-09-01 15:28 ` [PATCH 0/5] PM: Generic PM domains and device PM QoS Jean Pihet 2011-09-01 15:28 ` Jean Pihet 2011-09-01 22:14 ` Rafael J. Wysocki 2011-09-01 22:14 ` Rafael J. Wysocki 2011-09-01 22:14 ` Rafael J. Wysocki 2011-09-01 15:28 ` Jean Pihet 2011-09-24 21:23 ` [PATCH 0/3] PM: Runtime PM and device PM QoS refinements Rafael J. Wysocki 2011-09-24 21:23 ` Rafael J. Wysocki 2011-09-24 21:24 ` [PATCH 1/3] PM / Domains: Split device PM domain data into base and need_restore Rafael J. Wysocki 2011-09-24 21:24 ` Rafael J. Wysocki 2011-09-24 21:25 ` [PATCH 2/3] PM / Runtime: Don't run callbacks under lock for power.irq_safe set Rafael J. Wysocki 2011-09-24 21:25 ` Rafael J. Wysocki 2011-09-25 8:24 ` [PATCH 2/3] PM / Runtime: Don't run callbacks under lock for Ming Lei 2011-09-25 8:24 ` [PATCH 2/3] PM / Runtime: Don't run callbacks under lock for power.irq_safe set Ming Lei 2011-09-26 23:59 ` Kevin Hilman 2011-09-26 23:59 ` Kevin Hilman 2011-09-27 17:16 ` Rafael J. Wysocki 2011-09-27 17:16 ` Rafael J. Wysocki 2011-09-27 19:50 ` Rafael J. Wysocki 2011-09-27 19:50 ` Rafael J. Wysocki 2011-09-29 0:17 ` Kevin Hilman 2011-09-29 0:17 ` Kevin Hilman 2011-09-24 21:26 ` [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2) Rafael J. Wysocki 2011-09-24 21:26 ` Rafael J. Wysocki 2011-09-29 8:11 ` Jean Pihet 2011-09-29 8:11 ` Jean Pihet 2011-09-29 20:33 ` Rafael J. Wysocki 2011-09-29 20:33 ` Rafael J. Wysocki 2011-09-30 8:08 ` Jean Pihet 2011-09-30 8:08 ` Jean Pihet 2011-09-30 16:46 ` Rafael J. Wysocki [this message] 2011-09-30 16:46 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201109301846.41364.rjw@sisk.pl \ --to=rjw@sisk.pl \ --cc=jean.pihet@newoldbits.com \ --cc=khilman@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=tom.leiming@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.