From: Tony Lindgren <tony@atomide.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence
Date: Tue, 4 Oct 2011 11:54:15 -0700 [thread overview]
Message-ID: <20111004185415.GV6324@atomide.com> (raw)
In-Reply-To: <1317750724-32553-2-git-send-email-vishwanath.bs@ti.com>
* Vishwanath BS <vishwanath.bs@ti.com> [111004 10:25]:
> @@ -105,7 +105,7 @@ static void omap3_enable_io_chain(void)
> /* Do a readback to assure write has been done */
> omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
>
> - while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN) &
> + while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> OMAP3430_ST_IO_CHAIN_MASK)) {
> timeout++;
> if (timeout > 1000) {
Checking for PM_WKST here makes sense..
> @@ -114,7 +114,7 @@ static void omap3_enable_io_chain(void)
> return;
> }
> omap2_prm_set_mod_reg_bits(OMAP3430_ST_IO_CHAIN_MASK,
> - WKUP_MOD, PM_WKEN);
> + WKUP_MOD, PM_WKST);
> }
> }
> }
..but are you sure you also want to write into PM_WKST?
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence
Date: Tue, 4 Oct 2011 11:54:15 -0700 [thread overview]
Message-ID: <20111004185415.GV6324@atomide.com> (raw)
In-Reply-To: <1317750724-32553-2-git-send-email-vishwanath.bs@ti.com>
* Vishwanath BS <vishwanath.bs@ti.com> [111004 10:25]:
> @@ -105,7 +105,7 @@ static void omap3_enable_io_chain(void)
> /* Do a readback to assure write has been done */
> omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
>
> - while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN) &
> + while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> OMAP3430_ST_IO_CHAIN_MASK)) {
> timeout++;
> if (timeout > 1000) {
Checking for PM_WKST here makes sense..
> @@ -114,7 +114,7 @@ static void omap3_enable_io_chain(void)
> return;
> }
> omap2_prm_set_mod_reg_bits(OMAP3430_ST_IO_CHAIN_MASK,
> - WKUP_MOD, PM_WKEN);
> + WKUP_MOD, PM_WKST);
> }
> }
> }
..but are you sure you also want to write into PM_WKST?
Tony
next prev parent reply other threads:[~2011-10-04 18:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 17:52 [PATCH 0/4] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 17:52 ` [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 18:54 ` Tony Lindgren [this message]
2011-10-04 18:54 ` Tony Lindgren
2011-10-04 20:47 ` Kevin Hilman
2011-10-04 20:47 ` Kevin Hilman
2011-10-05 4:19 ` Vishwanath Sripathy
2011-10-05 4:19 ` Vishwanath Sripathy
2011-10-07 8:19 ` Paul Walmsley
2011-10-07 8:19 ` Paul Walmsley
2011-10-07 10:04 ` Vishwanath Sripathy
2011-10-07 10:04 ` Vishwanath Sripathy
2011-10-04 17:52 ` [PATCH 2/4] ARM: OMAP4 PM: Add IO Daisychain support Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-07 8:13 ` Paul Walmsley
2011-10-07 8:13 ` Paul Walmsley
2011-10-07 10:03 ` Vishwanath Sripathy
2011-10-07 10:03 ` Vishwanath Sripathy
2011-10-04 17:52 ` [PATCH 3/4] ARM: OMAP3 PM: Enable IO Wake up Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
2011-10-04 17:52 ` [PATCH 4/4] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Vishwanath BS
2011-10-04 17:52 ` Vishwanath BS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004185415.GV6324@atomide.com \
--to=tony@atomide.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.