All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arend van Spriel <arend@broadcom.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: linux-next: build failure after merge of the moduleh tree
Date: Wed, 12 Oct 2011 17:29:54 +1100	[thread overview]
Message-ID: <20111012172954.4d5a638ef2a399b72bce5bf1@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 13894 bytes --]

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/wireless/brcm80211/brcmutil/utils.c:20:15: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmutil/utils.c:21:20: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmutil/utils.c:22:25: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmutil/utils.c:23:16: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmutil/utils.c:37:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:37:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:37:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:65:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:65:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:65:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:96:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:96:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:96:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:108:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:108:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:108:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:139:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:139:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:139:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:165:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:165:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:165:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:190:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:190:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:190:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:218:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:218:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:218:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:250:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:250:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:250:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:259:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:259:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:259:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:276:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:276:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:276:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:294:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:294:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:294:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:309:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:309:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:309:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:350:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:350:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:350:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:364:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:364:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:364:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:394:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:394:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:394:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:451:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:451:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:451:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:469:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:469:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:469:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:480:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:480:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:480:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:499:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:499:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:499:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:553:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:553:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:553:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:585:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:585:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:585:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:600:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/utils.c:600:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/utils.c:600:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c:47:15: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c:48:20: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c:49:25: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c:50:16: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c:80:31: error: expected ')' before 'int'
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3400:17: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:3401:17: error: expected declaration specifiers or '...' before string constant
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: parameter names (without types) in function declaration [enabled by default]

Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers")
from the wireless tree interacting with the module.h split up.

These files clearly should include module.h (John, please apply this to the
wireless tree):

From d89b14ffc84a2b8a54ffe89453b8bbf9cabf1468 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Oct 2011 17:07:06 +1100
Subject: [PATCH] net: wireless: brcm80211: include module.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---

diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
index 62bcc71..e96bdbf 100644
--- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
+++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
@@ -15,6 +15,7 @@
  */
 
 #include <linux/netdevice.h>
+#include <linux/module.h>
 #include <brcmu_utils.h>
 
 MODULE_AUTHOR("Broadcom Corporation");
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
index e919de2..bbaeb2d 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
@@ -23,6 +23,7 @@
 #include <linux/suspend.h>
 #include <linux/errno.h>
 #include <linux/sched.h>	/* request_irq() */
+#include <linux/module.h>
 #include <net/cfg80211.h>
 
 #include <defs.h>
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
index 03607ca..1adc3be 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
@@ -31,6 +31,7 @@
 #include <linux/hardirq.h>
 #include <linux/mutex.h>
 #include <linux/wait.h>
+#include <linux/module.h>
 #include <net/cfg80211.h>
 #include <net/rtnetlink.h>
 #include <defs.h>
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
index 6885755..bd9db48 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
@@ -27,6 +27,7 @@
 #include <linux/mmc/card.h>
 #include <linux/semaphore.h>
 #include <linux/firmware.h>
+#include <linux/module.h>
 #include <asm/unaligned.h>
 #include <defs.h>
 #include <brcmu_wifi.h>
-- 
1.7.6.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2011-10-12  6:30 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  6:29 Stephen Rothwell [this message]
2011-10-12 19:25 ` linux-next: build failure after merge of the moduleh tree Arend van Spriel
2011-10-12 19:26   ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2012-03-23  4:51 Stephen Rothwell
2012-03-23 12:49 ` Paul Gortmaker
2012-03-23 12:49   ` Paul Gortmaker
2012-03-23 13:03   ` Stephen Rothwell
2012-03-23 13:03     ` Stephen Rothwell
2011-11-01  7:38 Stephen Rothwell
2011-10-11  8:39 Stephen Rothwell
2011-10-11  8:25 Stephen Rothwell
2011-10-11 13:05 ` Mark Brown
2011-10-04  7:32 Stephen Rothwell
2011-10-04  7:21 Stephen Rothwell
2011-10-04 15:24 ` Jonathan Cameron
2011-10-04  7:11 Stephen Rothwell
2011-10-04  7:03 Stephen Rothwell
2011-10-04  7:35 ` Kalle Valo
2011-10-04  7:35   ` Kalle Valo
2011-10-04  8:14   ` Stephen Rothwell
2011-10-04  8:14     ` Stephen Rothwell
2011-10-04 15:09     ` Larry Finger
2011-09-30  4:50 Stephen Rothwell
2011-09-30 12:52 ` Linus Walleij
2011-09-30 13:19   ` Stephen Rothwell
2011-10-03  6:55     ` Linus Walleij
2011-09-30 18:56 ` Paul Gortmaker
2011-09-28  8:41 Stephen Rothwell
2011-09-28 13:42 ` Paul Gortmaker
2011-09-28 13:42   ` Paul Gortmaker
2011-09-29  0:15   ` Paul Gortmaker
2011-09-29  1:15     ` Stephen Rothwell
2011-09-28  8:35 Stephen Rothwell
2011-09-28  8:35 ` Stephen Rothwell
2011-09-28 16:42 ` Kalle Valo
2011-09-28 16:42   ` Kalle Valo
2011-09-28  8:25 Stephen Rothwell
2011-09-28  8:25 ` Stephen Rothwell
2011-09-28  8:18 Stephen Rothwell
2011-10-09  5:08 ` Paul Gortmaker
2011-10-09  5:08   ` Paul Gortmaker
2011-10-09 18:01   ` Chris Ball
2011-10-09 18:01     ` Chris Ball
2011-09-28  8:00 Stephen Rothwell
2011-09-28  7:50 Stephen Rothwell
2011-09-28  7:42 Stephen Rothwell
2011-09-28  7:58 ` Borislav Petkov
2011-09-28  7:10 Stephen Rothwell
2011-08-23  5:08 Stephen Rothwell
2011-08-23  9:59 ` Felipe Balbi
2011-09-02 18:32   ` Geert Uytterhoeven
2011-09-05 10:39     ` Felipe Balbi
2011-08-10  1:49 Stephen Rothwell
2011-08-03  4:16 Stephen Rothwell
2011-08-03 14:26 ` Greg KH
2011-08-03  4:10 Stephen Rothwell
2011-08-02  5:13 Stephen Rothwell
2011-08-02 10:15 ` Alasdair G Kergon
2011-08-01  3:58 Stephen Rothwell
2011-07-29  7:09 Stephen Rothwell
2011-07-31  6:59 ` Paul Gortmaker
2011-07-31  6:59   ` Paul Gortmaker
2011-07-29  7:06 Stephen Rothwell
2011-07-31  7:44 ` Paul Gortmaker
2011-07-31  7:44   ` Paul Gortmaker
2011-08-01  0:30   ` Stephen Rothwell
2011-08-01  0:30     ` Stephen Rothwell
2011-07-29  6:48 Stephen Rothwell
2011-07-31  7:30 ` Paul Gortmaker
2011-07-31  7:30   ` Paul Gortmaker
2011-07-29  6:24 Stephen Rothwell
2011-07-31  7:26 ` Paul Gortmaker
2011-07-31  7:26   ` Paul Gortmaker
2011-07-29  6:19 Stephen Rothwell
2011-07-31  8:08 ` Paul Gortmaker
2011-07-31  8:08   ` Paul Gortmaker
2011-07-29  5:41 Stephen Rothwell
2011-07-29  5:30 Stephen Rothwell
2011-07-29  5:25 Stephen Rothwell
2011-07-29  5:37 ` Stephen Rothwell
2011-07-31  6:31   ` Paul Gortmaker
2011-07-31  6:31     ` Paul Gortmaker
2011-07-31  8:14 ` Paul Gortmaker
2011-07-31  8:14   ` Paul Gortmaker
2011-07-29  5:10 Stephen Rothwell
2011-07-30 19:03 ` Dmitry Torokhov
2011-07-29  5:10 Stephen Rothwell
2011-07-31  4:45 ` Paul Gortmaker
2011-07-31  4:45   ` Paul Gortmaker
2011-07-29  4:56 Stephen Rothwell
2011-07-31  5:44 ` Paul Gortmaker
2011-07-31  5:44   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012172954.4d5a638ef2a399b72bce5bf1@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=arend@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.