From: Paul Gortmaker <paul.gortmaker@windriver.com> To: Chris Ball <cjb@laptop.org> Cc: <linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Per Forlin <per.forlin@linaro.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Akinobu Mita <akinobu.mita@gmail.com> Subject: Re: linux-next: build failure after merge of the moduleh tree Date: Sun, 9 Oct 2011 01:08:09 -0400 [thread overview] Message-ID: <20111009050809.GS19986@windriver.com> (raw) In-Reply-To: <20110928181815.45f540034ddde2b206fc4e57@canb.auug.org.au> [linux-next: build failure after merge of the moduleh tree] On 28/09/2011 (Wed 18:18) Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant > > Caused by commit b5a62f8be3af ("mmc: add module param to set fault > injection attributes") from the mmc tree interacting with the module.h > split up. > > I have applied the patch below for today (something similar could be > applied to the mmc tree). Hi Chris, I was wondering if you were going to apply this to the mmc tree. Since the module_param addition isn't in the module.h baseline, I'd be speculatively fixing an issue that hasn't been created yet, which isn't the end of the world, but it doesn't feel quite right to do that either. If it is in the mmc tree, then the include fix will be guaranteed to be present wherever the module_param usage is present. Thanks, Paul. >From 00812c67db3d0ade3571684191781d866293f1ba Mon Sep 17 00:00:00 2001 From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 28 Sep 2011 18:09:12 +1000 Subject: [PATCH] mmc: using module_param requires the inclusion of moduleparam.h Commit "mmc: add module param to set fault injection attributes" adds a module_param to this file. But it is relying on the old implicit "module.h is everywhere" behaviour, and without the explicit include of moduleparam.h, the pending module.h split up produces this error: drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 0a1e7cf..65138e0 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -7,6 +7,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include <linux/moduleparam.h> #include <linux/debugfs.h> #include <linux/fs.h> #include <linux/export.h> -- 1.7.6
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com> To: Chris Ball <cjb@laptop.org> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Per Forlin <per.forlin@linaro.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Akinobu Mita <akinobu.mita@gmail.com> Subject: Re: linux-next: build failure after merge of the moduleh tree Date: Sun, 9 Oct 2011 01:08:09 -0400 [thread overview] Message-ID: <20111009050809.GS19986@windriver.com> (raw) In-Reply-To: <20110928181815.45f540034ddde2b206fc4e57@canb.auug.org.au> [linux-next: build failure after merge of the moduleh tree] On 28/09/2011 (Wed 18:18) Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant > > Caused by commit b5a62f8be3af ("mmc: add module param to set fault > injection attributes") from the mmc tree interacting with the module.h > split up. > > I have applied the patch below for today (something similar could be > applied to the mmc tree). Hi Chris, I was wondering if you were going to apply this to the mmc tree. Since the module_param addition isn't in the module.h baseline, I'd be speculatively fixing an issue that hasn't been created yet, which isn't the end of the world, but it doesn't feel quite right to do that either. If it is in the mmc tree, then the include fix will be guaranteed to be present wherever the module_param usage is present. Thanks, Paul. >From 00812c67db3d0ade3571684191781d866293f1ba Mon Sep 17 00:00:00 2001 From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 28 Sep 2011 18:09:12 +1000 Subject: [PATCH] mmc: using module_param requires the inclusion of moduleparam.h Commit "mmc: add module param to set fault injection attributes" adds a module_param to this file. But it is relying on the old implicit "module.h is everywhere" behaviour, and without the explicit include of moduleparam.h, the pending module.h split up produces this error: drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 0a1e7cf..65138e0 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -7,6 +7,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include <linux/moduleparam.h> #include <linux/debugfs.h> #include <linux/fs.h> #include <linux/export.h> -- 1.7.6
next prev parent reply other threads:[~2011-10-09 5:08 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-28 8:18 linux-next: build failure after merge of the moduleh tree Stephen Rothwell 2011-10-09 5:08 ` Paul Gortmaker [this message] 2011-10-09 5:08 ` Paul Gortmaker 2011-10-09 18:01 ` Chris Ball 2011-10-09 18:01 ` Chris Ball -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 4:51 Stephen Rothwell 2012-03-23 12:49 ` Paul Gortmaker 2012-03-23 12:49 ` Paul Gortmaker 2012-03-23 13:03 ` Stephen Rothwell 2012-03-23 13:03 ` Stephen Rothwell 2011-11-01 7:38 Stephen Rothwell 2011-10-12 6:29 Stephen Rothwell 2011-10-12 19:25 ` Arend van Spriel 2011-10-12 19:26 ` John W. Linville 2011-10-11 8:39 Stephen Rothwell 2011-10-11 8:25 Stephen Rothwell 2011-10-11 13:05 ` Mark Brown 2011-10-04 7:32 Stephen Rothwell 2011-10-04 7:21 Stephen Rothwell 2011-10-04 15:24 ` Jonathan Cameron 2011-10-04 7:11 Stephen Rothwell 2011-10-04 7:03 Stephen Rothwell 2011-10-04 7:35 ` Kalle Valo 2011-10-04 7:35 ` Kalle Valo 2011-10-04 8:14 ` Stephen Rothwell 2011-10-04 8:14 ` Stephen Rothwell 2011-10-04 15:09 ` Larry Finger 2011-09-30 4:50 Stephen Rothwell 2011-09-30 12:52 ` Linus Walleij 2011-09-30 13:19 ` Stephen Rothwell 2011-10-03 6:55 ` Linus Walleij 2011-09-30 18:56 ` Paul Gortmaker 2011-09-28 8:41 Stephen Rothwell 2011-09-28 13:42 ` Paul Gortmaker 2011-09-28 13:42 ` Paul Gortmaker 2011-09-29 0:15 ` Paul Gortmaker 2011-09-29 1:15 ` Stephen Rothwell 2011-09-28 8:35 Stephen Rothwell 2011-09-28 8:35 ` Stephen Rothwell 2011-09-28 16:42 ` Kalle Valo 2011-09-28 16:42 ` Kalle Valo 2011-09-28 8:25 Stephen Rothwell 2011-09-28 8:25 ` Stephen Rothwell 2011-09-28 8:00 Stephen Rothwell 2011-09-28 7:50 Stephen Rothwell 2011-09-28 7:42 Stephen Rothwell 2011-09-28 7:58 ` Borislav Petkov 2011-09-28 7:10 Stephen Rothwell 2011-08-23 5:08 Stephen Rothwell 2011-08-23 9:59 ` Felipe Balbi 2011-09-02 18:32 ` Geert Uytterhoeven 2011-09-05 10:39 ` Felipe Balbi 2011-08-10 1:49 Stephen Rothwell 2011-08-03 4:16 Stephen Rothwell 2011-08-03 14:26 ` Greg KH 2011-08-03 4:10 Stephen Rothwell 2011-08-02 5:13 Stephen Rothwell 2011-08-02 10:15 ` Alasdair G Kergon 2011-08-01 3:58 Stephen Rothwell 2011-07-29 7:09 Stephen Rothwell 2011-07-31 6:59 ` Paul Gortmaker 2011-07-31 6:59 ` Paul Gortmaker 2011-07-29 7:06 Stephen Rothwell 2011-07-31 7:44 ` Paul Gortmaker 2011-07-31 7:44 ` Paul Gortmaker 2011-08-01 0:30 ` Stephen Rothwell 2011-08-01 0:30 ` Stephen Rothwell 2011-07-29 6:48 Stephen Rothwell 2011-07-31 7:30 ` Paul Gortmaker 2011-07-31 7:30 ` Paul Gortmaker 2011-07-29 6:24 Stephen Rothwell 2011-07-31 7:26 ` Paul Gortmaker 2011-07-31 7:26 ` Paul Gortmaker 2011-07-29 6:19 Stephen Rothwell 2011-07-31 8:08 ` Paul Gortmaker 2011-07-31 8:08 ` Paul Gortmaker 2011-07-29 5:41 Stephen Rothwell 2011-07-29 5:30 Stephen Rothwell 2011-07-29 5:25 Stephen Rothwell 2011-07-29 5:37 ` Stephen Rothwell 2011-07-31 6:31 ` Paul Gortmaker 2011-07-31 6:31 ` Paul Gortmaker 2011-07-31 8:14 ` Paul Gortmaker 2011-07-31 8:14 ` Paul Gortmaker 2011-07-29 5:10 Stephen Rothwell 2011-07-30 19:03 ` Dmitry Torokhov 2011-07-29 5:10 Stephen Rothwell 2011-07-31 4:45 ` Paul Gortmaker 2011-07-31 4:45 ` Paul Gortmaker 2011-07-29 4:56 Stephen Rothwell 2011-07-31 5:44 ` Paul Gortmaker 2011-07-31 5:44 ` Paul Gortmaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111009050809.GS19986@windriver.com \ --to=paul.gortmaker@windriver.com \ --cc=akinobu.mita@gmail.com \ --cc=cjb@laptop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=per.forlin@linaro.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.