All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the moduleh tree
Date: Tue, 4 Oct 2011 10:35:29 +0300	[thread overview]
Message-ID: <4E8AB741.9030707@qca.qualcomm.com> (raw)
In-Reply-To: <20111004180333.44f741dc08063a918c9b581f@canb.auug.org.au>

On 10/04/2011 10:03 AM, Stephen Rothwell wrote:
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/net/wireless/ath/ath6kl/debug.c:237:11: error: 'THIS_MODULE' undeclared here (not in a function)
> 
> Caused by commit 9a7308341b71 ("ath6kl: silence "invalid rate" warning")
> from the wireless tree interacting with the module.h split.
> 
> I added this patch:

John&Paul, how do we handle this patch?

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 4 Oct 2011 18:01:03 +1100
> Subject: [PATCH] ath6kl: THIS_MODULES needs export.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/wireless/ath/ath6kl/debug.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> index ba3f23d..7879b53 100644
> --- a/drivers/net/wireless/ath/ath6kl/debug.c
> +++ b/drivers/net/wireless/ath/ath6kl/debug.c
> @@ -19,6 +19,7 @@
>  #include <linux/circ_buf.h>
>  #include <linux/fs.h>
>  #include <linux/vmalloc.h>
> +#include <linux/export.h>
>  
>  #include "debug.h"
>  #include "target.h"

Kalle

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the moduleh tree
Date: Tue, 4 Oct 2011 10:35:29 +0300	[thread overview]
Message-ID: <4E8AB741.9030707@qca.qualcomm.com> (raw)
In-Reply-To: <20111004180333.44f741dc08063a918c9b581f@canb.auug.org.au>

On 10/04/2011 10:03 AM, Stephen Rothwell wrote:
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/net/wireless/ath/ath6kl/debug.c:237:11: error: 'THIS_MODULE' undeclared here (not in a function)
> 
> Caused by commit 9a7308341b71 ("ath6kl: silence "invalid rate" warning")
> from the wireless tree interacting with the module.h split.
> 
> I added this patch:

John&Paul, how do we handle this patch?

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 4 Oct 2011 18:01:03 +1100
> Subject: [PATCH] ath6kl: THIS_MODULES needs export.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/wireless/ath/ath6kl/debug.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> index ba3f23d..7879b53 100644
> --- a/drivers/net/wireless/ath/ath6kl/debug.c
> +++ b/drivers/net/wireless/ath/ath6kl/debug.c
> @@ -19,6 +19,7 @@
>  #include <linux/circ_buf.h>
>  #include <linux/fs.h>
>  #include <linux/vmalloc.h>
> +#include <linux/export.h>
>  
>  #include "debug.h"
>  #include "target.h"

Kalle

  reply	other threads:[~2011-10-04  7:35 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04  7:03 linux-next: build failure after merge of the moduleh tree Stephen Rothwell
2011-10-04  7:35 ` Kalle Valo [this message]
2011-10-04  7:35   ` Kalle Valo
2011-10-04  8:14   ` Stephen Rothwell
2011-10-04  8:14     ` Stephen Rothwell
2011-10-04 15:09     ` Larry Finger
  -- strict thread matches above, loose matches on Subject: below --
2012-03-23  4:51 Stephen Rothwell
2012-03-23 12:49 ` Paul Gortmaker
2012-03-23 12:49   ` Paul Gortmaker
2012-03-23 13:03   ` Stephen Rothwell
2012-03-23 13:03     ` Stephen Rothwell
2011-11-01  7:38 Stephen Rothwell
2011-10-12  6:29 Stephen Rothwell
2011-10-12 19:25 ` Arend van Spriel
2011-10-12 19:26   ` John W. Linville
2011-10-11  8:39 Stephen Rothwell
2011-10-11  8:25 Stephen Rothwell
2011-10-11 13:05 ` Mark Brown
2011-10-04  7:32 Stephen Rothwell
2011-10-04  7:21 Stephen Rothwell
2011-10-04 15:24 ` Jonathan Cameron
2011-10-04  7:11 Stephen Rothwell
2011-09-30  4:50 Stephen Rothwell
2011-09-30 12:52 ` Linus Walleij
2011-09-30 13:19   ` Stephen Rothwell
2011-10-03  6:55     ` Linus Walleij
2011-09-30 18:56 ` Paul Gortmaker
2011-09-28  8:41 Stephen Rothwell
2011-09-28 13:42 ` Paul Gortmaker
2011-09-28 13:42   ` Paul Gortmaker
2011-09-29  0:15   ` Paul Gortmaker
2011-09-29  1:15     ` Stephen Rothwell
2011-09-28  8:35 Stephen Rothwell
2011-09-28  8:35 ` Stephen Rothwell
2011-09-28 16:42 ` Kalle Valo
2011-09-28 16:42   ` Kalle Valo
2011-09-28  8:25 Stephen Rothwell
2011-09-28  8:25 ` Stephen Rothwell
2011-09-28  8:18 Stephen Rothwell
2011-10-09  5:08 ` Paul Gortmaker
2011-10-09  5:08   ` Paul Gortmaker
2011-10-09 18:01   ` Chris Ball
2011-10-09 18:01     ` Chris Ball
2011-09-28  8:00 Stephen Rothwell
2011-09-28  7:50 Stephen Rothwell
2011-09-28  7:42 Stephen Rothwell
2011-09-28  7:58 ` Borislav Petkov
2011-09-28  7:10 Stephen Rothwell
2011-08-23  5:08 Stephen Rothwell
2011-08-23  9:59 ` Felipe Balbi
2011-09-02 18:32   ` Geert Uytterhoeven
2011-09-05 10:39     ` Felipe Balbi
2011-08-10  1:49 Stephen Rothwell
2011-08-03  4:16 Stephen Rothwell
2011-08-03 14:26 ` Greg KH
2011-08-03  4:10 Stephen Rothwell
2011-08-02  5:13 Stephen Rothwell
2011-08-02 10:15 ` Alasdair G Kergon
2011-08-01  3:58 Stephen Rothwell
2011-07-29  7:09 Stephen Rothwell
2011-07-31  6:59 ` Paul Gortmaker
2011-07-31  6:59   ` Paul Gortmaker
2011-07-29  7:06 Stephen Rothwell
2011-07-31  7:44 ` Paul Gortmaker
2011-07-31  7:44   ` Paul Gortmaker
2011-08-01  0:30   ` Stephen Rothwell
2011-08-01  0:30     ` Stephen Rothwell
2011-07-29  6:48 Stephen Rothwell
2011-07-31  7:30 ` Paul Gortmaker
2011-07-31  7:30   ` Paul Gortmaker
2011-07-29  6:24 Stephen Rothwell
2011-07-31  7:26 ` Paul Gortmaker
2011-07-31  7:26   ` Paul Gortmaker
2011-07-29  6:19 Stephen Rothwell
2011-07-31  8:08 ` Paul Gortmaker
2011-07-31  8:08   ` Paul Gortmaker
2011-07-29  5:41 Stephen Rothwell
2011-07-29  5:30 Stephen Rothwell
2011-07-29  5:25 Stephen Rothwell
2011-07-29  5:37 ` Stephen Rothwell
2011-07-31  6:31   ` Paul Gortmaker
2011-07-31  6:31     ` Paul Gortmaker
2011-07-31  8:14 ` Paul Gortmaker
2011-07-31  8:14   ` Paul Gortmaker
2011-07-29  5:10 Stephen Rothwell
2011-07-30 19:03 ` Dmitry Torokhov
2011-07-29  5:10 Stephen Rothwell
2011-07-31  4:45 ` Paul Gortmaker
2011-07-31  4:45   ` Paul Gortmaker
2011-07-29  4:56 Stephen Rothwell
2011-07-31  5:44 ` Paul Gortmaker
2011-07-31  5:44   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8AB741.9030707@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.