* [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h.
@ 2010-10-27 16:12 Mike Partington
2010-10-27 19:44 ` Rogan Dawes
0 siblings, 1 reply; 5+ messages in thread
From: Mike Partington @ 2010-10-27 16:12 UTC (permalink / raw)
To: u-boot
From: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>
Modify exports.h to remove its dependencies on other files, thus
enabling standalone apps to require only exports.h from the U-Boot
source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
Signed-off-by: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>
---
examples/standalone/atmel_df_pow2.c | 1 +
examples/standalone/stubs.c | 1 +
include/exports.h | 5 +----
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/examples/standalone/atmel_df_pow2.c b/examples/standalone/atmel_df_pow2.c
index b5b4503..2e14aba 100644
--- a/examples/standalone/atmel_df_pow2.c
+++ b/examples/standalone/atmel_df_pow2.c
@@ -8,6 +8,7 @@
#include <common.h>
#include <exports.h>
+#include <spi.h>
#define CMD_ID 0x9f
#define CMD_STAT 0xd7
diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c
index 2d2e709..1ebe43b 100644
--- a/examples/standalone/stubs.c
+++ b/examples/standalone/stubs.c
@@ -1,3 +1,4 @@
+#include <common.h>
#include <exports.h>
#ifndef GCC_VERSION
diff --git a/include/exports.h b/include/exports.h
index 7404a7c..01b83dc 100644
--- a/include/exports.h
+++ b/include/exports.h
@@ -3,8 +3,6 @@
#ifndef __ASSEMBLY__
-#include <common.h>
-
/* These are declarations of exported functions available in C code */
unsigned long get_version(void);
int getc(void);
@@ -12,7 +10,7 @@ int tstc(void);
void putc(const char);
void puts(const char*);
int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
void free_hdlr(int);
void *malloc(size_t);
void free(void*);
@@ -30,7 +28,6 @@ int ustrtoul(const char *cp, char **endp, unsigned int base);
int i2c_write (uchar, uint, int , uchar* , int);
int i2c_read (uchar, uint, int , uchar* , int);
#endif
-#include <spi.h>
void app_startup(char * const *);
--
1.7.3.5.g4a3b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h.
2010-10-27 16:12 [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h Mike Partington
@ 2010-10-27 19:44 ` Rogan Dawes
2010-10-27 20:31 ` [U-Boot] [PATCH v2] " Mike Partington
0 siblings, 1 reply; 5+ messages in thread
From: Rogan Dawes @ 2010-10-27 19:44 UTC (permalink / raw)
To: u-boot
On 2010/10/27 6:12 PM, Mike Partington wrote:
> From: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>
>
> Modify exports.h to remove its dependencies on other files, thus
> enabling standalone apps to require only exports.h from the U-Boot
> source tree. This appears to be the intent based on the following
> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
>
> Signed-off-by: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>
You may want to tidy up your email address. I see you have a more
generic email address that you sent the message from.
Rogan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] Standalone Apps: Standalone apps should need only exports.h.
2010-10-27 19:44 ` Rogan Dawes
@ 2010-10-27 20:31 ` Mike Partington
2011-12-06 19:53 ` Wolfgang Denk
0 siblings, 1 reply; 5+ messages in thread
From: Mike Partington @ 2010-10-27 20:31 UTC (permalink / raw)
To: u-boot
Modify exports.h to remove its dependencies on other files, thus
enabling standalone apps to require only exports.h from the U-Boot
source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
Signed-off-by: Mike Partington <mparting@lexmark.com>
---
Changes for v2:
- Replace domain specific email address with generic address
examples/standalone/atmel_df_pow2.c | 1 +
examples/standalone/stubs.c | 1 +
include/exports.h | 5 +----
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/examples/standalone/atmel_df_pow2.c b/examples/standalone/atmel_df_pow2.c
index b5b4503..2e14aba 100644
--- a/examples/standalone/atmel_df_pow2.c
+++ b/examples/standalone/atmel_df_pow2.c
@@ -8,6 +8,7 @@
#include <common.h>
#include <exports.h>
+#include <spi.h>
#define CMD_ID 0x9f
#define CMD_STAT 0xd7
diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c
index 2d2e709..1ebe43b 100644
--- a/examples/standalone/stubs.c
+++ b/examples/standalone/stubs.c
@@ -1,3 +1,4 @@
+#include <common.h>
#include <exports.h>
#ifndef GCC_VERSION
diff --git a/include/exports.h b/include/exports.h
index 7404a7c..01b83dc 100644
--- a/include/exports.h
+++ b/include/exports.h
@@ -3,8 +3,6 @@
#ifndef __ASSEMBLY__
-#include <common.h>
-
/* These are declarations of exported functions available in C code */
unsigned long get_version(void);
int getc(void);
@@ -12,7 +10,7 @@ int tstc(void);
void putc(const char);
void puts(const char*);
int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
void free_hdlr(int);
void *malloc(size_t);
void free(void*);
@@ -30,7 +28,6 @@ int ustrtoul(const char *cp, char **endp, unsigned int base);
int i2c_write (uchar, uint, int , uchar* , int);
int i2c_read (uchar, uint, int , uchar* , int);
#endif
-#include <spi.h>
void app_startup(char * const *);
--
1.7.3.5.g4a3b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] Standalone Apps: Standalone apps should need only exports.h.
2010-10-27 20:31 ` [U-Boot] [PATCH v2] " Mike Partington
@ 2011-12-06 19:53 ` Wolfgang Denk
2011-12-07 3:38 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2011-12-06 19:53 UTC (permalink / raw)
To: u-boot
Dear Mike Partington,
In message <1288211469-32443-1-git-send-email-mparting@lexmark.com> you wrote:
> Modify exports.h to remove its dependencies on other files, thus
> enabling standalone apps to require only exports.h from the U-Boot
> source tree. This appears to be the intent based on the following
> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
>
> Signed-off-by: Mike Partington <mparting@lexmark.com>
> ---
> Changes for v2:
> - Replace domain specific email address with generic address
>
> examples/standalone/atmel_df_pow2.c | 1 +
> examples/standalone/stubs.c | 1 +
> include/exports.h | 5 +----
> 3 files changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lack of skill dictates economy of style. - Joey Ramone
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] Standalone Apps: Standalone apps should need only exports.h.
2011-12-06 19:53 ` Wolfgang Denk
@ 2011-12-07 3:38 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2011-12-07 3:38 UTC (permalink / raw)
To: u-boot
On Dec 6, 2011, at 1:53 PM, Wolfgang Denk wrote:
> Dear Mike Partington,
>
> In message <1288211469-32443-1-git-send-email-mparting@lexmark.com> you wrote:
>> Modify exports.h to remove its dependencies on other files, thus
>> enabling standalone apps to require only exports.h from the U-Boot
>> source tree. This appears to be the intent based on the following
>> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
>>
>> Signed-off-by: Mike Partington <mparting@lexmark.com>
>> ---
>> Changes for v2:
>> - Replace domain specific email address with generic address
>>
>> examples/standalone/atmel_df_pow2.c | 1 +
>> examples/standalone/stubs.c | 1 +
>> include/exports.h | 5 +----
>> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk
This breaks builds:
In file included from qsort.c:19:0:
/local/home/galak/git/u-boot/include/exports.h:19:27: error: expected declaration specifiers or '...' before 'va_list'
qsort.c: In function 'qsort':
qsort.c:30:3: warning: implicit declaration of function 'assert'
Simon has posted a patch that fixes:
http://patchwork.ozlabs.org/patch/129855/
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-07 3:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-27 16:12 [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h Mike Partington
2010-10-27 19:44 ` Rogan Dawes
2010-10-27 20:31 ` [U-Boot] [PATCH v2] " Mike Partington
2011-12-06 19:53 ` Wolfgang Denk
2011-12-07 3:38 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.