From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "Samuel Ortiz" <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
"Liam Girdwood" <lrg-l0cyMroinI0@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Sascha Hauer" <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 1/3] mfd: mc13xxx: add device tree probe support
Date: Tue, 20 Dec 2011 01:59:32 +0000 [thread overview]
Message-ID: <20111220015931.GX2860@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111220020101.GD5683-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
On Tue, Dec 20, 2011 at 10:01:02AM +0800, Shawn Guo wrote:
> On Tue, Dec 20, 2011 at 12:57:09AM +0000, Mark Brown wrote:
> > On Mon, Dec 12, 2011 at 11:15:56PM +0800, Shawn Guo wrote:
> > > +Sub-nodes:
> > > +- regulators : Contain the regulator nodes. The name of regulator node
> > > + is being used by mc13xxx regulator driver to find the correct relator
> > > + device.
> > Reading this I'm not clear what the name of the node is, or what the
> > valid node names are.
> In the example below, the name would be 'mc13892__sw1'.
You're missing the point - someone reading the documentation needs to be
able to figure out what strings they need to use for all the different
regulators on the chip are without groveling through the driver code.
> > > + sw1_reg: mc13892__sw1 {
> > The examples don't really elucidate this either (and the __ is rather
> > odd).
> Yes, that's because the name defined by mc13892 regulator driver is odd.
That's *not* something that we should be exposing in the device tree
bindings. This is an implementation detail of the Linux driver which
might well change in future.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] mfd: mc13xxx: add device tree probe support
Date: Tue, 20 Dec 2011 01:59:32 +0000 [thread overview]
Message-ID: <20111220015931.GX2860@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111220020101.GD5683@S2100-06.ap.freescale.net>
On Tue, Dec 20, 2011 at 10:01:02AM +0800, Shawn Guo wrote:
> On Tue, Dec 20, 2011 at 12:57:09AM +0000, Mark Brown wrote:
> > On Mon, Dec 12, 2011 at 11:15:56PM +0800, Shawn Guo wrote:
> > > +Sub-nodes:
> > > +- regulators : Contain the regulator nodes. The name of regulator node
> > > + is being used by mc13xxx regulator driver to find the correct relator
> > > + device.
> > Reading this I'm not clear what the name of the node is, or what the
> > valid node names are.
> In the example below, the name would be 'mc13892__sw1'.
You're missing the point - someone reading the documentation needs to be
able to figure out what strings they need to use for all the different
regulators on the chip are without groveling through the driver code.
> > > + sw1_reg: mc13892__sw1 {
> > The examples don't really elucidate this either (and the __ is rather
> > odd).
> Yes, that's because the name defined by mc13892 regulator driver is odd.
That's *not* something that we should be exposing in the device tree
bindings. This is an implementation detail of the Linux driver which
might well change in future.
next prev parent reply other threads:[~2011-12-20 1:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:15 [PATCH v3 0/3] Add device tree support for mc13892 regulator driver Shawn Guo
2011-12-12 15:15 ` Shawn Guo
[not found] ` <1323702958-4831-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-12 15:15 ` [PATCH v3 1/3] mfd: mc13xxx: add device tree probe support Shawn Guo
2011-12-12 15:15 ` Shawn Guo
[not found] ` <1323702958-4831-2-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-20 0:57 ` Mark Brown
2011-12-20 0:57 ` Mark Brown
[not found] ` <20111220005708.GM2860-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 2:01 ` Shawn Guo
2011-12-20 2:01 ` Shawn Guo
[not found] ` <20111220020101.GD5683-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-12-20 1:59 ` Mark Brown [this message]
2011-12-20 1:59 ` Mark Brown
[not found] ` <20111220015931.GX2860-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 3:03 ` Shawn Guo
2011-12-20 3:03 ` Shawn Guo
2011-12-20 11:25 ` Mark Brown
2011-12-20 11:25 ` Mark Brown
[not found] ` <20111220112510.GL2866-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 13:52 ` Shawn Guo
2011-12-20 13:52 ` Shawn Guo
[not found] ` <20111220135251.GB5129-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-12-20 14:35 ` Mark Brown
2011-12-20 14:35 ` Mark Brown
[not found] ` <20111220143558.GT2866-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 15:31 ` Shawn Guo
2011-12-20 15:31 ` Shawn Guo
[not found] ` <20111220153101.GD5348-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-12-20 23:25 ` Mark Brown
2011-12-20 23:25 ` Mark Brown
[not found] ` <20111220232526.GA6551-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-21 1:25 ` Shawn Guo
2011-12-21 1:25 ` Shawn Guo
2011-12-21 1:37 ` Mark Brown
2011-12-21 1:37 ` Mark Brown
[not found] ` <20111221013702.GB15398-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-21 2:12 ` Shawn Guo
2011-12-21 2:12 ` Shawn Guo
2011-12-12 15:15 ` [PATCH v3 2/3] regulator: mc13892: " Shawn Guo
2011-12-12 15:15 ` Shawn Guo
[not found] ` <1323702958-4831-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-19 14:07 ` Shawn Guo
2011-12-19 14:07 ` Shawn Guo
[not found] ` <20111219140730.GB5257-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-12-20 0:54 ` Mark Brown
2011-12-20 0:54 ` Mark Brown
[not found] ` <20111220005414.GL2860-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 1:37 ` Shawn Guo
2011-12-20 1:37 ` Shawn Guo
[not found] ` <20111220013711.GC5683-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-12-20 1:34 ` Mark Brown
2011-12-20 1:34 ` Mark Brown
[not found] ` <20111220013425.GU2860-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-20 2:02 ` Shawn Guo
2011-12-20 2:02 ` Shawn Guo
2011-12-12 15:15 ` [PATCH v3 3/3] arm/imx: add mc13892 support into imx51-babbage.dts Shawn Guo
2011-12-12 15:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220015931.GX2860@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.