All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ryan Mallon <rmallon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Matthias Kaehlcke
	<matthias-RprLehDfhQ3k1uMJSBkQmQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
Subject: Re: [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs.
Date: Wed, 8 Feb 2012 10:00:55 +0100	[thread overview]
Message-ID: <20120208090055.GP3852@pengutronix.de> (raw)
In-Reply-To: <20120208081508.GA6673-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>

On Wed, Feb 08, 2012 at 09:15:08AM +0100, Thierry Reding wrote:
> * Ryan Mallon wrote:
> > On 07/02/12 02:19, Thierry Reding wrote:
> > > The total maximum number of PWM devices is currently fixed to 64, but
> > > can easily be made configurable via Kconfig.
> > 
> > It would be better to make the code handle arbitrary numbers of PWMs. A
> > Kconfig knob becomes annoying when you have more than one platform
> > configured into the kernel.
> 
> AFAICT handling an arbitrary number of PWMs will only be possible once we get
> rid of the global namespace and therefore should be postponed for later. I
> may be wrong, though, so if anybody can point me in the right direction I'm
> perfectly happy to change that in this series.
> 
> > > The patch is incomplete in that it doesn't convert any existing drivers
> > > that are now broken.
> > 
> > Does this patch actually break the drivers in terms of not building or
> > running? If so, can this patch series be reworked a bit to allow the old
> > PWM framework to be used until all of the drivers are converted?
> 
> That sentence is misleading. Since the new framework implements the exact
> same API as the drivers, any unconverted drivers will still work unless they
> are built within the same kernel as the framework.

I have a series porting all in kernel drivers to this framework. I can
follow up on this series once it's clear we want to go this way. With
this series the way will be free to move to a better pwm matching
without a global pwm index because the drivers won't be affected by
this change anymore.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs.
Date: Wed, 8 Feb 2012 10:00:55 +0100	[thread overview]
Message-ID: <20120208090055.GP3852@pengutronix.de> (raw)
In-Reply-To: <20120208081508.GA6673@avionic-0098.mockup.avionic-design.de>

On Wed, Feb 08, 2012 at 09:15:08AM +0100, Thierry Reding wrote:
> * Ryan Mallon wrote:
> > On 07/02/12 02:19, Thierry Reding wrote:
> > > The total maximum number of PWM devices is currently fixed to 64, but
> > > can easily be made configurable via Kconfig.
> > 
> > It would be better to make the code handle arbitrary numbers of PWMs. A
> > Kconfig knob becomes annoying when you have more than one platform
> > configured into the kernel.
> 
> AFAICT handling an arbitrary number of PWMs will only be possible once we get
> rid of the global namespace and therefore should be postponed for later. I
> may be wrong, though, so if anybody can point me in the right direction I'm
> perfectly happy to change that in this series.
> 
> > > The patch is incomplete in that it doesn't convert any existing drivers
> > > that are now broken.
> > 
> > Does this patch actually break the drivers in terms of not building or
> > running? If so, can this patch series be reworked a bit to allow the old
> > PWM framework to be used until all of the drivers are converted?
> 
> That sentence is misleading. Since the new framework implements the exact
> same API as the drivers, any unconverted drivers will still work unless they
> are built within the same kernel as the framework.

I have a series porting all in kernel drivers to this framework. I can
follow up on this series once it's clear we want to go this way. With
this series the way will be free to move to a better pwm matching
without a global pwm index because the drivers won't be affected by
this change anymore.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2012-02-08  9:00 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 15:19 [PATCH v2 00/10] Add PWM framework and device-tree support Thierry Reding
2012-02-06 15:19 ` Thierry Reding
     [not found] ` <1328541585-24642-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-02-06 15:19   ` [PATCH v2 01/10] PWM: add pwm framework support Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs Thierry Reding
2012-02-06 15:19     ` Thierry Reding
     [not found]     ` <1328541585-24642-3-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-02-06 21:22       ` Lars-Peter Clausen
2012-02-06 21:22         ` Lars-Peter Clausen
     [not found]         ` <4F3044A9.8000202-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2012-02-07  7:04           ` Thierry Reding
2012-02-07  7:04             ` Thierry Reding
     [not found]             ` <20120207070400.GA29238-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-02-07 11:38               ` Mark Brown
2012-02-07 11:38                 ` Mark Brown
2012-02-08  9:13               ` Russell King - ARM Linux
2012-02-08  9:13                 ` Russell King - ARM Linux
     [not found]                 ` <20120208091327.GH889-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-08 11:12                   ` Thierry Reding
2012-02-08 11:12                     ` Thierry Reding
2012-02-07 22:53       ` Ryan Mallon
2012-02-07 22:53         ` Ryan Mallon
     [not found]         ` <4F31AB63.3020301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-08  8:15           ` Thierry Reding
2012-02-08  8:15             ` Thierry Reding
     [not found]             ` <20120208081508.GA6673-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-02-08  9:00               ` Sascha Hauer [this message]
2012-02-08  9:00                 ` Sascha Hauer
     [not found]                 ` <20120208090055.GP3852-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-02-08 11:16                   ` Thierry Reding
2012-02-08 11:16                     ` Thierry Reding
2012-02-08  9:17               ` Russell King - ARM Linux
2012-02-08  9:17                 ` Russell King - ARM Linux
     [not found]                 ` <20120208091720.GI889-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-08 10:31                   ` Thierry Reding
2012-02-08 10:31                     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 03/10] of: Add PWM support Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 04/10] arm/tegra: Fix PWM clock programming Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 05/10] arm/tegra: Provide clock for only one PWM controller Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 06/10] pwm: Add NVIDIA Tegra SoC support Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 07/10] arm/tegra: Add PWFM controller device tree probing Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 08/10] pwm: Add Blackfin support Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 09/10] pwm: Add PXA support Thierry Reding
2012-02-06 15:19     ` Thierry Reding
2012-02-06 15:19   ` [PATCH v2 10/10] pwm-backlight: Add rudimentary device tree support Thierry Reding
2012-02-06 15:19     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120208090055.GP3852@pengutronix.de \
    --to=s.hauer-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kurt.van.dijck-/BeEPy95v10@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matthias-RprLehDfhQ3k1uMJSBkQmQ@public.gmane.org \
    --cc=rmallon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.