All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Michal Nazarewicz" <mina86@mina86.com>
Cc: linux-kernel@vger.kernel.org,
	"Gilad Ben-Yossef" <gilad@benyossef.com>,
	"Chris Metcalf" <cmetcalf@tilera.com>,
	"Christoph Lameter" <cl@linux-foundation.org>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	linux-mm@kvack.org, "Pekka Enberg" <penberg@kernel.org>,
	"Matt Mackall" <mpm@selenic.com>,
	"Sasha Levin" <levinsasha928@gmail.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Andi Kleen" <andi@firstfloor.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, "Avi Kivity" <avi@redhat.com>,
	"Kosaki Motohiro" <kosaki.motohiro@gmail.com>,
	"Milton Miller" <miltonm@bga.com>
Subject: Re: [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func
Date: Wed, 8 Feb 2012 16:03:44 -0800	[thread overview]
Message-ID: <20120208160344.88d187e5.akpm@linux-foundation.org> (raw)
In-Reply-To: <op.v9csppvv3l0zgt@mpn-glaptop>

On Wed, 08 Feb 2012 10:30:51 +0100
"Michal Nazarewicz" <mina86@mina86.com> wrote:

> >  	} while (0)
> > +/*
> > + * Preemption is disabled here to make sure the
> > + * cond_func is called under the same condtions in UP
> > + * and SMP.
> > + */
> > +#define on_each_cpu_cond(cond_func, func, info, wait, gfp_flags) \
> > +	do {						\
> 
> How about:
> 
> 		void *__info = (info);
> 
> as to avoid double execution.

Yup.  How does this look?


From: Andrew Morton <akpm@linux-foundation.org>
Subject: smp-add-func-to-ipi-cpus-based-on-parameter-func-update-fix

- avoid double-evaluation of `info' (per Michal)
- parenthesise evaluation of `cond_func'

Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/smp.h |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/include/linux/smp.h~smp-add-func-to-ipi-cpus-based-on-parameter-func-update-fix
+++ a/include/linux/smp.h
@@ -168,10 +168,11 @@ static inline int up_smp_call_function(s
  */
 #define on_each_cpu_cond(cond_func, func, info, wait, gfp_flags)\
 	do {							\
+		void *__info = (info);				\
 		preempt_disable();				\
-		if (cond_func(0, info)) {			\
+		if ((cond_func)(0, __info)) {			\
 			local_irq_disable();			\
-			(func)(info);				\
+			(func)(__info);				\
 			local_irq_enable();			\
 		}						\
 		preempt_enable();				\
_


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Michal Nazarewicz" <mina86@mina86.com>
Cc: linux-kernel@vger.kernel.org,
	"Gilad Ben-Yossef" <gilad@benyossef.com>,
	"Chris Metcalf" <cmetcalf@tilera.com>,
	"Christoph Lameter" <cl@linux-foundation.org>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	linux-mm@kvack.org, "Pekka Enberg" <penberg@kernel.org>,
	"Matt Mackall" <mpm@selenic.com>,
	"Sasha Levin" <levinsasha928@gmail.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Andi Kleen" <andi@firstfloor.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, "Avi Kivity" <avi@redhat.com>,
	"Kosaki Motohiro" <kosaki.motohiro@gmail.com>,
	"Milton Miller" <miltonm@bga.com>
Subject: Re: [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func
Date: Wed, 8 Feb 2012 16:03:44 -0800	[thread overview]
Message-ID: <20120208160344.88d187e5.akpm@linux-foundation.org> (raw)
In-Reply-To: <op.v9csppvv3l0zgt@mpn-glaptop>

On Wed, 08 Feb 2012 10:30:51 +0100
"Michal Nazarewicz" <mina86@mina86.com> wrote:

> >  	} while (0)
> > +/*
> > + * Preemption is disabled here to make sure the
> > + * cond_func is called under the same condtions in UP
> > + * and SMP.
> > + */
> > +#define on_each_cpu_cond(cond_func, func, info, wait, gfp_flags) \
> > +	do {						\
> 
> How about:
> 
> 		void *__info = (info);
> 
> as to avoid double execution.

Yup.  How does this look?


From: Andrew Morton <akpm@linux-foundation.org>
Subject: smp-add-func-to-ipi-cpus-based-on-parameter-func-update-fix

- avoid double-evaluation of `info' (per Michal)
- parenthesise evaluation of `cond_func'

Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/smp.h |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/include/linux/smp.h~smp-add-func-to-ipi-cpus-based-on-parameter-func-update-fix
+++ a/include/linux/smp.h
@@ -168,10 +168,11 @@ static inline int up_smp_call_function(s
  */
 #define on_each_cpu_cond(cond_func, func, info, wait, gfp_flags)\
 	do {							\
+		void *__info = (info);				\
 		preempt_disable();				\
-		if (cond_func(0, info)) {			\
+		if ((cond_func)(0, __info)) {			\
 			local_irq_disable();			\
-			(func)(info);				\
+			(func)(__info);				\
 			local_irq_enable();			\
 		}						\
 		preempt_enable();				\
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-02-09  0:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05 13:33 [PATCH v8 0/8] Reduce cross CPU IPI interference Gilad Ben-Yossef
2012-02-05 13:33 ` Gilad Ben-Yossef
2012-02-05 13:44 ` [PATCH v8 1/8] smp: introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2012-02-05 13:44   ` Gilad Ben-Yossef
2012-02-05 15:18   ` Srivatsa S. Bhat
2012-02-05 15:18     ` Srivatsa S. Bhat
2012-02-05 13:48 ` [PATCH v8 2/8] arm: move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 3/8] tile: move tile to use " Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 15:36   ` Srivatsa S. Bhat
2012-02-05 15:36     ` Srivatsa S. Bhat
2012-02-05 15:46     ` Gilad Ben-Yossef
2012-02-05 15:46       ` Gilad Ben-Yossef
2012-02-05 16:00       ` Srivatsa S. Bhat
2012-02-05 16:00         ` Srivatsa S. Bhat
2012-02-05 16:03         ` Srivatsa S. Bhat
2012-02-05 16:03           ` Srivatsa S. Bhat
2012-02-08  9:30   ` Michal Nazarewicz
2012-02-08  9:30     ` Michal Nazarewicz
2012-02-09  0:03     ` Andrew Morton [this message]
2012-02-09  0:03       ` Andrew Morton
2012-02-09  8:08       ` Gilad Ben-Yossef
2012-02-09  8:08         ` Gilad Ben-Yossef
2012-02-09  8:13         ` Andrew Morton
2012-02-09  8:13           ` Andrew Morton
2012-02-09  9:53           ` Gilad Ben-Yossef
2012-02-09  9:53             ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 5/8] slub: only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 6/8] fs: only send IPI to invalidate LRU BH when needed Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-08  9:33   ` Michal Nazarewicz
2012-02-08  9:33     ` Michal Nazarewicz
2012-02-09  8:09     ` Gilad Ben-Yossef
2012-02-09  8:09       ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 8/8] mm: add vmstat counters for tracking PCP drains Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-08  9:36 ` [PATCH v8 0/8] Reduce cross CPU IPI interference Michal Nazarewicz
2012-02-08  9:36   ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120208160344.88d187e5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=cmetcalf@tilera.com \
    --cc=fweisbec@gmail.com \
    --cc=gilad@benyossef.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=miltonm@bga.com \
    --cc=mina86@mina86.com \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.