All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: linux-kernel@vger.kernel.org,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
	Matt Mackall <mpm@selenic.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	Milton Miller <miltonm@bga.com>
Subject: Re: [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist
Date: Thu, 9 Feb 2012 10:09:15 +0200	[thread overview]
Message-ID: <CAOtvUMdo3yx1d5Ghs=GVBHCQGA8t9Vg=PK77h4V=hrLWDPUcUQ@mail.gmail.com> (raw)
In-Reply-To: <op.v9cstne43l0zgt@mpn-glaptop>

2012/2/8 Michal Nazarewicz <mina86@mina86.com>:
> On Sun, 05 Feb 2012 14:48:41 +0100, Gilad Ben-Yossef <gilad@benyossef.com>
> wrote:
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index d2186ec..3ff5aff 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -1161,11 +1161,46 @@ void drain_local_pages(void *arg)
...
>> +
>> +       /* Allocate in the BSS so we wont require allocation in
>> +        * direct reclaim path for CONFIG_CPUMASK_OFFSTACK=y
>> +        */
>
>
> If you are going to send next iteration, this comment should have
> “/*” on its own line just like comment below.

Right, thanks.

Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

WARNING: multiple messages have this Message-ID (diff)
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: linux-kernel@vger.kernel.org,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
	Matt Mackall <mpm@selenic.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	Milton Miller <miltonm@bga.com>
Subject: Re: [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist
Date: Thu, 9 Feb 2012 10:09:15 +0200	[thread overview]
Message-ID: <CAOtvUMdo3yx1d5Ghs=GVBHCQGA8t9Vg=PK77h4V=hrLWDPUcUQ@mail.gmail.com> (raw)
In-Reply-To: <op.v9cstne43l0zgt@mpn-glaptop>

2012/2/8 Michal Nazarewicz <mina86@mina86.com>:
> On Sun, 05 Feb 2012 14:48:41 +0100, Gilad Ben-Yossef <gilad@benyossef.com>
> wrote:
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index d2186ec..3ff5aff 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -1161,11 +1161,46 @@ void drain_local_pages(void *arg)
...
>> +
>> +       /* Allocate in the BSS so we wont require allocation in
>> +        * direct reclaim path for CONFIG_CPUMASK_OFFSTACK=y
>> +        */
>
>
> If you are going to send next iteration, this comment should have
> “/*” on its own line just like comment below.

Right, thanks.

Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-02-09  8:09 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05 13:33 [PATCH v8 0/8] Reduce cross CPU IPI interference Gilad Ben-Yossef
2012-02-05 13:33 ` Gilad Ben-Yossef
2012-02-05 13:44 ` [PATCH v8 1/8] smp: introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2012-02-05 13:44   ` Gilad Ben-Yossef
2012-02-05 15:18   ` Srivatsa S. Bhat
2012-02-05 15:18     ` Srivatsa S. Bhat
2012-02-05 13:48 ` [PATCH v8 2/8] arm: move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 3/8] tile: move tile to use " Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 15:36   ` Srivatsa S. Bhat
2012-02-05 15:36     ` Srivatsa S. Bhat
2012-02-05 15:46     ` Gilad Ben-Yossef
2012-02-05 15:46       ` Gilad Ben-Yossef
2012-02-05 16:00       ` Srivatsa S. Bhat
2012-02-05 16:00         ` Srivatsa S. Bhat
2012-02-05 16:03         ` Srivatsa S. Bhat
2012-02-05 16:03           ` Srivatsa S. Bhat
2012-02-08  9:30   ` Michal Nazarewicz
2012-02-08  9:30     ` Michal Nazarewicz
2012-02-09  0:03     ` Andrew Morton
2012-02-09  0:03       ` Andrew Morton
2012-02-09  8:08       ` Gilad Ben-Yossef
2012-02-09  8:08         ` Gilad Ben-Yossef
2012-02-09  8:13         ` Andrew Morton
2012-02-09  8:13           ` Andrew Morton
2012-02-09  9:53           ` Gilad Ben-Yossef
2012-02-09  9:53             ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 5/8] slub: only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 6/8] fs: only send IPI to invalidate LRU BH when needed Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-08  9:33   ` Michal Nazarewicz
2012-02-08  9:33     ` Michal Nazarewicz
2012-02-09  8:09     ` Gilad Ben-Yossef [this message]
2012-02-09  8:09       ` Gilad Ben-Yossef
2012-02-05 13:48 ` [PATCH v8 8/8] mm: add vmstat counters for tracking PCP drains Gilad Ben-Yossef
2012-02-05 13:48   ` Gilad Ben-Yossef
2012-02-08  9:36 ` [PATCH v8 0/8] Reduce cross CPU IPI interference Michal Nazarewicz
2012-02-08  9:36   ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOtvUMdo3yx1d5Ghs=GVBHCQGA8t9Vg=PK77h4V=hrLWDPUcUQ@mail.gmail.com' \
    --to=gilad@benyossef.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=cmetcalf@tilera.com \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=miltonm@bga.com \
    --cc=mina86@mina86.com \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.