From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Chanho Min <chanho0207@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>,
"Kim, Jong-Sung" <neidhard.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled
Date: Mon, 27 Feb 2012 11:02:04 +0000 [thread overview]
Message-ID: <20120227110204.GA30199@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120227104858.GR22562@n2100.arm.linux.org.uk>
On Mon, Feb 27, 2012 at 10:48:58AM +0000, Russell King - ARM Linux wrote:
> I'd much prefer to only clear those interrupts which actually need to be
> cleared at this point. So, I'd suggest this approach instead:
Thinking about this a little more, we definitely want to mask and clear
interrupts at probe time as well:
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 6800f5f..6b781bd 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1381,6 +1381,10 @@ static int pl011_startup(struct uart_port *port)
uap->port.uartclk = clk_get_rate(uap->clk);
+ /* Clear pending error and receive interrupts */
+ writew(UART011_OEIS | UART011_BEIS | UART011_PEIS | UART011_FEIS |
+ UART011_RTIS | UART011_RXIS, uap->port.membase + UART011_ICR);
+
/*
* Allocate the IRQ
*/
@@ -1417,10 +1421,6 @@ static int pl011_startup(struct uart_port *port)
cr |= UART01x_CR_UARTEN | UART011_CR_RXE | UART011_CR_TXE;
writew(cr, uap->port.membase + UART011_CR);
- /* Clear pending error interrupts */
- writew(UART011_OEIS | UART011_BEIS | UART011_PEIS | UART011_FEIS,
- uap->port.membase + UART011_ICR);
-
/*
* initialise the old status of the modem signals
*/
@@ -1927,6 +1927,10 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
goto unmap;
}
+ /* Ensure interrupts from this UART are masked and cleared */
+ writew(0, uap->port.membase + UART011_IMSC);
+ writew(0xffff, uap->port.membase + UART011_ICR);
+
uap->vendor = vendor;
uap->lcrh_rx = vendor->lcrh_rx;
uap->lcrh_tx = vendor->lcrh_tx;
next prev parent reply other threads:[~2012-02-27 11:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:30 [PATCH] Clear previous interrupts after fifo is disabled Chanho Min
2012-02-27 10:45 ` Linus Walleij
2012-02-27 10:45 ` Linus Walleij
2012-02-27 10:48 ` Russell King - ARM Linux
2012-02-27 11:02 ` Russell King - ARM Linux [this message]
2012-02-27 13:54 ` Linus Walleij
2012-02-28 1:35 ` Chanho Min
2012-02-28 8:35 ` Russell King - ARM Linux
2012-02-28 8:35 ` Russell King - ARM Linux
2012-02-28 9:16 ` Chanho Min
2012-02-28 9:16 ` Chanho Min
2012-02-28 9:21 ` Russell King - ARM Linux
2012-02-28 9:46 ` Chanho Min
2012-02-28 10:23 ` Russell King - ARM Linux
2012-02-29 2:47 ` Chanho Min
2012-02-29 2:47 ` Chanho Min
2012-03-08 9:02 ` Kim, Jong-Sung
2012-03-08 9:02 ` Kim, Jong-Sung
2012-03-08 18:49 ` Greg Kroah-Hartman
2012-03-09 16:34 ` Linus Walleij
2012-03-09 16:34 ` Linus Walleij
2012-03-09 16:37 ` Greg Kroah-Hartman
2012-03-09 16:37 ` Greg Kroah-Hartman
2012-03-10 2:14 ` Chanho Min
2012-03-12 1:24 ` Kim, Jong-Sung
2012-03-12 1:24 ` Kim, Jong-Sung
2012-03-12 8:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227110204.GA30199@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alan@linux.intel.com \
--cc=chanho0207@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=neidhard.kim@lge.com \
--cc=shreshthakumar.sahu@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.