From: "Kim, Jong-Sung" <neidhard.kim@lge.com> To: "'Chanho Min'" <chanho0207@gmail.com>, "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org> Cc: "'Linus Walleij'" <linus.walleij@linaro.org>, "'Russell King'" <linux@arm.linux.org.uk>, "'Alan Cox'" <alan@linux.intel.com>, "'Shreshtha Kumar Sahu'" <shreshthakumar.sahu@stericsson.com>, <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org> Subject: RE: [PATCH] Clear previous interrupts after fifo is disabled Date: Mon, 12 Mar 2012 10:24:17 +0900 [thread overview] Message-ID: <018601ccffee$d9a8cf00$8cfa6d00$@lge.com> (raw) In-Reply-To: <CAOAMb1Bpx4ucHgKy+oT2rvt16cubFR3Vi8o3fjwrT65DdJko_Q@mail.gmail.com> > -----Original Message----- > From: Chanho Min [mailto:chanho0207@gmail.com] > Sent: Saturday, March 10, 2012 11:15 AM > To: Greg Kroah-Hartman > Cc: Linus Walleij; Russell King; Alan Cox; Shreshtha Kumar Sahu; Kim, Jong- > Sung; linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org > Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled > > >> To me it seems Russell's patch solves part of the problem, and > >> Jong-Sung Kim's patch on top of that solves the entire problem, but > >> Chanho need to come back and tell whether this is the case in > >> practice. > > > > Ok, then, once it is tested, can someone resend them to me? > > > > thanks, > > > > greg k-h > > I checked that Jong-Sung Kim's patch solved this hang-up issue and agree on > it. But, RTIS seems to be cleared as well. You're right. RTIS should be cleared as well as RXIS. Revised patch: diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 6800f5f..39520db 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -224,6 +224,11 @@ static int pl011_fifo_to_tty(struct uart_amba_port *uap) uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag); } + /* RTIS and/or RXIS, but RXFE? Just clear the interrupt(s) */ + if(unlikely(fifotaken == 0)) + writew(UART011_RTIS | UART011_RXIS, uap->port.membase + + UART011_ICR); + return fifotaken; }
WARNING: multiple messages have this Message-ID (diff)
From: "Kim, Jong-Sung" <neidhard.kim@lge.com> To: 'Chanho Min' <chanho0207@gmail.com>, 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org> Cc: 'Linus Walleij' <linus.walleij@linaro.org>, 'Russell King' <linux@arm.linux.org.uk>, 'Alan Cox' <alan@linux.intel.com>, 'Shreshtha Kumar Sahu' <shreshthakumar.sahu@stericsson.com>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: RE: [PATCH] Clear previous interrupts after fifo is disabled Date: Mon, 12 Mar 2012 10:24:17 +0900 [thread overview] Message-ID: <018601ccffee$d9a8cf00$8cfa6d00$@lge.com> (raw) In-Reply-To: <CAOAMb1Bpx4ucHgKy+oT2rvt16cubFR3Vi8o3fjwrT65DdJko_Q@mail.gmail.com> > -----Original Message----- > From: Chanho Min [mailto:chanho0207@gmail.com] > Sent: Saturday, March 10, 2012 11:15 AM > To: Greg Kroah-Hartman > Cc: Linus Walleij; Russell King; Alan Cox; Shreshtha Kumar Sahu; Kim, Jong- > Sung; linux-kernel@vger.kernel.org; linux-serial@vger.kernel.org > Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled > > >> To me it seems Russell's patch solves part of the problem, and > >> Jong-Sung Kim's patch on top of that solves the entire problem, but > >> Chanho need to come back and tell whether this is the case in > >> practice. > > > > Ok, then, once it is tested, can someone resend them to me? > > > > thanks, > > > > greg k-h > > I checked that Jong-Sung Kim's patch solved this hang-up issue and agree on > it. But, RTIS seems to be cleared as well. You're right. RTIS should be cleared as well as RXIS. Revised patch: diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 6800f5f..39520db 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -224,6 +224,11 @@ static int pl011_fifo_to_tty(struct uart_amba_port *uap) uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag); } + /* RTIS and/or RXIS, but RXFE? Just clear the interrupt(s) */ + if(unlikely(fifotaken == 0)) + writew(UART011_RTIS | UART011_RXIS, uap->port.membase + + UART011_ICR); + return fifotaken; }
next prev parent reply other threads:[~2012-03-12 1:24 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-27 9:30 [PATCH] Clear previous interrupts after fifo is disabled Chanho Min 2012-02-27 10:45 ` Linus Walleij 2012-02-27 10:45 ` Linus Walleij 2012-02-27 10:48 ` Russell King - ARM Linux 2012-02-27 11:02 ` Russell King - ARM Linux 2012-02-27 13:54 ` Linus Walleij 2012-02-28 1:35 ` Chanho Min 2012-02-28 8:35 ` Russell King - ARM Linux 2012-02-28 8:35 ` Russell King - ARM Linux 2012-02-28 9:16 ` Chanho Min 2012-02-28 9:16 ` Chanho Min 2012-02-28 9:21 ` Russell King - ARM Linux 2012-02-28 9:46 ` Chanho Min 2012-02-28 10:23 ` Russell King - ARM Linux 2012-02-29 2:47 ` Chanho Min 2012-02-29 2:47 ` Chanho Min 2012-03-08 9:02 ` Kim, Jong-Sung 2012-03-08 9:02 ` Kim, Jong-Sung 2012-03-08 18:49 ` Greg Kroah-Hartman 2012-03-09 16:34 ` Linus Walleij 2012-03-09 16:34 ` Linus Walleij 2012-03-09 16:37 ` Greg Kroah-Hartman 2012-03-09 16:37 ` Greg Kroah-Hartman 2012-03-10 2:14 ` Chanho Min 2012-03-12 1:24 ` Kim, Jong-Sung [this message] 2012-03-12 1:24 ` Kim, Jong-Sung 2012-03-12 8:29 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='018601ccffee$d9a8cf00$8cfa6d00$@lge.com' \ --to=neidhard.kim@lge.com \ --cc=alan@linux.intel.com \ --cc=chanho0207@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=shreshthakumar.sahu@stericsson.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.