* [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card @ 2012-03-23 5:56 Subhash Jadavani 2012-03-26 3:17 ` Aaron Lu 2012-03-26 6:25 ` Stephen Boyd 0 siblings, 2 replies; 7+ messages in thread From: Subhash Jadavani @ 2012-03-23 5:56 UTC (permalink / raw) To: linux-mmc; +Cc: linux-arm-msm, arindam.nath, Subhash Jadavani When UHS-I card is detected also print the bus speed mode in which UHS-I card will be running. Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> --- drivers/mmc/core/bus.c | 26 +++++++++++++++++++++++++- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 5d011a3..0517a91 100644 --- a/drivers/mmc/core/bus.c +++ b/drivers/mmc/core/bus.c @@ -267,6 +267,7 @@ int mmc_add_card(struct mmc_card *card) { int ret; const char *type; + const char *uhs_bus_speed_mode = ""; dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), card->rca); @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) break; } + if (mmc_sd_card_uhs(card)) { + switch (card->sd_bus_speed) { + case UHS_SDR104_BUS_SPEED: + uhs_bus_speed_mode = "SDR104 "; + break; + case UHS_SDR50_BUS_SPEED: + uhs_bus_speed_mode = "SDR50 "; + break; + case UHS_DDR50_BUS_SPEED: + uhs_bus_speed_mode = "DDR50 "; + break; + case UHS_SDR25_BUS_SPEED: + uhs_bus_speed_mode = "SDR25 "; + break; + case UHS_SDR12_BUS_SPEED: + uhs_bus_speed_mode = "SDR12 "; + break; + default: + uhs_bus_speed_mode = ""; + break; + } + } if (mmc_host_is_spi(card->host)) { pr_info("%s: new %s%s%s card on SPI\n", mmc_hostname(card->host), @@ -303,12 +326,13 @@ int mmc_add_card(struct mmc_card *card) mmc_card_ddr_mode(card) ? "DDR " : "", type); } else { - pr_info("%s: new %s%s%s%s card at address %04x\n", + pr_info("%s: new %s%s%s%s%s card at address %04x\n", mmc_hostname(card->host), mmc_card_uhs(card) ? "ultra high speed " : (mmc_card_highspeed(card) ? "high speed " : ""), (mmc_card_hs200(card) ? "HS200 " : ""), mmc_card_ddr_mode(card) ? "DDR " : "", + uhs_bus_speed_mode, type, card->rca); } -- 1.7.1.1 -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-23 5:56 [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card Subhash Jadavani @ 2012-03-26 3:17 ` Aaron Lu 2012-03-26 6:16 ` Subhash Jadavani 2012-03-26 6:25 ` Stephen Boyd 1 sibling, 1 reply; 7+ messages in thread From: Aaron Lu @ 2012-03-26 3:17 UTC (permalink / raw) To: Subhash Jadavani; +Cc: linux-mmc, linux-arm-msm, arindam.nath Hi Subhash, On Fri, Mar 23, 2012 at 11:26:36AM +0530, Subhash Jadavani wrote: > When UHS-I card is detected also print the bus speed mode > in which UHS-I card will be running. The patch looks correct to me, except that I' m not sure if this is needed. /sys/kernel/debug/mmc/ios also has such info. -Aaron > > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > --- > drivers/mmc/core/bus.c | 26 +++++++++++++++++++++++++- > 1 files changed, 25 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c > index 5d011a3..0517a91 100644 > --- a/drivers/mmc/core/bus.c > +++ b/drivers/mmc/core/bus.c > @@ -267,6 +267,7 @@ int mmc_add_card(struct mmc_card *card) > { > int ret; > const char *type; > + const char *uhs_bus_speed_mode = ""; > > dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), card->rca); > > @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) > break; > } > > + if (mmc_sd_card_uhs(card)) { > + switch (card->sd_bus_speed) { > + case UHS_SDR104_BUS_SPEED: > + uhs_bus_speed_mode = "SDR104 "; > + break; > + case UHS_SDR50_BUS_SPEED: > + uhs_bus_speed_mode = "SDR50 "; > + break; > + case UHS_DDR50_BUS_SPEED: > + uhs_bus_speed_mode = "DDR50 "; > + break; > + case UHS_SDR25_BUS_SPEED: > + uhs_bus_speed_mode = "SDR25 "; > + break; > + case UHS_SDR12_BUS_SPEED: > + uhs_bus_speed_mode = "SDR12 "; > + break; > + default: > + uhs_bus_speed_mode = ""; > + break; > + } > + } > if (mmc_host_is_spi(card->host)) { > pr_info("%s: new %s%s%s card on SPI\n", > mmc_hostname(card->host), > @@ -303,12 +326,13 @@ int mmc_add_card(struct mmc_card *card) > mmc_card_ddr_mode(card) ? "DDR " : "", > type); > } else { > - pr_info("%s: new %s%s%s%s card at address %04x\n", > + pr_info("%s: new %s%s%s%s%s card at address %04x\n", > mmc_hostname(card->host), > mmc_card_uhs(card) ? "ultra high speed " : > (mmc_card_highspeed(card) ? "high speed " : ""), > (mmc_card_hs200(card) ? "HS200 " : ""), > mmc_card_ddr_mode(card) ? "DDR " : "", > + uhs_bus_speed_mode, > type, card->rca); > } > > -- > 1.7.1.1 > > -- > Sent by a consultant of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-26 3:17 ` Aaron Lu @ 2012-03-26 6:16 ` Subhash Jadavani 2012-03-26 6:30 ` Subhash Jadavani 0 siblings, 1 reply; 7+ messages in thread From: Subhash Jadavani @ 2012-03-26 6:16 UTC (permalink / raw) To: 'Aaron Lu'; +Cc: linux-mmc, linux-arm-msm, arindam.nath > -----Original Message----- > From: linux-arm-msm-owner@vger.kernel.org [mailto:linux-arm-msm- > owner@vger.kernel.org] On Behalf Of Aaron Lu > Sent: Monday, March 26, 2012 8:47 AM > To: Subhash Jadavani > Cc: linux-mmc@vger.kernel.org; linux-arm-msm@vger.kernel.org; > arindam.nath@amd.com > Subject: Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card > > Hi Subhash, > > On Fri, Mar 23, 2012 at 11:26:36AM +0530, Subhash Jadavani wrote: > > When UHS-I card is detected also print the bus speed mode in which > > UHS-I card will be running. > > The patch looks correct to me, except that I' m not sure if this is needed. > /sys/kernel/debug/mmc/ios also has such info. Thanks for pointing it out. Actually we are already printing the HS200/DDR (for eMMC) bus speed mode along with card detected print. So why not bus speed mode for UHS-I cards. It really gives good impression to user what this card is capable of doing by just looking at this print. Correct we can this information from /sys/kernel/debug/mmc/ios but this needs extra effort than just looking at the kernel logs. Also note that mmc_ios_show() function is currently not updated to print the UHS-I bus speed modes in user readable format. We need to fix this as well probably as separate patch. Regards, Subhash > > -Aaron > > > > > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > > --- > > drivers/mmc/core/bus.c | 26 +++++++++++++++++++++++++- > > 1 files changed, 25 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index > > 5d011a3..0517a91 100644 > > --- a/drivers/mmc/core/bus.c > > +++ b/drivers/mmc/core/bus.c > > @@ -267,6 +267,7 @@ int mmc_add_card(struct mmc_card *card) { > > int ret; > > const char *type; > > + const char *uhs_bus_speed_mode = ""; > > > > dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card- > >host), > > card->rca); > > > > @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) > > break; > > } > > > > + if (mmc_sd_card_uhs(card)) { > > + switch (card->sd_bus_speed) { > > + case UHS_SDR104_BUS_SPEED: > > + uhs_bus_speed_mode = "SDR104 "; > > + break; > > + case UHS_SDR50_BUS_SPEED: > > + uhs_bus_speed_mode = "SDR50 "; > > + break; > > + case UHS_DDR50_BUS_SPEED: > > + uhs_bus_speed_mode = "DDR50 "; > > + break; > > + case UHS_SDR25_BUS_SPEED: > > + uhs_bus_speed_mode = "SDR25 "; > > + break; > > + case UHS_SDR12_BUS_SPEED: > > + uhs_bus_speed_mode = "SDR12 "; > > + break; > > + default: > > + uhs_bus_speed_mode = ""; > > + break; > > + } > > + } > > if (mmc_host_is_spi(card->host)) { > > pr_info("%s: new %s%s%s card on SPI\n", > > mmc_hostname(card->host), > > @@ -303,12 +326,13 @@ int mmc_add_card(struct mmc_card *card) > > mmc_card_ddr_mode(card) ? "DDR " : "", > > type); > > } else { > > - pr_info("%s: new %s%s%s%s card at address %04x\n", > > + pr_info("%s: new %s%s%s%s%s card at address %04x\n", > > mmc_hostname(card->host), > > mmc_card_uhs(card) ? "ultra high speed " : > > (mmc_card_highspeed(card) ? "high speed " : ""), > > (mmc_card_hs200(card) ? "HS200 " : ""), > > mmc_card_ddr_mode(card) ? "DDR " : "", > > + uhs_bus_speed_mode, > > type, card->rca); > > } > > > > -- > > 1.7.1.1 > > > > -- > > Sent by a consultant of the Qualcomm Innovation Center, Inc. > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum. > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@vger.kernel.org More > majordomo > > info at http://vger.kernel.org/majordomo-info.html > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-26 6:16 ` Subhash Jadavani @ 2012-03-26 6:30 ` Subhash Jadavani 2012-03-28 1:09 ` Aaron Lu 0 siblings, 1 reply; 7+ messages in thread From: Subhash Jadavani @ 2012-03-26 6:30 UTC (permalink / raw) To: 'Aaron Lu'; +Cc: linux-mmc, linux-arm-msm, arindam.nath > Also note that mmc_ios_show() function is currently not updated to print the > UHS-I bus speed modes in user readable format. We need to fix this as well > probably as separate patch. Aaron, Sorry, I just realized that I was looking at 3.0 kernel code. In mmc-next, I can see your patch which had updated mmc_ios_show() for printing ush bus speed modes in text format. So ignore this. > Actually we are already printing the HS200/DDR (for eMMC) bus speed mode > along with card detected print. So why not bus speed mode for UHS-I cards. > It really gives good impression to user what this card is capable of doing by > just looking at this print. > Correct we can this information from /sys/kernel/debug/mmc/ios but this > needs extra effort than just looking at the kernel logs. But still please check if this point makes sense? Regards, Subhash > -----Original Message----- > From: linux-arm-msm-owner@vger.kernel.org [mailto:linux-arm-msm- > owner@vger.kernel.org] On Behalf Of Subhash Jadavani > Sent: Monday, March 26, 2012 11:46 AM > To: 'Aaron Lu' > Cc: linux-mmc@vger.kernel.org; linux-arm-msm@vger.kernel.org; > arindam.nath@amd.com > Subject: RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card > > > > > -----Original Message----- > > From: linux-arm-msm-owner@vger.kernel.org [mailto:linux-arm-msm- > > owner@vger.kernel.org] On Behalf Of Aaron Lu > > Sent: Monday, March 26, 2012 8:47 AM > > To: Subhash Jadavani > > Cc: linux-mmc@vger.kernel.org; linux-arm-msm@vger.kernel.org; > > arindam.nath@amd.com > > Subject: Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I > > card > > > > Hi Subhash, > > > > On Fri, Mar 23, 2012 at 11:26:36AM +0530, Subhash Jadavani wrote: > > > When UHS-I card is detected also print the bus speed mode in which > > > UHS-I card will be running. > > > > The patch looks correct to me, except that I' m not sure if this is > needed. > > /sys/kernel/debug/mmc/ios also has such info. > > Thanks for pointing it out. > Actually we are already printing the HS200/DDR (for eMMC) bus speed mode > along with card detected print. So why not bus speed mode for UHS-I cards. > It really gives good impression to user what this card is capable of doing by > just looking at this print. > Correct we can this information from /sys/kernel/debug/mmc/ios but this > needs extra effort than just looking at the kernel logs. > > Also note that mmc_ios_show() function is currently not updated to print the > UHS-I bus speed modes in user readable format. We need to fix this as well > probably as separate patch. > > Regards, > Subhash > > > > > -Aaron > > > > > > > > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org> > > > --- > > > drivers/mmc/core/bus.c | 26 +++++++++++++++++++++++++- > > > 1 files changed, 25 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index > > > 5d011a3..0517a91 100644 > > > --- a/drivers/mmc/core/bus.c > > > +++ b/drivers/mmc/core/bus.c > > > @@ -267,6 +267,7 @@ int mmc_add_card(struct mmc_card *card) { > > > int ret; > > > const char *type; > > > + const char *uhs_bus_speed_mode = ""; > > > > > > dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card- > host), > > > card->rca); > > > > > > @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) > > > break; > > > } > > > > > > + if (mmc_sd_card_uhs(card)) { > > > + switch (card->sd_bus_speed) { > > > + case UHS_SDR104_BUS_SPEED: > > > + uhs_bus_speed_mode = "SDR104 "; > > > + break; > > > + case UHS_SDR50_BUS_SPEED: > > > + uhs_bus_speed_mode = "SDR50 "; > > > + break; > > > + case UHS_DDR50_BUS_SPEED: > > > + uhs_bus_speed_mode = "DDR50 "; > > > + break; > > > + case UHS_SDR25_BUS_SPEED: > > > + uhs_bus_speed_mode = "SDR25 "; > > > + break; > > > + case UHS_SDR12_BUS_SPEED: > > > + uhs_bus_speed_mode = "SDR12 "; > > > + break; > > > + default: > > > + uhs_bus_speed_mode = ""; > > > + break; > > > + } > > > + } > > > if (mmc_host_is_spi(card->host)) { > > > pr_info("%s: new %s%s%s card on SPI\n", > > > mmc_hostname(card->host), > > > @@ -303,12 +326,13 @@ int mmc_add_card(struct mmc_card *card) > > > mmc_card_ddr_mode(card) ? "DDR " : "", > > > type); > > > } else { > > > - pr_info("%s: new %s%s%s%s card at address %04x\n", > > > + pr_info("%s: new %s%s%s%s%s card at address %04x\n", > > > mmc_hostname(card->host), > > > mmc_card_uhs(card) ? "ultra high speed " : > > > (mmc_card_highspeed(card) ? "high speed " : ""), > > > (mmc_card_hs200(card) ? "HS200 " : ""), > > > mmc_card_ddr_mode(card) ? "DDR " : "", > > > + uhs_bus_speed_mode, > > > type, card->rca); > > > } > > > > > > -- > > > 1.7.1.1 > > > > > > -- > > > Sent by a consultant of the Qualcomm Innovation Center, Inc. > > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > > Forum. > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > > in the body of a message to majordomo@vger.kernel.org More > > majordomo > > > info at http://vger.kernel.org/majordomo-info.html > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" > in > > the body of a message to majordomo@vger.kernel.org More majordomo > info > > at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-26 6:30 ` Subhash Jadavani @ 2012-03-28 1:09 ` Aaron Lu 0 siblings, 0 replies; 7+ messages in thread From: Aaron Lu @ 2012-03-28 1:09 UTC (permalink / raw) To: Subhash Jadavani; +Cc: linux-mmc, linux-arm-msm, arindam.nath Hi, On Mon, Mar 26, 2012 at 12:00:27PM +0530, Subhash Jadavani wrote: > > Actually we are already printing the HS200/DDR (for eMMC) bus speed mode > > along with card detected print. So why not bus speed mode for UHS-I cards. > > It really gives good impression to user what this card is capable of doing > by > > just looking at this print. > > Correct we can this information from /sys/kernel/debug/mmc/ios but this > > needs extra effort than just looking at the kernel logs. > > But still please check if this point makes sense? > Yes, I think this makes sense. -Aaron ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-23 5:56 [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card Subhash Jadavani 2012-03-26 3:17 ` Aaron Lu @ 2012-03-26 6:25 ` Stephen Boyd 2012-04-01 3:55 ` Chris Ball 1 sibling, 1 reply; 7+ messages in thread From: Stephen Boyd @ 2012-03-26 6:25 UTC (permalink / raw) To: Subhash Jadavani; +Cc: linux-mmc, linux-arm-msm, arindam.nath On 3/22/2012 10:56 PM, Subhash Jadavani wrote: > @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) > break; > } > > + if (mmc_sd_card_uhs(card)) { > + switch (card->sd_bus_speed) { > + case UHS_SDR104_BUS_SPEED: > + uhs_bus_speed_mode = "SDR104 "; > + break; > + case UHS_SDR50_BUS_SPEED: > + uhs_bus_speed_mode = "SDR50 "; > + break; > + case UHS_DDR50_BUS_SPEED: > + uhs_bus_speed_mode = "DDR50 "; > + break; > + case UHS_SDR25_BUS_SPEED: > + uhs_bus_speed_mode = "SDR25 "; > + break; > + case UHS_SDR12_BUS_SPEED: > + uhs_bus_speed_mode = "SDR12 "; > + break; > + default: > + uhs_bus_speed_mode = ""; > + break; > + } > This could be better code with an array: static char *speeds[] = { [UHS_SDR104_BUS_SPEED] = "SDR104", [UHS_SDR50_BUS_SPEED] = "SDR50", [UHS_SDR50_BUS_SPEED] = "DDR50", ... }; -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card 2012-03-26 6:25 ` Stephen Boyd @ 2012-04-01 3:55 ` Chris Ball 0 siblings, 0 replies; 7+ messages in thread From: Chris Ball @ 2012-04-01 3:55 UTC (permalink / raw) To: Stephen Boyd; +Cc: Subhash Jadavani, linux-mmc, linux-arm-msm, arindam.nath Hi Subhash, On Mon, Mar 26 2012, Stephen Boyd wrote: > On 3/22/2012 10:56 PM, Subhash Jadavani wrote: >> @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) >> break; >> } >> >> + if (mmc_sd_card_uhs(card)) { >> + switch (card->sd_bus_speed) { >> + case UHS_SDR104_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR104 "; >> + break; >> + case UHS_SDR50_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR50 "; >> + break; >> + case UHS_DDR50_BUS_SPEED: >> + uhs_bus_speed_mode = "DDR50 "; >> + break; >> + case UHS_SDR25_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR25 "; >> + break; >> + case UHS_SDR12_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR12 "; >> + break; >> + default: >> + uhs_bus_speed_mode = ""; >> + break; >> + } >> > > This could be better code with an array: > > static char *speeds[] = { > [UHS_SDR104_BUS_SPEED] = "SDR104", > [UHS_SDR50_BUS_SPEED] = "SDR50", > [UHS_SDR50_BUS_SPEED] = "DDR50", > ... > }; I'm happy to take the patch in general (I agree that having bus speed in dmesg is very useful for analyzing bug reports), but let's use Stephen's suggestion above. Please resend. Thanks! - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-04-01 3:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-03-23 5:56 [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card Subhash Jadavani 2012-03-26 3:17 ` Aaron Lu 2012-03-26 6:16 ` Subhash Jadavani 2012-03-26 6:30 ` Subhash Jadavani 2012-03-28 1:09 ` Aaron Lu 2012-03-26 6:25 ` Stephen Boyd 2012-04-01 3:55 ` Chris Ball
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.