From: "Michael S. Tsirkin" <mst@redhat.com> To: Tejun Heo <tj@kernel.org> Cc: Ren Mingxin <renmx@cn.fujitsu.com>, Jens Axboe <axboe@kernel.dk>, Rusty Russell <rusty@rustcorp.com.au>, LKML <linux-kernel@vger.kernel.org>, SCSI <linux-scsi@vger.kernel.org>, KVM <kvm@vger.kernel.org>, VIRTUAL <virtualization@lists.linux-foundation.org> Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Date: Mon, 2 Apr 2012 10:15:31 +0300 [thread overview] Message-ID: <20120402071531.GE30360@redhat.com> (raw) In-Reply-To: <20120330152606.GB28934@google.com> On Fri, Mar 30, 2012 at 08:26:06AM -0700, Tejun Heo wrote: > On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote: > > The current virtblk's naming algorithm only supports 263 disks. > > If there are mass of virtblks(exceeding 263), there will be disks > > with the same name. > > > > By renaming "sd_format_disk_name()" to "disk_name_format()" > > and moving it into block core, virtio_blk can use this function to > > support mass of disks. > > > > Signed-off-by: Ren Mingxin <renmx@cn.fujitsu.com> > > I guess it's already way too late but why couldn't they have been > named vdD-P where both D and P are integers denoting disk number and > partition number? Yes they could and yes it's way too late to change device names for virtio - if we did this will break countless setups. > [sh]dX's were created when there weren't supposed > to be too many disks, so we had to come up with the horrible alphabet > based numbering scheme but vd is new enough. I mean, naming is one > thing but who wants to figure out which sequence is or guess what > comes next vdzz9? :( > > If we're gonna move it to block layer, let's add big blinking red > comment saying "don't ever use it for any new driver". > > Thanks. Right. virtio would have to use the legacy one though. > -- > tejun
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Tejun Heo <tj@kernel.org> Cc: Jens Axboe <axboe@kernel.dk>, KVM <kvm@vger.kernel.org>, SCSI <linux-scsi@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, VIRTUAL <virtualization@lists.linux-foundation.org>, Ren Mingxin <renmx@cn.fujitsu.com> Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Date: Mon, 2 Apr 2012 10:15:31 +0300 [thread overview] Message-ID: <20120402071531.GE30360@redhat.com> (raw) In-Reply-To: <20120330152606.GB28934@google.com> On Fri, Mar 30, 2012 at 08:26:06AM -0700, Tejun Heo wrote: > On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote: > > The current virtblk's naming algorithm only supports 263 disks. > > If there are mass of virtblks(exceeding 263), there will be disks > > with the same name. > > > > By renaming "sd_format_disk_name()" to "disk_name_format()" > > and moving it into block core, virtio_blk can use this function to > > support mass of disks. > > > > Signed-off-by: Ren Mingxin <renmx@cn.fujitsu.com> > > I guess it's already way too late but why couldn't they have been > named vdD-P where both D and P are integers denoting disk number and > partition number? Yes they could and yes it's way too late to change device names for virtio - if we did this will break countless setups. > [sh]dX's were created when there weren't supposed > to be too many disks, so we had to come up with the horrible alphabet > based numbering scheme but vd is new enough. I mean, naming is one > thing but who wants to figure out which sequence is or guess what > comes next vdzz9? :( > > If we're gonna move it to block layer, let's add big blinking red > comment saying "don't ever use it for any new driver". > > Thanks. Right. virtio would have to use the legacy one though. > -- > tejun
next prev parent reply other threads:[~2012-04-02 7:15 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-30 9:50 [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Ren Mingxin 2012-03-30 9:52 ` [PATCH 1/4] block: add function disk_name_format() into block core Ren Mingxin 2012-03-30 9:52 ` Ren Mingxin 2012-03-30 9:53 ` [PATCH 2/4] scsi: replace sd_format_disk_name() to disk_name_format() Ren Mingxin 2012-03-30 9:53 ` Ren Mingxin 2012-03-30 9:53 ` [PATCH 3/4] block: replace rssd_disk_name_format() " Ren Mingxin 2012-03-30 9:53 ` Ren Mingxin 2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2] 2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2] 2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2] 2012-04-02 1:21 ` Ren Mingxin 2012-04-02 1:21 ` Ren Mingxin 2012-04-02 1:21 ` Ren Mingxin 2012-03-30 9:53 ` [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Ren Mingxin 2012-03-30 9:53 ` Ren Mingxin 2012-03-30 11:22 ` Asias He 2012-03-30 11:22 ` Asias He 2012-03-31 1:14 ` Ren Mingxin 2012-03-31 1:14 ` Ren Mingxin 2012-03-31 3:03 ` Asias He 2012-03-31 3:03 ` Asias He 2012-03-30 15:26 ` Tejun Heo 2012-03-30 15:26 ` Tejun Heo 2012-03-30 15:28 ` Tejun Heo 2012-03-30 15:28 ` Tejun Heo 2012-04-02 1:19 ` Ren Mingxin 2012-04-02 1:19 ` Ren Mingxin 2012-04-02 7:20 ` Michael S. Tsirkin 2012-04-02 7:20 ` Michael S. Tsirkin 2012-04-02 18:52 ` Tejun Heo 2012-04-02 18:52 ` Tejun Heo 2012-04-02 18:56 ` James Bottomley 2012-04-02 19:00 ` Tejun Heo 2012-04-02 19:00 ` Tejun Heo 2012-04-04 8:01 ` Michael S. Tsirkin 2012-04-04 8:01 ` Michael S. Tsirkin 2012-04-09 3:47 ` Ren Mingxin 2012-04-09 3:47 ` Ren Mingxin 2012-04-09 7:33 ` Michael S. Tsirkin 2012-04-09 7:33 ` Michael S. Tsirkin 2012-04-09 7:50 ` Michael S. Tsirkin 2012-04-09 7:50 ` Michael S. Tsirkin 2012-04-02 18:56 ` James Bottomley 2012-03-30 15:38 ` Tejun Heo 2012-03-30 15:38 ` Tejun Heo 2012-04-02 1:18 ` Ren Mingxin 2012-04-02 1:18 ` Ren Mingxin 2012-04-02 7:15 ` Michael S. Tsirkin [this message] 2012-04-02 7:15 ` Michael S. Tsirkin 2012-04-12 20:17 ` Jeff Garzik 2012-04-12 20:17 ` Jeff Garzik 2012-03-30 9:56 ` [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() James Bottomley 2012-03-30 10:10 ` Ren Mingxin 2012-03-30 10:10 ` Ren Mingxin 2012-03-30 9:56 ` James Bottomley 2012-04-01 11:20 ` Michael S. Tsirkin 2012-04-01 11:20 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120402071531.GE30360@redhat.com \ --to=mst@redhat.com \ --cc=axboe@kernel.dk \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=renmx@cn.fujitsu.com \ --cc=rusty@rustcorp.com.au \ --cc=tj@kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.