From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ren Mingxin <renmx@cn.fujitsu.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
SCSI <linux-scsi@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
VIRTUAL <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
Date: Sun, 1 Apr 2012 14:20:26 +0300 [thread overview]
Message-ID: <20120401112025.GB23773@redhat.com> (raw)
In-Reply-To: <4F7581D4.4040301@cn.fujitsu.com>
On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote:
>
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
I see there are some responses about naming and comments,
so that would need to be fixed.
Besides this, Jens, would you like to take the patchset
through your tree or prefer for me to merge it through virtio tree?
Block tree seems more appropriate, right?
Also this is a bugfix technically since it fixes setups
with a ton of disks, so 3.4 material?
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
> block: replace rssd_disk_name_format() to disk_name_format()
> virtio_blk: use disk_name_format() to support mass of disks naming
>
> block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
> drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
> drivers/block/virtio_blk.c | 13 ----------
> drivers/scsi/sd.c | 48 -------------------------------------
> include/linux/genhd.h | 2 +
> 5 files changed, 54 insertions(+), 91 deletions(-)
>
> Any comment will be appreciated.
>
> Thanks,
> Ren
>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ren Mingxin <renmx@cn.fujitsu.com>
Cc: Jens Axboe <axboe@kernel.dk>, KVM <kvm@vger.kernel.org>,
SCSI <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
VIRTUAL <virtualization@lists.linux-foundation.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
Date: Sun, 1 Apr 2012 14:20:26 +0300 [thread overview]
Message-ID: <20120401112025.GB23773@redhat.com> (raw)
In-Reply-To: <4F7581D4.4040301@cn.fujitsu.com>
On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote:
>
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
I see there are some responses about naming and comments,
so that would need to be fixed.
Besides this, Jens, would you like to take the patchset
through your tree or prefer for me to merge it through virtio tree?
Block tree seems more appropriate, right?
Also this is a bugfix technically since it fixes setups
with a ton of disks, so 3.4 material?
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
> block: replace rssd_disk_name_format() to disk_name_format()
> virtio_blk: use disk_name_format() to support mass of disks naming
>
> block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
> drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
> drivers/block/virtio_blk.c | 13 ----------
> drivers/scsi/sd.c | 48 -------------------------------------
> include/linux/genhd.h | 2 +
> 5 files changed, 54 insertions(+), 91 deletions(-)
>
> Any comment will be appreciated.
>
> Thanks,
> Ren
>
next prev parent reply other threads:[~2012-04-01 11:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 9:50 [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Ren Mingxin
2012-03-30 9:52 ` [PATCH 1/4] block: add function disk_name_format() into block core Ren Mingxin
2012-03-30 9:52 ` Ren Mingxin
2012-03-30 9:53 ` [PATCH 2/4] scsi: replace sd_format_disk_name() to disk_name_format() Ren Mingxin
2012-03-30 9:53 ` Ren Mingxin
2012-03-30 9:53 ` [PATCH 3/4] block: replace rssd_disk_name_format() " Ren Mingxin
2012-03-30 9:53 ` Ren Mingxin
2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]
2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]
2012-03-30 23:54 ` Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]
2012-04-02 1:21 ` Ren Mingxin
2012-04-02 1:21 ` Ren Mingxin
2012-04-02 1:21 ` Ren Mingxin
2012-03-30 9:53 ` [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Ren Mingxin
2012-03-30 9:53 ` Ren Mingxin
2012-03-30 11:22 ` Asias He
2012-03-30 11:22 ` Asias He
2012-03-31 1:14 ` Ren Mingxin
2012-03-31 1:14 ` Ren Mingxin
2012-03-31 3:03 ` Asias He
2012-03-31 3:03 ` Asias He
2012-03-30 15:26 ` Tejun Heo
2012-03-30 15:26 ` Tejun Heo
2012-03-30 15:28 ` Tejun Heo
2012-03-30 15:28 ` Tejun Heo
2012-04-02 1:19 ` Ren Mingxin
2012-04-02 1:19 ` Ren Mingxin
2012-04-02 7:20 ` Michael S. Tsirkin
2012-04-02 7:20 ` Michael S. Tsirkin
2012-04-02 18:52 ` Tejun Heo
2012-04-02 18:52 ` Tejun Heo
2012-04-02 18:56 ` James Bottomley
2012-04-02 19:00 ` Tejun Heo
2012-04-02 19:00 ` Tejun Heo
2012-04-04 8:01 ` Michael S. Tsirkin
2012-04-04 8:01 ` Michael S. Tsirkin
2012-04-09 3:47 ` Ren Mingxin
2012-04-09 3:47 ` Ren Mingxin
2012-04-09 7:33 ` Michael S. Tsirkin
2012-04-09 7:33 ` Michael S. Tsirkin
2012-04-09 7:50 ` Michael S. Tsirkin
2012-04-09 7:50 ` Michael S. Tsirkin
2012-04-02 18:56 ` James Bottomley
2012-03-30 15:38 ` Tejun Heo
2012-03-30 15:38 ` Tejun Heo
2012-04-02 1:18 ` Ren Mingxin
2012-04-02 1:18 ` Ren Mingxin
2012-04-02 7:15 ` Michael S. Tsirkin
2012-04-02 7:15 ` Michael S. Tsirkin
2012-04-12 20:17 ` Jeff Garzik
2012-04-12 20:17 ` Jeff Garzik
2012-03-30 9:56 ` [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() James Bottomley
2012-03-30 10:10 ` Ren Mingxin
2012-03-30 10:10 ` Ren Mingxin
2012-03-30 9:56 ` James Bottomley
2012-04-01 11:20 ` Michael S. Tsirkin [this message]
2012-04-01 11:20 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2012-03-30 9:50 Ren Mingxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401112025.GB23773@redhat.com \
--to=mst@redhat.com \
--cc=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.