From: Russell King - ARM Linux <linux@arm.linux.org.uk> To: Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Alexander Shiyan <shc_work@mail.ru>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] ARM clps711x: Added Cirrus Logic EP7312 CPU variant Date: Sat, 21 Apr 2012 13:20:45 +0100 [thread overview] Message-ID: <20120421122044.GF24211@n2100.arm.linux.org.uk> (raw) In-Reply-To: <201204211211.36273.arnd@arndb.de> On Sat, Apr 21, 2012 at 12:11:35PM +0000, Arnd Bergmann wrote: > On Saturday 21 April 2012, Russell King - ARM Linux wrote: > > That's where we used to put truely hardware dependent stuff, rather than > > machine type stuff when the structure was first implemented. At that time > > we had a number of different mach-* directories wanting to share things > > like the acorn IOC/IOMD stuff, and there's also sharing of definitions > > between CLPS711x and EP93xx. > > > > That was long before we invented the plat-* stuff - but even that doesn't > > actually cover what asm/hardware does - eg, the SA1111 stuff shared > > between SA11x0 and PXA. > > Ah, thanks for the explanation. > > Since the clps7111 based asm/hardware/*.h files are not shared with ep93xx, > I guess it makes sense to move them to mach-clps711x/include/mach/*.h as part of > this cleanup series, right? Yes. > Out of these, only the first one is used in two places outside of > arch/arm/mach-clps711x, the serial and the fb driver, which could > be changed to use mach/hardware.h instead. The headers still have to end up being in an accessible place, and having drivers include the minimum required is a good idea. Merely moving them into include/mach and updating the include statements as far as I'd go. (and I've never liked the idea of mach/hardware.h being an "include the world for this platform" header file.)
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/17] ARM clps711x: Added Cirrus Logic EP7312 CPU variant Date: Sat, 21 Apr 2012 13:20:45 +0100 [thread overview] Message-ID: <20120421122044.GF24211@n2100.arm.linux.org.uk> (raw) In-Reply-To: <201204211211.36273.arnd@arndb.de> On Sat, Apr 21, 2012 at 12:11:35PM +0000, Arnd Bergmann wrote: > On Saturday 21 April 2012, Russell King - ARM Linux wrote: > > That's where we used to put truely hardware dependent stuff, rather than > > machine type stuff when the structure was first implemented. At that time > > we had a number of different mach-* directories wanting to share things > > like the acorn IOC/IOMD stuff, and there's also sharing of definitions > > between CLPS711x and EP93xx. > > > > That was long before we invented the plat-* stuff - but even that doesn't > > actually cover what asm/hardware does - eg, the SA1111 stuff shared > > between SA11x0 and PXA. > > Ah, thanks for the explanation. > > Since the clps7111 based asm/hardware/*.h files are not shared with ep93xx, > I guess it makes sense to move them to mach-clps711x/include/mach/*.h as part of > this cleanup series, right? Yes. > Out of these, only the first one is used in two places outside of > arch/arm/mach-clps711x, the serial and the fb driver, which could > be changed to use mach/hardware.h instead. The headers still have to end up being in an accessible place, and having drivers include the minimum required is a good idea. Merely moving them into include/mach and updating the include statements as far as I'd go. (and I've never liked the idea of mach/hardware.h being an "include the world for this platform" header file.)
next prev parent reply other threads:[~2012-04-21 12:21 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-21 9:11 clps711x patchset Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 01/17] ARM clps711x: Cleanup: Rename ARCH_EP7211 and ARCH_EP7212 to SOC_xxx Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 02/17] ARM clps711x: Added Cirrus Logic EP7312 CPU variant Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 11:21 ` Arnd Bergmann 2012-04-21 11:21 ` Arnd Bergmann 2012-04-21 11:30 ` Re[2]: " Alexander Shiyan 2012-04-21 11:30 ` Alexander Shiyan 2012-04-21 11:48 ` Russell King - ARM Linux 2012-04-21 11:48 ` Russell King - ARM Linux 2012-04-21 12:11 ` Arnd Bergmann 2012-04-21 12:11 ` Arnd Bergmann 2012-04-21 12:20 ` Russell King - ARM Linux [this message] 2012-04-21 12:20 ` Russell King - ARM Linux 2012-04-22 13:58 ` Arnd Bergmann 2012-04-22 13:58 ` Arnd Bergmann 2012-04-22 14:13 ` Russell King - ARM Linux 2012-04-22 14:13 ` Russell King - ARM Linux 2012-04-22 14:24 ` Re[2]: " Alexander Shiyan 2012-04-22 14:24 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 03/17] ARM clps711x: Selecting CPU-variant automatically for clps711x targets Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 04/17] ARM clps711x: Using a single definition for virtual address register Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 05/17] ARM clps711x: Added missing definitions for PORT C Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 06/17] ARM clps711x: Remove now unused cs89712 board header Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 07/17] ARM clps711x: Remove unused includes Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 08/17] ARM clps711x: Cleanup: remove unused definitions for ep_readl/ep_writel Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 09/17] ARM clps711x: Using a single definition for physical address register Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 10/17] ARM clps711x: Address register renaming to reflect the fact that the name is the same for all arch Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 11/17] ARM clps711x: Move definitions of register address in one unit Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 12/17] ARM clps711x: Simple optimise debug_macro by removing one NOP Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 10:46 ` Russell King - ARM Linux 2012-04-21 10:46 ` Russell King - ARM Linux 2012-04-21 10:50 ` Re[2]: " Alexander Shiyan 2012-04-21 10:50 ` Alexander Shiyan 2012-04-21 11:18 ` Arnd Bergmann 2012-04-21 11:18 ` Arnd Bergmann 2012-04-21 11:49 ` Arnd Bergmann 2012-04-21 11:49 ` Arnd Bergmann 2012-04-21 9:11 ` [PATCH 13/17] ARM clps711x: Removed unused header mach/time.h Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 14/17] ARM clps711x: Do not mask interrupts in ack procedure Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 15/17] ARM clps711x: Removed unused definitions from mach/irqs.h Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 16/17] ARM clps711x: Replaced frequency settings to definition Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 9:11 ` [PATCH 17/17] ARM clps711x: Make select CPU spees as KConfig option Alexander Shiyan 2012-04-21 9:11 ` Alexander Shiyan 2012-04-21 11:40 ` clps711x patchset Arnd Bergmann 2012-04-21 11:40 ` Arnd Bergmann 2012-04-21 12:04 ` Re[2]: " Alexander Shiyan 2012-04-21 12:04 ` Alexander Shiyan 2012-04-21 12:14 ` Arnd Bergmann 2012-04-21 12:14 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120421122044.GF24211@n2100.arm.linux.org.uk \ --to=linux@arm.linux.org.uk \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=shc_work@mail.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.