All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com,
	linux@arm.linux.org.uk, lrg@ti.com, swarren@nvidia.com,
	olof@lixom.net, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH V3 2/4] regulator: tps62360: add dt support
Date: Fri, 11 May 2012 15:58:34 +0100	[thread overview]
Message-ID: <20120511145833.GG3960@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336718325-8372-3-git-send-email-ldewangan@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On Fri, May 11, 2012 at 12:08:43PM +0530, Laxman Dewangan wrote:

This looks good overall but I do have a few things with the binding.

> +Optional properties:
> +- ti,enable-force-pwm: Enable force PWM mode. This is boolean value.

Hrm, this is fairly generic - it's REGULATOR_MODE_ACTIVE.  But I'm a bit
unsure about how generic exposing it is in bindings since it's often
dynamic in the running system, we've really not got any mainline
examples of something setting a mode.  With modern regulators the mode
detection stuff in the hardware is generally good enough that there's no
benefit from doing this, it's suprising to actually see systems that
benefit.

> +- ti,enable-vout-discharge: Enable output discharge. This is boolean value.

This I think we should definitely add a framework feature for this and
make into a generic property, it's a very standard feature and more
normally set unconditionally.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-05-11 14:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  6:38 [PATCH V3 0/4] regulator: tps62360: support dts and enable for tegra-cardhu Laxman Dewangan
2012-05-11  6:38 ` Laxman Dewangan
2012-05-11  6:38 ` [PATCH V3 1/4] regulator: tps62360: make init_data of platform data to pointer Laxman Dewangan
2012-05-11  6:38   ` Laxman Dewangan
2012-05-11 15:09   ` Mark Brown
2012-05-11  6:38 ` [PATCH V3 2/4] regulator: tps62360: add dt support Laxman Dewangan
2012-05-11  6:38   ` Laxman Dewangan
2012-05-11 14:58   ` Mark Brown [this message]
     [not found]     ` <20120511145833.GG3960-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 15:35       ` Laxman Dewangan
2012-05-11 15:35         ` Laxman Dewangan
     [not found]         ` <4FAD31A5.7090006-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-11 21:30           ` Mark Brown
2012-05-11 21:30             ` Mark Brown
2012-05-20  7:19             ` Laxman Dewangan
2012-05-20  7:19               ` Laxman Dewangan
2012-05-11 20:36   ` Mark Brown
2012-05-11  6:38 ` [PATCH V3 3/4] ARM: tegra: config: enable REGULATOR_TPS62360 Laxman Dewangan
2012-05-11  6:38   ` Laxman Dewangan
2012-05-11  6:38 ` [PATCH V3 4/4] ARM: dt: tegra: cardhu: register core regulator tps62360 Laxman Dewangan
2012-05-11  6:38   ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511145833.GG3960@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=ldewangan@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lrg@ti.com \
    --cc=olof@lixom.net \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.