From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"lrg@ti.com" <lrg@ti.com>, Stephen Warren <swarren@nvidia.com>,
"olof@lixom.net" <olof@lixom.net>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V3 2/4] regulator: tps62360: add dt support
Date: Sun, 20 May 2012 12:49:11 +0530 [thread overview]
Message-ID: <4FB89AEF.3080107@nvidia.com> (raw)
In-Reply-To: <20120511213001.GD29835@opensource.wolfsonmicro.com>
On Saturday 12 May 2012 03:00 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Fri, May 11, 2012 at 09:05:01PM +0530, Laxman Dewangan wrote:
>
>> I think this is not require to enable always otherwise there may be
>> power dissipation from this path always, just when we off the rail
>> (disable rail or when go to shutdown so that the voltage output can
>> go down faster).
>> Should we add "unsigned en_discharge:1" in regulator init data but
>> did not get how core driver can use this flag specially when
>> shutdown?
> Oh, now you say this I think I remember discussing this with you before!
> This is pretty unusual for such hardware. Normally there's something in
> the digital block so that the discharge is only enabled if the regulator
> is disabled, if it's enabled then the discharge would automatically be
> taken off since actively discharging while enabled doesn't make sense
> and may in fact be actively harmful.
>
Just to share here with our new pmu which we got recently, the
discharge path behavior is exactly same as what Mark mentioned
It need to be enable always. The pmu auto disable the DISC path in
normal operation so there is no power dissipation but when it detects
the en_bit is written 0 or any external control is making the rail to be
off, it automatically turn on the path so that ramp-down can happen faster.
Just we need to enable this always.
> If the hardware doesn't do that then I'd expect the driver to take care
> of this if it implements the framework feature (once the framework
> feature is added).
next prev parent reply other threads:[~2012-05-20 7:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:38 [PATCH V3 0/4] regulator: tps62360: support dts and enable for tegra-cardhu Laxman Dewangan
2012-05-11 6:38 ` Laxman Dewangan
2012-05-11 6:38 ` [PATCH V3 1/4] regulator: tps62360: make init_data of platform data to pointer Laxman Dewangan
2012-05-11 6:38 ` Laxman Dewangan
2012-05-11 15:09 ` Mark Brown
2012-05-11 6:38 ` [PATCH V3 2/4] regulator: tps62360: add dt support Laxman Dewangan
2012-05-11 6:38 ` Laxman Dewangan
2012-05-11 14:58 ` Mark Brown
[not found] ` <20120511145833.GG3960-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-11 15:35 ` Laxman Dewangan
2012-05-11 15:35 ` Laxman Dewangan
[not found] ` <4FAD31A5.7090006-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-11 21:30 ` Mark Brown
2012-05-11 21:30 ` Mark Brown
2012-05-20 7:19 ` Laxman Dewangan [this message]
2012-05-20 7:19 ` Laxman Dewangan
2012-05-11 20:36 ` Mark Brown
2012-05-11 6:38 ` [PATCH V3 3/4] ARM: tegra: config: enable REGULATOR_TPS62360 Laxman Dewangan
2012-05-11 6:38 ` Laxman Dewangan
2012-05-11 6:38 ` [PATCH V3 4/4] ARM: dt: tegra: cardhu: register core regulator tps62360 Laxman Dewangan
2012-05-11 6:38 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB89AEF.3080107@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.