All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org,
	ppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (powerpc related)
Date: Thu, 21 Jun 2012 21:13:54 +0930	[thread overview]
Message-ID: <20120621114354.GG20973@bubble.grove.modra.org> (raw)
In-Reply-To: <20120621104839.GE20973@bubble.grove.modra.org>

On Thu, Jun 21, 2012 at 08:18:39PM +0930, Alan Modra wrote:
> Linker bug.  That's not a sibling call, but a normal function return
> via an out-of-line register restore function.

I couldn't see how this might be occurring, then I remembered the
kernel has this horrible practise of using ld -r to package object
files.  So linker generated functions might be munged together with
other functions.  Does this help?  (It won't if the kernel is
providing its own save/restore functions.)

Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.387
diff -u -p -r1.387 elf64-ppc.c
@@ -6494,9 +6494,10 @@ ppc64_elf_func_desc_adjust (bfd *obfd AT
 
   /* Provide any missing _save* and _rest* functions.  */
   htab->sfpr->size = 0;
-  for (i = 0; i < sizeof (funcs) / sizeof (funcs[0]); i++)
-    if (!sfpr_define (info, &funcs[i]))
-      return FALSE;
+  if (!info->relocatable)
+    for (i = 0; i < sizeof (funcs) / sizeof (funcs[0]); i++)
+      if (!sfpr_define (info, &funcs[i]))
+	return FALSE;
 
   elf_link_hash_traverse (&htab->elf, func_desc_adjust, info);
 


-- 
Alan Modra
Australia Development Lab, IBM

WARNING: multiple messages have this Message-ID (diff)
From: Alan Modra <amodra@gmail.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-next@vger.kernel.org,
	ppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: build failure after merge of the final tree (powerpc related)
Date: Thu, 21 Jun 2012 21:13:54 +0930	[thread overview]
Message-ID: <20120621114354.GG20973@bubble.grove.modra.org> (raw)
In-Reply-To: <20120621104839.GE20973@bubble.grove.modra.org>

On Thu, Jun 21, 2012 at 08:18:39PM +0930, Alan Modra wrote:
> Linker bug.  That's not a sibling call, but a normal function return
> via an out-of-line register restore function.

I couldn't see how this might be occurring, then I remembered the
kernel has this horrible practise of using ld -r to package object
files.  So linker generated functions might be munged together with
other functions.  Does this help?  (It won't if the kernel is
providing its own save/restore functions.)

Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.387
diff -u -p -r1.387 elf64-ppc.c
@@ -6494,9 +6494,10 @@ ppc64_elf_func_desc_adjust (bfd *obfd AT
 
   /* Provide any missing _save* and _rest* functions.  */
   htab->sfpr->size = 0;
-  for (i = 0; i < sizeof (funcs) / sizeof (funcs[0]); i++)
-    if (!sfpr_define (info, &funcs[i]))
-      return FALSE;
+  if (!info->relocatable)
+    for (i = 0; i < sizeof (funcs) / sizeof (funcs[0]); i++)
+      if (!sfpr_define (info, &funcs[i]))
+	return FALSE;
 
   elf_link_hash_traverse (&htab->elf, func_desc_adjust, info);
 


-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2012-06-21 11:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20  7:50 linux-next: build failure after merge of the final tree (powerpc related) Stephen Rothwell
2012-06-20  7:50 ` Stephen Rothwell
2012-06-20 10:09 ` Benjamin Herrenschmidt
2012-06-20 10:09   ` Benjamin Herrenschmidt
2012-06-21  5:36 ` Michael Ellerman
2012-06-21  5:36   ` Michael Ellerman
2012-06-21  6:24   ` Benjamin Herrenschmidt
2012-06-21  7:07     ` Michael Ellerman
2012-06-21  7:07       ` Michael Ellerman
2012-06-21  7:07       ` Michael Ellerman
2012-06-21  7:38       ` Michael Ellerman
2012-06-21  7:38         ` Michael Ellerman
2012-06-21  7:38         ` Michael Ellerman
2012-06-21 10:48         ` Alan Modra
2012-06-21 10:48           ` Alan Modra
2012-06-21 11:43           ` Alan Modra [this message]
2012-06-21 11:43             ` Alan Modra
2012-06-22  0:39             ` Michael Ellerman
2012-06-22  0:39               ` Michael Ellerman
2012-06-21  7:29   ` Gabriel Paubert
  -- strict thread matches above, loose matches on Subject: below --
2011-12-28  8:49 Stephen Rothwell
2011-12-28  8:49 ` Stephen Rothwell
2011-12-28  8:49 ` Stephen Rothwell
2011-12-28 10:32 ` Benjamin Herrenschmidt
2011-12-28 10:32   ` Benjamin Herrenschmidt
2012-01-02  8:25   ` Grant Likely
2012-01-02  8:25     ` Grant Likely
2012-01-02  8:39     ` Grant Likely
2012-01-02  8:39       ` Grant Likely
2010-09-03  3:24 Stephen Rothwell
2010-09-03  3:24 ` Stephen Rothwell
2010-09-17  4:27 ` Stephen Rothwell
2010-09-17  4:27   ` Stephen Rothwell
2010-07-16  7:19 Stephen Rothwell
2010-07-16  7:19 ` Stephen Rothwell
2010-07-16  7:19 ` Stephen Rothwell
2010-07-19  0:15 ` Benjamin Herrenschmidt
2010-07-19  0:15   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621114354.GG20973@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.