From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Benoit Cousson <b-cousson@ti.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: linux-next: build failure after merge of the final tree (powerpc related)
Date: Mon, 2 Jan 2012 01:39:06 -0700 [thread overview]
Message-ID: <CACxGe6txjt62u8fm8UBEfBDHmftgXO0XJJKQmAmh2Cy86ZfRaA@mail.gmail.com> (raw)
In-Reply-To: <20120102082514.GG18381@ponder.secretlab.ca>
On Mon, Jan 2, 2012 at 1:25 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Wed, Dec 28, 2011 at 09:32:14PM +1100, Benjamin Herrenschmidt wrote:
>> On Wed, 2011-12-28 at 19:49 +1100, Stephen Rothwell wrote:
>> > Hi ,
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > kernel/built-in.o: In function `irq_dispose_mapping':
>> > (.opd+0x159f0): multiple definition of `irq_dispose_mapping'
>> > arch/powerpc/kernel/built-in.o:(.opd+0x960): first defined here
>> > kernel/built-in.o: In function `irq_create_of_mapping':
>> > (.opd+0x15a20): multiple definition of `irq_create_of_mapping'
>> > arch/powerpc/kernel/built-in.o:(.opd+0x9a8): first defined here
>> > kernel/built-in.o: In function `.irq_create_of_mapping':
>> > (.text+0x147030): multiple definition of `.irq_create_of_mapping'
>> > arch/powerpc/kernel/built-in.o:(.text+0x9de0): first defined here
>> > kernel/built-in.o: In function `.irq_dispose_mapping':
>> > (.text+0x146f4c): multiple definition of `.irq_dispose_mapping'
>> > arch/powerpc/kernel/built-in.o:(.text+0x9684): first defined here
>> >
>> > I am not sure what caused this. And have just left it broken.
>>
>> Grant, is your irq remapper misbehaving ?
>
> Hmmmm, that's odd. I've not touched it. I'll investigate.
It looks like CONFIG_IRQ_DOMAIN is getting selected by TWL4030_CORE.
Drivers must not select that config symbol. It looks like commit
da28adbd (mfd: twl-core: Add initial DT support for twl4030/twl6030)
is the culprit.
The following patch should solve the problem:
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 13c468e..e43a570 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -200,8 +200,7 @@ config MENELAUS
config TWL4030_CORE
bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
- depends on I2C=y && GENERIC_HARDIRQS
- select IRQ_DOMAIN
+ depends on I2C=y && GENERIC_HARDIRQS && IRQ_DOMAIN
help
Say yes here if you have TWL4030 / TWL6030 family chip on your board.
This core driver provides register access and IRQ handling
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Benoit Cousson <b-cousson@ti.com>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: linux-next: build failure after merge of the final tree (powerpc related)
Date: Mon, 2 Jan 2012 01:39:06 -0700 [thread overview]
Message-ID: <CACxGe6txjt62u8fm8UBEfBDHmftgXO0XJJKQmAmh2Cy86ZfRaA@mail.gmail.com> (raw)
In-Reply-To: <20120102082514.GG18381@ponder.secretlab.ca>
On Mon, Jan 2, 2012 at 1:25 AM, Grant Likely <grant.likely@secretlab.ca> wr=
ote:
> On Wed, Dec 28, 2011 at 09:32:14PM +1100, Benjamin Herrenschmidt wrote:
>> On Wed, 2011-12-28 at 19:49 +1100, Stephen Rothwell wrote:
>> > Hi ,
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > kernel/built-in.o: In function `irq_dispose_mapping':
>> > (.opd+0x159f0): multiple definition of `irq_dispose_mapping'
>> > arch/powerpc/kernel/built-in.o:(.opd+0x960): first defined here
>> > kernel/built-in.o: In function `irq_create_of_mapping':
>> > (.opd+0x15a20): multiple definition of `irq_create_of_mapping'
>> > arch/powerpc/kernel/built-in.o:(.opd+0x9a8): first defined here
>> > kernel/built-in.o: In function `.irq_create_of_mapping':
>> > (.text+0x147030): multiple definition of `.irq_create_of_mapping'
>> > arch/powerpc/kernel/built-in.o:(.text+0x9de0): first defined here
>> > kernel/built-in.o: In function `.irq_dispose_mapping':
>> > (.text+0x146f4c): multiple definition of `.irq_dispose_mapping'
>> > arch/powerpc/kernel/built-in.o:(.text+0x9684): first defined here
>> >
>> > I am not sure what caused this. And have just left it broken.
>>
>> Grant, is your irq remapper misbehaving ?
>
> Hmmmm, that's odd. =A0I've not touched it. =A0I'll investigate.
It looks like CONFIG_IRQ_DOMAIN is getting selected by TWL4030_CORE.
Drivers must not select that config symbol. It looks like commit
da28adbd (mfd: twl-core: Add initial DT support for twl4030/twl6030)
is the culprit.
The following patch should solve the problem:
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 13c468e..e43a570 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -200,8 +200,7 @@ config MENELAUS
config TWL4030_CORE
bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
- depends on I2C=3Dy && GENERIC_HARDIRQS
- select IRQ_DOMAIN
+ depends on I2C=3Dy && GENERIC_HARDIRQS && IRQ_DOMAIN
help
Say yes here if you have TWL4030 / TWL6030 family chip on your board.
This core driver provides register access and IRQ handling
next prev parent reply other threads:[~2012-01-02 8:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 8:49 linux-next: build failure after merge of the final tree (powerpc related) Stephen Rothwell
2011-12-28 8:49 ` Stephen Rothwell
2011-12-28 8:49 ` Stephen Rothwell
2011-12-28 10:32 ` Benjamin Herrenschmidt
2011-12-28 10:32 ` Benjamin Herrenschmidt
2012-01-02 8:25 ` Grant Likely
2012-01-02 8:25 ` Grant Likely
2012-01-02 8:39 ` Grant Likely [this message]
2012-01-02 8:39 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2012-06-20 7:50 Stephen Rothwell
2012-06-20 7:50 ` Stephen Rothwell
2012-06-20 10:09 ` Benjamin Herrenschmidt
2012-06-20 10:09 ` Benjamin Herrenschmidt
2012-06-21 5:36 ` Michael Ellerman
2012-06-21 5:36 ` Michael Ellerman
2012-06-21 6:24 ` Benjamin Herrenschmidt
2012-06-21 7:07 ` Michael Ellerman
2012-06-21 7:07 ` Michael Ellerman
2012-06-21 7:07 ` Michael Ellerman
2012-06-21 7:38 ` Michael Ellerman
2012-06-21 7:38 ` Michael Ellerman
2012-06-21 7:38 ` Michael Ellerman
2012-06-21 10:48 ` Alan Modra
2012-06-21 10:48 ` Alan Modra
2012-06-21 11:43 ` Alan Modra
2012-06-21 11:43 ` Alan Modra
2012-06-22 0:39 ` Michael Ellerman
2012-06-22 0:39 ` Michael Ellerman
2012-06-21 7:29 ` Gabriel Paubert
2010-09-03 3:24 Stephen Rothwell
2010-09-03 3:24 ` Stephen Rothwell
2010-09-17 4:27 ` Stephen Rothwell
2010-09-17 4:27 ` Stephen Rothwell
2010-07-16 7:19 Stephen Rothwell
2010-07-16 7:19 ` Stephen Rothwell
2010-07-16 7:19 ` Stephen Rothwell
2010-07-19 0:15 ` Benjamin Herrenschmidt
2010-07-19 0:15 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACxGe6txjt62u8fm8UBEfBDHmftgXO0XJJKQmAmh2Cy86ZfRaA@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=b-cousson@ti.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.